[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #19 from Justin L --- Created attachment 188079 --> https://bugs.documentfoundation.org/attachment.cgi?id=188079&action=edit 155813_ConditionalSpacingInTables_MSO2010.pdf: how it looks in Word 2010 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #18 from Justin L --- Created attachment 188078 --> https://bugs.documentfoundation.org/attachment.cgi?id=188078&action=edit 155813_ConditionalSpacingInTables.docx: demonstration of MSO logic -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #17 from Justin L --- Existing unit tests that have conditional spacing at the end of the cell -tdf150443.docx: interesting test. The first cell has upper spacing, but none of the rest of the cells do (because it is a different paragraph style than the last style before the table). The last column controls whether lower spacing is added, contrary to this bug report. Probably the reason is because it is not using the normal paragraph style. -tdf97090.docx: vertically centred "Издания Echoes:" in single cell/paragraph table. Neither upper nor lower spacing is applied - but the text is vertically centred in the row/table of a specified size (so it APPEARS as if it is applied). -n780853.docx: first cell conditional, second cell isn't. First cell is "Date" paragraph style, while preceding/following cells are not, so spacing needs to apply. -tdf123705.docx: a "list paragraph" bullet point during LAYOUT at end of page triggered the code. This is not the situation we are trying to address (although in that case the spacing isn't added anyway...) So, based on these observations, that adds a huge wrinkle to the problem. At the end of the cell, we need to know -is this really the end of the cell, or just the bottom of the page. -is there another column? Does it start with the same paragraph style? -is this the last column? (In this case, it appears as if MS Word treats the "following style" as the default style.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813
--- Comment #16 from Mike Kaganski ---
(In reply to SATYA SRINIVAS K from comment #15)
> Yes, this condition in the above function
> if (rIDSA.get(DocumentSettingId::ADD_PARA_LINE_SPACING_TO_TABLE_CELLS))
> {
> nAdditionalLowerSpace += _pAttrs->CalcLineSpacing();
> }
> adding a line spacing to nAdditionalLowerSpace when I bypass this adding
> line space my scenario is working fine
You might want to check if the "Don't add space between paragraphs of the same
style" applies to what CalcLineSpacing calculates, or maybe to another value.
> but how to decide when to skip this condition.
You might want to re-read comment 7, follow its link, and read the changed
code, to see what and when is used/skipped.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813
--- Comment #15 from SATYA SRINIVAS K ---
(In reply to Mike Kaganski from comment #14)
> You may be interested in SwFlowFrame::CalcAddLowerSpaceAsLastInTableCell
> function.
Yes, this condition in the above function
if (rIDSA.get(DocumentSettingId::ADD_PARA_LINE_SPACING_TO_TABLE_CELLS))
{
nAdditionalLowerSpace += _pAttrs->CalcLineSpacing();
}
adding a line spacing to nAdditionalLowerSpace when I bypass this adding line
space my scenario is working fine, but how to decide when to skip this
condition.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #14 from Mike Kaganski --- You may be interested in SwFlowFrame::CalcAddLowerSpaceAsLastInTableCell function. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #13 from Mike Kaganski --- I'm sorry - I likely messed with my testing. Re-tested now with a clean Word document, and indeed, the "Don't add space between paragraphs of the same style" makes the difference there. Disregard my previous comment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #12 from Mike Kaganski --- It has nothing to do with "Don't add space between paragraphs of the same style" feature. Unchecking this in Word makes no difference on whether it adds the space in the bottom of the cell. The more important is how this space below is handled at the bottom of the page. Test this: create several 1-line paragraphs, and set all of them to have large (say, 2 cm) spacing below - to make sure that more than 1 page is needed. Check how the bottommost paragraph on the first page is rendered; playing with the spacing, you may see that the spacing is ignored at the bottom, so that the paragraph is shown, even when the spacing below doesn't fit. This behavior is the same in Word and in Writer. But Word seems to treat cells the same way (which seems reasonable), while in Writer, it is added in cells. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #11 from SATYA SRINIVAS K --- There is a extra lower space in a cell which causes the shifting of rows to the next page if the table has more rows.As a test if I return 0 lower space from SwFlowFrame::CalcLowerSpace method, it is working fine with the larger table. (see attached "line_spacing_issue.png") -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #10 from SATYA SRINIVAS K --- Created attachment 188053 --> https://bugs.documentfoundation.org/attachment.cgi?id=188053&action=edit Line spacing issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #9 from SATYA SRINIVAS K --- Before the above mentioned commit, "Table_Rows_Rendering_Issue_MIN.docx" is working as same as MSO but the other document "Table_Rows_Rendering_Issue_Lo.docx" still has the same problem mentioned in the issue, maybe the root cause for these two documents are different ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813
--- Comment #8 from SATYA SRINIVAS K ---
The problem with this document ("Table_Rows_Rendering_Issue_MIN.docx") is
started appearing after this commit.
https://git.libreoffice.org/core/+/b271cc46851c61ddef20dc869bf339c857f76b18%5E%21/
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 SATYA SRINIVAS K changed: What|Removed |Added Keywords|bibisectRequest |bibisected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 SATYA SRINIVAS K changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #7 from Justin L --- (In reply to SATYA SRINIVAS K from comment #6) > Can you point out some code locations to start with it Follow the trail of See Also bug(s). Specifically https://gerrit.libreoffice.org/c/core/+/28692 which has links to the initial implementation of the entire feature in LO 3.6. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3507 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #6 from SATYA SRINIVAS K --- (In reply to Justin L from comment #5) > Created attachment 187906 [details] > Table_Rows_Rendering_Issue_MIN.docx: 1 page table with "Don't add space > between paragraphs of the same style" I will check and ignore adding the space between paragraphs of the same style, Can you point out some code locations to start with it ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 --- Comment #5 from Justin L --- Created attachment 187906 --> https://bugs.documentfoundation.org/attachment.cgi?id=187906&action=edit Table_Rows_Rendering_Issue_MIN.docx: 1 page table with "Don't add space between paragraphs of the same style" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 Justin L changed: What|Removed |Added Blocks|104522 |107830, 113545 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104522 [Bug 104522] [META] DOCX (OOXML) header & footer-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=107830 [Bug 107830] [META] DOCX (OOXML) paragraph-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=113545 [Bug 113545] [META] Paragraph spacing above and below and related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155813] FILEOPEN DOCX: Para Spacing below should not apply to last paragraph in cell when "Don't add space between paragraphs of the same style"
https://bugs.documentfoundation.org/show_bug.cgi?id=155813 Justin L changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Summary|Row in a table is rendered |FILEOPEN DOCX: Para Spacing |on the next page where as |below should not apply to |native application(MS word) |last paragraph in cell when |rendered on the same page |"Don't add space between ||paragraphs of the same ||style" Version|7.5.3.2 release |unspecified Blocks||104522 Keywords||filter:docx --- Comment #4 from Justin L --- (In reply to SATYA SRINIVAS K from comment #3) > looks like some height calculation when we have header and footer. I know that there is not a lot of 1 to 1 mapping in the header/footer configurations - a lot is just emulation, trying to get the two to look similar. MS Word has no concept of page styles, while LO puts everything header/footer related into a page style. So there are all kinds of incompatible results in this area. Likely there is no "correct" answer here, and it would take a lot of effort to learn the specific quirks in each system in order to propose a better "emulation". (see bug 70195, bug 146347, bug 137111 and bug 131531) However, I don't think that is the problem in this case. I did a PDF comparison of MSO 2010 and LO 24.2. The biggest vertical difference seems to be the last bullet point "String" in row 2. There is direct pargraph formatting "spacing after/below" of 10pt/.35cm/.64 line. This is being ignored by MS Word (I assume because of "don't add space between paragraphs of the same style" and the fact that there is no paragraph after this one. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104522 [Bug 104522] [META] DOCX (OOXML) header & footer-related issues -- You are receiving this mail because: You are the assignee for the bug.
