[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #11 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd009cffc38a280d3b072ae4dc9ee9cda2e1f13f tdf#157650 Unhelpful error when XML in content.xml is malformed It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #10 from Ezinne --- Reproducible in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7ef3d937415185ef66e32dd3043783eddcd03db5 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 BogdanB changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords|bibisectRequest |bibisected, bisected, ||regression Blocks||34694 CC||buzea.bog...@libreoffice.or ||g, noelgran...@gmail.com --- Comment #9 from BogdanB --- Confirm in 24.2. I added Noel Grandin. I don't know if it is a bug or not, but I bibisected it. 14338104ecf1e2739c5a477f0ce6f1fe761c1791 is the first bad commit commit 14338104ecf1e2739c5a477f0ce6f1fe761c1791 Author: Jenkins Build User Date: Tue Oct 3 18:16:02 2023 +0200 source sha:d9e322d60f65ff20631dab87baa5a2c7c71daaa2 source sha:d9e322d60f65ff20631dab87baa5a2c7c71daaa2 instdir/program/libPresentationMinimizerlo.so | Bin 378712 -> 378720 bytes instdir/program/libbasctllo.so| Bin 2311008 -> 2311016 bytes instdir/program/libcomphelper.so | Bin 2849704 -> 2849232 bytes instdir/program/libcuilo.so | Bin 5571696 -> 5571528 bytes instdir/program/libdbaxmllo.so| Bin 528576 -> 528584 bytes instdir/program/libeditenglo.so | Bin 3547336 -> 3547168 bytes instdir/program/libfps_officelo.so| Bin 669144 -> 673328 bytes instdir/program/libfrmlo.so | Bin 4763968 -> 4763968 bytes instdir/program/libmswordlo.so| Bin 3585328 -> 3589424 bytes instdir/program/libooxlo.so | Bin 7241920 -> 7241928 bytes instdir/program/libpdffilterlo.so | Bin 454328 -> 454336 bytes instdir/program/librptxmllo.so| Bin 596032 -> 596040 bytes instdir/program/libsblo.so| Bin 2531336 -> 2535560 bytes instdir/program/libscfiltlo.so| Bin 6935536 -> 6935632 bytes instdir/program/libsclo.so| Bin 24550968 -> 24557448 bytes instdir/program/libscuilo.so | Bin 1084168 -> 1084176 bytes instdir/program/libsdlo.so| Bin 11321672 -> 11321064 bytes instdir/program/libsfxlo.so | Bin 8544232 -> 8560616 bytes instdir/program/libsmlo.so| Bin 2494544 -> 2494552 bytes instdir/program/libsvtlo.so | Bin 3240064 -> 3239792 bytes instdir/program/libsvxcorelo.so | Bin 13321720 -> 13321720 bytes instdir/program/libsvxlo.so | Bin 5992832 -> 5996936 bytes instdir/program/libswlo.so| Bin 27865864 -> 27873960 bytes instdir/program/libswuilo.so | Bin 3533824 -> 3533832 bytes instdir/program/libuuilo.so | Bin 404680 -> 404784 bytes instdir/program/libvcllo.so | Bin 20925944 -> 20919944 bytes instdir/program/setuprc | 2 +- instdir/program/versionrc | 2 +- 28 files changed, 2 insertions(+), 2 deletions(-) author Noel Grandin 2023-09-30 20:47:46 +0200 committer Noel Grandin 2023-10-03 10:12:41 +0200 commit d9e322d60f65ff20631dab87baa5a2c7c71daaa2 (patch) treed481e5a4728363b3866b5b5f6dbe64a2780b04a6 parent 64fc701388d1dcf8ae36ba2cc73eb5416a7c3374 (diff) replace ErrorInfo with simpler mechanism Instead of returning ErrCode class everywhere, return a new class ErrrCodeMsg, which combines an ErrCode with the other parameters that are used to control the error reporting. I do not change everything that uses ErrCode here, I started from SfxBaseController/SfxMedium and worked outwards. This change serves two purposes (1) Replace the extremely whacky ErrorInfo mechanism we were using to smuggle information into the error handler reporting mechanism with a very straightforward approach of just combining it into the error class. (2) Allow us to capture the source location that produced the error, which makes debugging the source of a problem s much easier. Change-Id: I978b8f00c9851b41a216c7ebdef2ef94251d5519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157440 Tested-by: Jenkins Reviewed-by: Noel Grandin Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=34694 [Bug 34694] [META] Improve usability of error messages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #8 from m.a.riosv --- I think bibisect should wait for someone else confirmation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 Jambunathan K changed: What|Removed |Added Keywords||bibisectRequest --- Comment #7 from Jambunathan K --- Since the bug is a regression, I am marking the bug with a `bibisect request` -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #6 from Jambunathan K --- Created attachment 190087 --> https://bugs.documentfoundation.org/attachment.cgi?id=190087=edit lo 7.5 screenshot (Good) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #5 from Jambunathan K --- Created attachment 190086 --> https://bugs.documentfoundation.org/attachment.cgi?id=190086=edit lo 7.6 screenshot (Good) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #4 from Jambunathan K --- (In reply to m.a.riosv from comment #3) > Created attachment 190082 [details] > Screnshoot with the message v 24.02 > > For me, it shows the number line/row. > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee > CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: > win > Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo > > There is the ODF validator, that shows a bit more information. > https://odfvalidator.org/ I don't have a windows machine. So, I can't confirm with Windows. On linux side, I have mutiple builds installed, and I confirm that there this is a regression between 2 builds 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8 (ok) and 2a217a80bf383ddab0a5e0959ab2fd907dfd3406 (not ok) Should be easy to spot the offending commit with simple change log tracking or bisection Doesn't work with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2a217a80bf383ddab0a5e0959ab2fd907dfd3406 CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded Works with the following two versions of LO Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8 CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Debian package version: 4:7.5.5-4 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Created attachment 190082 --> https://bugs.documentfoundation.org/attachment.cgi?id=190082=edit Screnshoot with the message v 24.02 For me, it shows the number line/row. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo There is the ODF validator, that shows a bit more information. https://odfvalidator.org/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #2 from Jambunathan K --- Created attachment 190077 --> https://bugs.documentfoundation.org/attachment.cgi?id=190077=edit Screenshot of what Emacs' XML parser / validator does ... Compare this with what LO does -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 Jambunathan K changed: What|Removed |Added Component|Writer |Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed
https://bugs.documentfoundation.org/show_bug.cgi?id=157650 --- Comment #1 from Jambunathan K --- Created attachment 190076 --> https://bugs.documentfoundation.org/attachment.cgi?id=190076=edit Error reported by LO 24.2 when the malformed ODS will opened -- You are receiving this mail because: You are the assignee for the bug.
