[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #19 from Troy Rollo  ---
I have decided to discontinue contributing to LibreOffice, hence will not be
doing any further work on this. The process for contributing to LibreOffice
development has become a bureaucratic nightmare and it is just far too much
work for casual contributions. I have better things to do with my time than try
to jump through a never-ending series of hoops to get a simple patch accepted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #18 from Troy Rollo  ---
Absent any further comment I propose to submit a patch to substitute the 72
colour palette for the present 9 colour palette.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #17 from Troy Rollo  ---
Created attachment 187017
  --> https://bugs.documentfoundation.org/attachment.cgi?id=187017=edit
Another Alternative Palette Sample

Same concept, but 72 colours in total and different spacing between the
colours.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #16 from Troy Rollo  ---
Created attachment 186995
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186995=edit
Alternative palette sample

Attaching a PDF with an alternative palette that:

1. keeps faith with the historical behaviour by having the first author's
comments in close to the same yellow background as was used historically and
having track changes colours that have perceptible similarity to the comments
background;

2. changes the track changes colours so that they are (based on the CIE Lab
colour space) perceptually different, and largely better (and nearly uniformly)
contrasted with white; and

3. increases that palette to 96 entries (from 9 previously)

Comments?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

Troy Rollo  changed:

   What|Removed |Added

 CC||libreoff...@troy.rollo.name

--- Comment #15 from Troy Rollo  ---
Created attachment 186971
  --> https://bugs.documentfoundation.org/attachment.cgi?id=186971=edit
PDF showing existing colour usage and the RGB, HSV, HSL, CIE LCH(ab) and CIE
Lab representations of them

I have attached a PDF showing the existing colour usage for the 9 by-author
colour sets, together with the RGB, HSV, HSL, CIE LCH(ab) and CIE Lab
representations for those colours

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #14 from Troy Rollo  ---
This choice of colours comes from having sought to use a consistent colour
scheme for inline edits, margin notes, and annotations in Draw. There are 9
define "Author" colour sets, each with a light, normal and dark colour. The
author colours for annotations are chosen from the dark colour in the set, but
with each colour in the set being a similar hue.

For comments, these colours are used as follows: The comment box gets a
background that is the light colour at the top, fading to the normal colour at
the bottom, with the text at the bottom that identifies the author being in the
dark colour.

The first colour in the set uses a "normal" that is intended to appear like a
stock yellow PostIt note, for use in the comments. The code even makes
reference to "PostIt".

This means that there has to be a particular usable relationship between the 3
colours in each of the 9 sets. However the text on the margin note body remains
black on white, which gives a less than ideal appearance.

There is a choice to be made here:

1. We can select the colour based on the inline "by-author" colour we want,
then generate a contrasting "light" and "normal" colour (if the "by-author"
colour is less than 50% luminousity, by making those colours near black rather
than pastels). This will break the intended "post-it" appearance. This is not a
difficult task.

2. We could leave the hard codings but move colour 1 down to colour 9, and
start with colour 2 (which would give a first "by author" edit colour that is a
navy blue. Again this would break the intended appearance of a standard post-it
for the first author's comments.

3. We could abandon the by-author colouring for comments. As at today,
Microsoft does not do this, instead having a red circle in the matching colour
with the author's initials in white. LO also stops doing this when it is put in
high contrast mode.

4. We could let the user define all three colours. Unattractive due to the
number of selections required.

5. We could combine 1 & 4 - default to calculated colours and let the user edit
them. The underlying structure needs to support this anyway so that we can have
the existing colour sets continue if they have not been edited.

I am reluctant to just drop the relationship between the inline edits and the
comments, or to remove the comment colouring entirely, because that would
involve dropping a dropping a long-standing feature. I am inclined to go with
option 1, and let the post-it colours follow the track-changes by author
colours.

Does anybody else have any preferences for this?

(Anybody who is interested in looking at the code for this, grep for
COL_AUTHOR1)

(Calc does things differently with its by-author colouring).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #13 from brabitom  ---
I add my voice to the list of people requesting this! Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #12 from servalli...@gmail.com ---
Also here to ask for the addition of this setting.

The default setting makes the changes completely unreadable in dark mode for
some of the colors,for instance, the blue.

The colors either need to be changed to be visible both on white and dark grey,
or a possibility to change the palette should be added.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #11 from yolakalem...@protonmail.com ---
since 2010? 11 years? Nothing?

Just passing by to add my voice to the list of people requesting this!
Pleaase devs.

Current setting is ridiculous.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #10 from Thierry  ---
What is the status of this one ?
On my side, the default yellow color used to track each change I'm applying is
almost non-readable... 
Could it be possible to change that, while keeping the possibility to have a
different color for each reviewer ?
Idea being to define the colors for Reviewer 1 (ourselves), Reviewer 2,
Reviewer 3,... in the parameters of your own application.

Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||bugquestcon...@online.de

--- Comment #9 from NISZ LibreOffice Team  ---
*** Bug 65231 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

Pénzes Dávid  changed:

   What|Removed |Added

 Blocks||83946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Bugs for tracking changes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

--- Comment #8 from RonnyC  ---
It would be nice to have a menu to change the tracking colour for the first,
second, third ... author myself. Maybe one could handle colours for specific
authors (identified by name and than in the changes even have the same colour
in all edited documents).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color "by author" adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32700

Adolfo Jayme  changed:

   What|Removed |Added

  Component|LibreOffice |UI
Version|3.3.0 RC2   |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color by author adjustable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32700

bfoman bfo.bugm...@spamgourmet.com changed:

   What|Removed |Added

 CC||bfo.bugm...@spamgourmet.com

--- Comment #7 from bfoman bfo.bugm...@spamgourmet.com ---
Updated code pointer:
http://opengrok.libreoffice.org/xref/core/include/tools/color.hxx#59

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color by author adjustable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32700

Jean-Baptiste Faure jbf.fa...@orange.fr changed:

   What|Removed |Added

 CC||jbf.fa...@orange.fr

--- Comment #6 from Jean-Baptiste Faure jbf.fa...@orange.fr 2012-07-10 
09:12:09 PDT ---
Hi Rainer,

Cédric said me on irc that these colors are hard coded. :-(
The colors are defined here :
http://opengrok.libreoffice.org/xref/core/tools/inc/tools/color.hxx#72

Best regards. JBF

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color by author adjustable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32700

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||LibreOffice@bielefeldundbus
   ||s.de
Summary|Track changes colour|UI: Make Track Changes
   ||Color by author
   ||adjustable

--- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-09 09:04:37 PDT ---
Zack's comment is correct, default color By Author for changes will be
defined by LibO to show different author's changes in different colors. 

But I have no idea where the setting can be adapted, if I am the Author with
the light yellow changes (on light yellow page background) I would like to
modify that to make my changes better readable.

Current behavior is inherited from OOo

May be it's only a knowledge gap and it's possible to modify the default
changes color?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32700] UI: Make Track Changes Color by author adjustable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32700

--- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-09 09:34:06 PDT ---
Created attachment 64012
  -- https://bugs.freedesktop.org/attachment.cgi?id=64012
Screenshot

Additionally the resulting color should be shown in Menu 'Tools - Options -
Writer - Changes'. Currently color shown is always dark red in dialog (also
inherited from OOo).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs