[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Stephan Bergmann  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #26 from Stephan Bergmann  ---
Per the comment at

"tdf#38890 Remove hard-coded URLs in source Files":  "So about this bug 149115:
tdf#38890 Remove hard-coded URLs in source Files |
https://gerrit.libreoffice.org/c/core/+/149115, are there no more hardcoded
urls in the source, after grep libreoffice, most outputs are instances of open
office or comments or Test codes"

And I also hardly find anything that looks like it could be another target for
this easyHack when I search now, so lets leave it at that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #25 from Commit Notification 
 ---
Adoche Onaji committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1dc8d302f5a7c7b8f69261f86ff01377a910c68

tdf#38890 Remove hard-coded URLs in source Files

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|reviewed:2022   |reviewed:2022 target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Buovjaga  changed:

   What|Removed |Added

 CC||dochieon...@gmail.com

--- Comment #24 from Buovjaga  ---
(In reply to Adoche Onaji from comment #23)
> The fail I Saw came in from ww8export3.cxx because it has a block of code in
> there:
> 
> DECLARE_WW8EXPORT_TEST(testHyperLinkURLSaving, "tdf120003.doc")
> {
> OUString URL = getProperty(getShape(1), "HyperLinkURL");
> // Without the fix in place, this test would have failed with
> // - Expected: https://www.libreoffice.org/
> // - Actual  : tps://www.libreoffice.org/
> CPPUNIT_ASSERT_EQUAL(OUString("https://www.libreoffice.org/;), URL);
> }

This is about https://gerrit.libreoffice.org/c/core/+/142005

Undo your changes in the test (qa) directories. The use of www.libreoffice.org
URLs there is just a coincidence and not relevant for this hack.

So undo like

git checkout master -- sw/qa/extras/odfexport/odfexport2.cxx

for each file and update your patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #23 from Adoche Onaji  ---
The fail I Saw came in from ww8export3.cxx because it has a block of code in
there:

DECLARE_WW8EXPORT_TEST(testHyperLinkURLSaving, "tdf120003.doc")
{
OUString URL = getProperty(getShape(1), "HyperLinkURL");
// Without the fix in place, this test would have failed with
// - Expected: https://www.libreoffice.org/
// - Actual  : tps://www.libreoffice.org/
CPPUNIT_ASSERT_EQUAL(OUString("https://www.libreoffice.org/;), URL);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #22 from Adoche Onaji  ---
(In reply to Stephan Bergmann from comment #19)
> (In reply to Björn Michaelsen from comment #0)
> > Background: We still have a number of hardcoded URLs around the place, some
> > of which become visible in the UI. We should have these extracted from a
> > config file instead - preferably a textual 'rc' file (sal has code to parse
> > and use these cf. boots).
> 
> Note that many such URLs are now stored in the configuration, see properties
> "SendFeedbackURL" etc. in
> officecfg/registry/data/org/openoffice/Office/Common.xcu.  That's probably
> the preferred way now.

I am currently working on this bug and have made some progress. I have moved
the URLs to the Common.xcu files and modify neccessary CPPUnitTest files,
running make was successful bug I am getting an error from make check. 
Something of this nature:
[_RUN_] testImageHyperlink::TestBody
image-hyperlink.docx:
/home/samuel/Documents/Dev/libreoffice/sw/qa/extras/ooxmlimport/ooxmlimport.cxx:82:testImageHyperlink::TestBody
equality assertion failed
- Expected: https://libreoffice.org/
- Actual  : http://www.libreoffice.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Adoche Onaji  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Hossein  changed:

   What|Removed |Added

 Whiteboard||reviewed:2022

--- Comment #21 from Hossein  ---
Re-evaluating the EasyHack in 2022

This enhancement is still relevant. Some hard-coded project URLs are still in
the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|rasheshpadia...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

--- Comment #20 from Xisco Faulí  ---
Dear  Padia Rashesh,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Padia Rashesh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rasheshpadia...@gmail.com
   |desktop.org |

--- Comment #17 from Padia Rashesh  ---
Basically I have to create a .rc file which contains all the URLs and somehow
read it with help of bootstrap.hxx at runtime 
But I am confused on the following points:

1) grep for libreoffice.org - BEWARE - many instances of openoffice.org are
standards related around ODF and other XML file formats - these must -not- be
changed (obviously). But ones that point to simple web pages make good targets
for clean configurability. 

I don't understand what you are trying to say, can you explain with example?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #16 from Buovjaga  ---
(In reply to rino19ny from comment #15)
> wow more than 4 years!
> 
> someone still working on this?
> 
> by "..around the place.." meaning most source files still have hardcoded
> URLs??

Please don't change the status to needinfo:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO
Needinfo reports will be automatically closed after some time, so you don't
want to do that here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

rino1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #15 from rino1...@gmail.com ---
wow more than 4 years!

someone still working on this?

by "..around the place.." meaning most source files still have hardcoded URLs??

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

Buovjaga  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

adityapratapsing...@gmail.com changed:

   What|Removed |Added

   Assignee|adityapratapsingh51@gmail.c |libreoffice-b...@lists.free
   |om  |desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

adityapratapsing...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |adityapratapsingh51@gmail.c
   |desktop.org |om

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #14 from Buovjaga  ---
(In reply to adityapratapsingh51 from comment #13)
> Could you explain what "...and use these cf. boots..." means?

cf. means comparison. Note comment 5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #13 from adityapratapsing...@gmail.com ---
(In reply to Björn Michaelsen from comment #0)
> Remove hard-coded project URLs
> 
> Background: We still have a number of hardcoded URLs around the place, some
> of which become visible in the UI. We should have these extracted from a
> config file instead - preferably a textual 'rc' file (sal has code to parse
> and use these cf. boots). To find many instances of hard-coded URLs use:
> 
> bin/g grep '"http://' | grep '\.[ch]xx:'
> 
> or grep for libreoffice.org - BEWARE - many instances of openoffice.org are
> standards related around ODF and other XML file formats - these must -not-
> be changed (obviously). But ones that point to simple web pages make good
> targets for clean configurability.
> 
> Skills: git grep, simple C++ programming

Could you explain what "...and use these cf. boots..." means?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #12 from jan iversen  ---
(In reply to Asela from comment #11)
> Hey
> I would like to contribute to fix this bug. Is it still open ?
> Is there any specific code pointers that should start

Welcome, follow comment #1

And also have a look at 
https://wiki.documentfoundation.org/Development/GetInvolved

have fun

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

--- Comment #11 from Asela  ---
Hey
I would like to contribute to fix this bug. Is it still open ?
Is there any specific code pointers that should start

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

jan iversen  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #10 from jan iversen  ---
Resetting status.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38890

jan iversen  changed:

   What|Removed |Added

   Assignee|baslpet...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #9 from jan iversen  ---
Unassign due to lack of work.

Please remark, if you start working on the issue again, feel free to assign it
to yourself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38890

Petr Basl baslpet...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |baslpet...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38890

--- Comment #3 from Petr Basl baslpet...@gmail.com ---
I would like to take this bug, if possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38890

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #2 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38890] Remove hard-coded project URLs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38890

Florian Reisinger reisi...@gmail.com changed:

   What|Removed |Added

Summary|[EasyHack] Remove   |Remove hard-coded project
   |hard-coded project URLs |URLs

--- Comment #1 from Florian Reisinger reisi...@gmail.com 2012-05-18 09:03:33 
PDT ---
Deteted Easyhack from summary

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs