[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #7 from Stephan Bergmann sberg...@redhat.com 2012-04-23 12:13:21 PDT --- (In reply to comment #5) Created attachment 59853 [details] [review] This includes the suggested changes for namecont.cxx pushed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=c9afb3f5a7f713d34f70b680c5d4ab3db4044d1c -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #8 from Stephan Bergmann sberg...@redhat.com 2012-04-23 12:14:43 PDT --- (In reply to comment #6) Created attachment 59855 [details] [review] A patch for copytablewizard.cxx pushed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=67d022ac0ce5e67565e0589f4cd9eb05a8fd5a3c -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #4 from Stephan Bergmann sberg...@redhat.com 2012-04-12 00:45:56 PDT --- (In reply to comment #3) Created attachment 59811 [details] [review] Patch to fix namecont.cxx See http://lists.freedesktop.org/archives/libreoffice/2012-April/029894.html for a comment about that patch. (In general, it is better to present a patch for review in one place only, either in a bug or on the mailing list.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 Abeer Sethi abeersethi...@gmail.com changed: What|Removed |Added Attachment #59811|0 |1 is obsolete|| --- Comment #5 from Abeer Sethi abeersethi...@gmail.com 2012-04-12 05:39:44 PDT --- Created attachment 59853 -- https://bugs.freedesktop.org/attachment.cgi?id=59853 This includes the suggested changes for namecont.cxx -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #6 from Abeer Sethi abeersethi...@gmail.com 2012-04-12 05:40:45 PDT --- Created attachment 59855 -- https://bugs.freedesktop.org/attachment.cgi?id=59855 A patch for copytablewizard.cxx -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #3 from Abeer Sethi abeersethi...@gmail.com 2012-04-11 12:08:43 PDT --- Created attachment 59811 -- https://bugs.freedesktop.org/attachment.cgi?id=59811 Patch to fix namecont.cxx -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #2 from Stephan Bergmann sberg...@redhat.com 2012-03-19 03:45:37 PDT --- Re comment 1: 1 Lines are cut from the output in http://pastebin.com/raw.php?i=XAR4s81e. (And better attach a patch to this issue than going via pastebin, anyway.) 2 For simple string messages like throw RuntimeException(OSL_FORMAT(XListener is not equal to 1)); there is no need to go via OSL_FORMAT. The standard idiom to create an rtl::OUString instance from an (ASCII) string literal for now is rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(XListener is not equal to 1)) 3 RuntimeException constructors either take no arguments or two arguments (Message, a string; and Context, a com::sun::star::uno::XInterface reference to the relevant UNO object or a null reference). So, in basic/source/uno/namecont.cxx you would need a second argument static_cast cppu::OWeakObject * (this) (where the cast is necessary as this derives from XInterface multiple times), and in the later files you would need to move your new, third argument to be the first one instead, replacing the empty rtl::OUString() -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 --- Comment #1 from Abeer Sethi abeersethi...@gmail.com 2012-03-18 14:13:42 PDT --- Can you tell me from my git-diff whether I'm on the right track? http://pastebin.com/raw.php?i=XAR4s81e -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42982] [EasyHack] improve UNO API error reporting
https://bugs.freedesktop.org/show_bug.cgi?id=42982 Michael Stahl mst...@redhat.com changed: What|Removed |Added Status Whiteboard||EasyHack DifficultyBeginner ||SkillCpp -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
