[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 abhilash300si...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |abhilash300si...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #38 from abhilash300si...@gmail.com --- Thanks for pointing out. I agree. The previous patch added a space irrespective of the fact whether or not numbering was done( For example - in attached file toc.odt, the previous patch also added a space to Heading-1 "Null" which wasn't even numbered and hence didn't require spacing. Comment 6 mentions the same problem). My patch merely made sure that spacing is applied only when numbering is available( leaving the Heading 1 "Null" in toc.odt and taking care of all other Headings). So, what in addition needs to be done is - if the user has specified something between and ( a space or some other character ) we don't need the default spacing to be applied. And in all other cases we need the default spacing to be applied. Is that so? Please confirm, and I will commit a patch soon accordingly. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Cor Nouws changed: What|Removed |Added CC||abhilash300si...@gmail.com --- Comment #37 from Cor Nouws --- @abhilash, Can you please look at comment #34 and 35? Thanks for your efforts on this issue - great to see progress! Ciao - Cor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Cor Nouws changed: What|Removed |Added CC||zyklo...@web.de --- Comment #36 from Cor Nouws --- *** Bug 103149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #35 from Gabor Kelemen --- Created attachment 126860 --> https://bugs.documentfoundation.org/attachment.cgi?id=126860&action=edit Screenshot of the example documents TOCs with the new fix -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Commit Notification changed: What|Removed |Added Whiteboard|target:5.2.0|target:5.2.0 target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #33 from Commit Notification --- Abhilash Singh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce95e39f8e952159844e9dc04a1df402bb103634 tdf#44282 fix missing space for numbered lists in TOC It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #32 from jan iversen --- (In reply to Raj Sarkar from comment #31) > I'm new here and want to solve this bug. I've understood the bug and have > even replicated it. I took a look at one of the patches in the > comments(which seems to not account for all the cases). > > Comment 19 explains what actually needs to be done and I quote a part of it > here - > > "If we take a step backwards, Writer should take it into consideration > - what is already imported in the TOC, > - what is set as a separator for the given level of numbering in the Bullets > and Numbering window, Position tab, "Numbering followed by" dropdown, which > has three possible values: Tab stop, Space, Nothing." > > Can I know where should I look for the code related to the two points > mentioned in the above comment? Welcome, in general have a look at: https://wiki.documentfoundation.org/Development/GetInvolved Code pointers are found in comment #18, That patch was good, but had some side effects, so the easiest way is to take the patch, test it, and correct it. The problem the patch introduced was around outlining at higher levels than 2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #31 from Raj Sarkar --- I'm new here and want to solve this bug. I've understood the bug and have even replicated it. I took a look at one of the patches in the comments(which seems to not account for all the cases). Comment 19 explains what actually needs to be done and I quote a part of it here - "If we take a step backwards, Writer should take it into consideration - what is already imported in the TOC, - what is set as a separator for the given level of numbering in the Bullets and Numbering window, Position tab, "Numbering followed by" dropdown, which has three possible values: Tab stop, Space, Nothing." Can I know where should I look for the code related to the two points mentioned in the above comment? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 abhilash300si...@gmail.com changed: What|Removed |Added Assignee|abhilash300si...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 abhilash300si...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |abhilash300si...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Geert Custers changed: What|Removed |Added Assignee|geert.aj.cust...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Geert Custers changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |geert.aj.cust...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 jan iversen changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 jan iversen changed: What|Removed |Added Whiteboard|ToBeReviewed target:5.2.0 |target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 jan iversen changed: What|Removed |Added Assignee|thab...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Mohamed Thabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |thab...@gmail.com |desktop.org | --- Comment #16 from Mohamed Thabet --- Hello, I want to fix this bug -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 jan iversen changed: What|Removed |Added Keywords|difficultyEasy |difficultyBeginner -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Andras Timar changed: What|Removed |Added Whiteboard|needsDevEval|EasyHack DifficultyEasy ||SkillCpp --- Comment #13 from Andras Timar --- (In reply to ababaaa from comment #11) > Hello ,I am a rookie and want to solve this as my first easy bug hack. > Can any body give me idea how should I procede. > Thanks in Advance. See OUString SwTextNode::GetExpandText() in sw/source/core/txtnode/ndtxt.cxx and TextAndReading SwTOXPara::GetText_Impl() in sw/source/core/tox/txmsrt.cxx. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Cor Nouws changed: What|Removed |Added Whiteboard|needDevEval |needsDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Zangune changed: What|Removed |Added CC||Zangune@Users.SourceForge.N ||et Whiteboard|NeedDevEval |needDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and outline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 Owen Genat changed: What|Removed |Added Summary|[FORMATING] [TOC] space |[FORMATING] [TOC] space |missing between text and|missing between text and |ouline numbering|outline numbering -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
