[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Ilhan Yesil changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ilhanye...@gmx.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Xisco Faulí changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|ilhanye...@gmx.de |libreoffice-b...@lists.free ||desktop.org --- Comment #82 from Xisco Faulí --- Dear Ilhan Yesil, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Ilhan Yesil changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |ilhanye...@gmx.de |desktop.org | --- Comment #59 from Ilhan Yesil --- Hello, I want to work on this bug, it looks interesting and will be my second contribution to libreoffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| --- Comment #58 from Heiko Tietze --- No need for input from UX I guess. Removing the ML from CC. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #57 from Howard Johnson --- (In reply to Lionel Elie Mamane from comment #56) > ..the right place to discuss that is the development > mailing list at https://lists.freedesktop.org/mailman/listinfo/libreoffice Thanks. I said >>...report writer, .. extremely slow To briefly follow up on this, after days of looking, I just discovered why one of my base reports was so extremely slow saving and reporting, and how to easily fix it. I'll submit in another bug report. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #56 from Lionel Elie Mamane --- (In reply to Howard Johnson from comment #54) > No really, the more important bug I think, is that the LO source code is > mostly too hard to work on. > MY QUESTION: Are code comment-only commits (i.e. comments w/o any code > changes) welcome to the powers that be here? I expect so. I expect the right place to discuss that is the development mailing list at https://lists.freedesktop.org/mailman/listinfo/libreoffice > 2) As for THIS bug, and having used database report writers (plural) > with CanGrow and CanShrink type features, I am definitely of the opinion > that BOTH of these properties are required, not just AutoGrow, and need > to be added to all controls. Yes, the way I was suggesting this to be implemented is actually equivalent to setting both "CanShrink" and "CanGrow". Setting it per-row can be done relatively easily with the current infrastructure. Setting it per-control requires a deeper redesign of report builder, or a new feature in ODT/Writer. Report builder now "just" creates an ODT document, and Writer does all the actual layouting. So per-control would require that *Writer* support the feature of "autogrow" (which it calls "optimal row height") per cell, and not only per row. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #55 from Ulf Zibis --- (In reply to Howard Johnson from comment #54) > MY QUESTION: Are code comment-only commits (i.e. comments w/o any code > changes) welcome to the powers that be here? > > I realize that the people who wrote this are probably long gone, so any > comments will only try to recapture some of what was in their heads, and > comments will definitely be a work in progress, so some tolerance for not > getting them right the first time would be appreciated. > > Also my call for comments is not just about this bug. It appears to me that > there are a whole backlog of Base bugs that are in the category of: Given > the volunteer time we have available, 'too hard' to fix right now. > > > Can I get a green light to start to add comments to the code to make it more > readable, AND if yes, is there some community tolerance for how this is to > be done, as any comments might be better than none? > > I have some particular commenting styles I've developed over the years, but > even I don't always stick to my commenting styles. :-) For one I never > like processing comments into documentation, so I don't do that. Comments I > think are to help engineers read the code, period. Hi Howard, I appreciate your offer. I'm not one of the deciders here, I just like to comment, that it might be better to open a new bug fot this. You might have more readers then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #54 from Howard Johnson --- Created attachment 140395 --> https://bugs.documentfoundation.org/attachment.cgi?id=140395&action=edit another, larger database to demo this bug 6 years, 16 volunteers, 4 duplicates, tough bug! (-: My attachment here today is a more comprehensive Base report to further demo this issue. :-) 1) I think we might be starting with the wrong bug. No really, the more important bug I think, is that the LO source code is mostly too hard to work on. I have myself begun to study the source base, but in most places it lacks the most basic comments to help the unfamiliar figure out how it works, to be able to read the code to even work on bugs like this. (A few years go by and I can't even read my own code without a few comments to refresh my memory. And as we all get older, this issue gets worse.) So what I think is needed _first_, is to work together (or alone) to start to add sufficient comments to the code base to help new coders find their way around. One needs to be able to read the code without going to an extreme amount of work. I am willing to help with such an effort, as I begin to try and read the code myself. (Please see more specific question about this below.) 2) As for THIS bug, and having used database report writers (plural) with CanGrow and CanShrink type features, I am definitely of the opinion that BOTH of these properties are required, not just AutoGrow, and need to be added to all controls. The reason for CanShrink is that if no data is in group, it is often desirable to fully collapse the group, so as to save paper space where it's not needed. But this can only reasonably work if CanShrink is also available. In this case you would set the can-shrink on all fields in the group, and also on the group itself. Furthermore, I think it would make no sense to fix only half of this problem, and to miss the other half, especially when it is so hard to do, and these are so closely related. 3) Finally, and sadly, the Base report writer, as it is, is extremely slow. Just try to produce a report with 100 pages sometime. It takes forever. So I think any work done on #1 or #2 above should keep a watchful eye on someday re-writing the slower parts, (or the whole thing) to be faster. For one, I can see from the above comments that Java is involved. At a minimum I think that it someday needs to get rewritten in some flavor of C, as I have found java to sometimes be slow. SUMMARY: So my point #1 above (call for code comments), becomes even more important in the long haul: It will help fix things now, and make things faster in the future. MY QUESTION: Are code comment-only commits (i.e. comments w/o any code changes) welcome to the powers that be here? I realize that the people who wrote this are probably long gone, so any comments will only try to recapture some of what was in their heads, and comments will definitely be a work in progress, so some tolerance for not getting them right the first time would be appreciated. Also my call for comments is not just about this bug. It appears to me that there are a whole backlog of Base bugs that are in the category of: Given the volunteer time we have available, 'too hard' to fix right now. Can I get a green light to start to add comments to the code to make it more readable, AND if yes, is there some community tolerance for how this is to be done, as any comments might be better than none? I have some particular commenting styles I've developed over the years, but even I don't always stick to my commenting styles. :-) For one I never like processing comments into documentation, so I don't do that. Comments I think are to help engineers read the code, period. Thanks. I'm so independent that I often won't do what I put on my own to-do list. :-~ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Howard Johnson changed: What|Removed |Added CC||BridgeportContractor@gmail. ||com --- Comment #53 from Howard Johnson --- *** Bug 116210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #52 from gdaheffer...@hotmail.com --- Thank you Alex for spotting and e-mailing me that my enhancement Bug 114387 has already been submitted as 45789. I apologize for any inconvenience caused. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Alex Thurgood changed: What|Removed |Added CC||gdaheffer...@hotmail.com --- Comment #51 from Alex Thurgood --- *** Bug 114387 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 rob...@familiegrosskopf.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||4387 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 jan iversen changed: What|Removed |Added Whiteboard|ToBeReviewed| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #49 from Lionel Elie Mamane --- (In reply to kerem from comment #45) > (In reply to Lionel Elie Mamane from comment #44) >> The saving of the report definition happens in C++, in >> reportdesign/source/filter/xml/ >> I think it is particularly in reportdesign/source/filter/xml/xmlExport.cxx >> function void ORptExport::exportContainer(const Reference< XSection>& >> _xSection) >> looks relevant; need to set the right attribute or style for "automatic >> height" there. > Okey I understand. So I change something in function void > ORptExport::exportContainer(const Reference< XSection>&_xSection). I change > that about the "automatic height", is true? In addition to, are there any > your suggestions? Sorry it took me so long to answer. Basically, yes, that is my guess, but that is about step 3 from comment 22. We also (first?) need to do steps 1 and 2 from comment 22. See also comment 24 and comment 26. To summarise: the work is to add a property "AutoGrow" to every control. It needs to be added to the control models and to the UI that allows to user to set that property. Then, in RptExport::exportContainer, if any of the controls of this row has "AutoGrow" set to true, then set the "automatic row height" attribute" on the whole row. Code pointers are in comment 22, except that in step 3, the code pointer is probably wrong and should be replaced by what I say in comment 44. Steps 1 and 2 are still valid. Sorry for the mixup. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #48 from kerem --- I sent following new patch for this bug; https://gerrit.libreoffice.org/#/c/21761/1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #47 from kerem --- I sent following patch for this bug; https://gerrit.libreoffice.org/#/c/20751/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #45 from kerem --- (In reply to Lionel Elie Mamane from comment #44) > (In reply to kerem from comment #43) > > In comment 24, reportbuilder creates an odt file, not through Writer. I > > can't this. How to create odt file? > > An ODT file is basically a ZIP structure with XML in it. > > In reportbuilder, the Java top-level class that does the process seems to be > in file > reportbuilder/java/org/libreoffice/report/pentaho/output/text/ > TextRawReportTarget.java > (in combination with the external jfreereport), but that is not where you > will need to intervene, but in the code that creates a table row. > > The code responsible for a cell is basically > reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/ > TableCellLayoutController.java > > My original idea was to find the code responsible for a row and inject the > attribute for "fit to size" row height there. However, now that I take a > fresh look at it, I realise that the tags are probably > copied unchanged from the report definition. So it might be easier to change > the way the report definition is saved rather than the way it is processed. > > The saving of the report definition happens in C++, in > reportdesign/source/filter/xml/ > I think it is particularly in reportdesign/source/filter/xml/xmlExport.cxx > function void ORptExport::exportContainer(const Reference< XSection>& > _xSection) > looks relevant; need to set the right attribute or style for "automatic > height" there. Okey I understand. So I change something in function void ORptExport::exportContainer(const Reference< XSection>&_xSection). I change that about the "automatic height", is true? In addition to, are there any your suggestions? Thank you. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #44 from Lionel Elie Mamane --- (In reply to kerem from comment #43) > In comment 24, reportbuilder creates an odt file, not through Writer. I > can't this. How to create odt file? An ODT file is basically a ZIP structure with XML in it. In reportbuilder, the Java top-level class that does the process seems to be in file reportbuilder/java/org/libreoffice/report/pentaho/output/text/TextRawReportTarget.java (in combination with the external jfreereport), but that is not where you will need to intervene, but in the code that creates a table row. The code responsible for a cell is basically reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/TableCellLayoutController.java My original idea was to find the code responsible for a row and inject the attribute for "fit to size" row height there. However, now that I take a fresh look at it, I realise that the tags are probably copied unchanged from the report definition. So it might be easier to change the way the report definition is saved rather than the way it is processed. The saving of the report definition happens in C++, in reportdesign/source/filter/xml/ I think it is particularly in reportdesign/source/filter/xml/xmlExport.cxx function void ORptExport::exportContainer(const Reference< XSection>& _xSection) looks relevant; need to set the right attribute or style for "automatic height" there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #43 from kerem --- (In reply to Lionel Elie Mamane from comment #42) > (In reply to kerem from comment #41) > > Hello, > > > > I am starting work on this bug. I want ask questions to you. Please can you > > help me? > > > > First of all, I don't know where the start. Also will i work any code > > files? > > > > Thank you for your suggestion. > > Please read particularly comments 22 to 26. Then come back to me with any > question or difficulty you have. In comment 24, reportbuilder creates an odt file, not through Writer. I can't this. How to create odt file? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #42 from Lionel Elie Mamane --- (In reply to kerem from comment #41) > Hello, > > I am starting work on this bug. I want ask questions to you. Please can you > help me? > > First of all, I don't know where the start. Also will i work any code files? > > Thank you for your suggestion. Please read particularly comments 22 to 26. Then come back to me with any question or difficulty you have. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #41 from kerem --- Hello, I am starting work on this bug. I want ask questions to you. Please can you help me? First of all, I don't know where the start. Also will i work any code files? Thank you for your suggestion. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #40 from Lionel Elie Mamane --- (In reply to derrick rocha from comment #39) > Is this still an issue? Thanks. yes -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #39 from derrick rocha --- Is this still an issue? Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 lukas.men...@outlook.de changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|lukas.men...@outlook.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 lukas.men...@outlook.de changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|libreoffice-b...@lists.free |lukas.men...@outlook.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 lukas.men...@outlook.de changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #35 from lukas.men...@outlook.de --- Hello, I want to work at this bug, but I fear I need help :) Please sorry my bad english. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 --- Comment #34 from Lionel Elie Mamane --- (In reply to Zlatko Kostadinow from comment #33) > I was not able to reproduce this bug with the example database and the > source code at commit 5d388443b9809e73202ce551bcffa10d442094ca from 12 Feb > 2015. Is it still up-to-date or it was fixed? This enhancement request is still pending. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.documentfoundation.org/show_bug.cgi?id=45789 Zlatko Kostadinow changed: What|Removed |Added CC||kostadinov.zla...@gmail.com --- Comment #33 from Zlatko Kostadinow --- I was not able to reproduce this bug with the example database and the source code at commit 5d388443b9809e73202ce551bcffa10d442094ca from 12 Feb 2015. Is it still up-to-date or it was fixed? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #32 from Alex Thurgood --- Adding self to CC if not already on -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #31 from Lionel Elie Mamane --- (In reply to Omar Syed from comment #30) > Don't worry guys. I got this I look forward to reviewing your patch ! Let me knwo when it, or a draft of it, is ready. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #30 from Omar Syed --- Don't worry guys. I got this -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 je...@live.de changed: What|Removed |Added Assignee|je...@live.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 je...@live.de changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |je...@live.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #21 from je...@live.de --- Hi, I am trying to work on this Bug but I don't know where to start. Maybe you can help me and tell me in which file I have to look for. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Lionel Elie Mamane changed: What|Removed |Added Assignee|high...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #20 from Lionel Elie Mamane --- No answer from assignee -> marking as available again -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Michal Strnad changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |high...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #13 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Ulf Zibis changed: What|Removed |Added Blocks||50105 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 rob...@familiegrosskopf.de changed: What|Removed |Added CC||ulf.zi...@gmx.de --- Comment #12 from rob...@familiegrosskopf.de 2012-07-31 10:05:51 UTC --- *** Bug 50105 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #11 from Ralph Peters 2012-06-20 07:43:53 PDT --- It would really be nice if this "bug" could be fixed in the report builder! For me, it would convert Report Builder into something usable! Please push this to the top of the list of things that need to be fixed. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #10 from Lionel Elie Mamane 2012-06-18 05:56:26 PDT --- As a temporary work-around, one can use the following macro to open a report and put every row to autoheight: Dim rpt as Object rpt = ThisDatabaseDocument.ReportDocuments.getByName(rptName).open Dim tbls as Object, tbl as Object tbls = rpt.getTextTables() dim j as Integer for j = 0 to tbls.count() - 1 tbl = tbls.getByIndex(j) if Left$(tbl.name, 6) = "Detail" then Dim rows as Object, col as long rows = tbl.Rows dim i as integer For i = 0 to rows.count - 1 dim row as Object row = rows.getByIndex(i) row.IsAutoHeight = True Next i endif next j -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Lionel Elie Mamane changed: What|Removed |Added CC||totoiiie...@gmail.com --- Comment #9 from Lionel Elie Mamane 2012-06-18 05:45:00 PDT --- *** Bug 40229 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 sasha.libreoff...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #8 from sasha.libreoff...@gmail.com 2012-03-21 22:12:39 PDT --- Thanks for additional explanations and examples > FWIW, in MS Access, one can choose this kind of thing per-control (AutoGrow > and > AutoShrink). This allows to do e.g. It makes sense to reuse user's knowledge. If user learned something useful in one program, IMHO it is useful to allow to him/her use it in another program. Now we have enough knowledge about how this should be. Let we see how it will be implemented. Thanks for idea. And thanks in future for implementing. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #7 from Lionel Elie Mamane 2012-03-21 10:39:23 PDT --- (In reply to comment #5) > And now I have another question: what wrong if we do this behaviour as > default. Well, a row (cell) could take far too much space and fuckup the layout (depending on how the layout is done). Whether the "fit to size" thing is desirable depends on the data being shown... FWIW, in MS Access, one can choose this kind of thing per-control (AutoGrow and AutoShrink). This allows to do e.g.: Name Number Data Eleonor 1short data Lionel M 2 short data Ted3 long data, blah, blah word wrap, lorem ispsum doloret ma Pete non dolet. Bruce4 long data, blah, blah word Willis wrap, lorem ispsum doloret ma Pete non dolet. when the name of number one is really "Eleonora Battista Almeire", number 2 "Lionel Mamane" and number 3 just "Ted". As a short prefix of the name is all that one needs to disambiguate between rows, one does not want to waste space (neither horizontal, nor vertical) to show full name, so that the rows take as many lines as the data needs. Short data -> one line even if name is long, and long data -> many rows even if name is short. If many rows anyway, *do* use the extra space for word-wrapping the name. I don't quite see a way to achieve that with LibO, but at least we can put a per-row (instead of per-control) choice, which is already better than the current. So, really, it should be an option. The *default* state of that option could be "enabled", that's up for discussion. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #6 from Lionel Elie Mamane 2012-03-21 10:33:39 PDT --- (In reply to comment #5) > And now I have another question: what wrong if we do this behaviour as > default. Well, a row (cell) could take far too much space and fuckup the layout (depending on how the layout is done). Whether the "fit to size" thing is desirable depends on the data being shown... FWIW, in MS Access, one can choose this kind of thing per-control (AutoGrow and AutoShrink). This allows to do e.g.: Name Number Data Eleonor 1short data Lionel M 2 short data Ted when the name of number one is really "Eleonora Battista Almeire", number 2 "Lionel Mamane" > I see one advantage: user will not have problems with data that accidentally > becomes hidden outside of cell. This may produce data loss when document will > printed. This may increase productivity, because users will have no need to > check this option each time. > > But may be exist disadvantages for make this as default? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #5 from sasha.libreoff...@gmail.com 2012-03-21 09:57:14 PDT --- Thanks for attachments To produce last attachment (3-th) we do: 1. Select table 2. Right click table, select Row->Hight 3. Check box "Fit to size" And now I have another question: what wrong if we do this behaviour as default. I see one advantage: user will not have problems with data that accidentally becomes hidden outside of cell. This may produce data loss when document will printed. This may increase productivity, because users will have no need to check this option each time. But may be exist disadvantages for make this as default? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #4 from Lionel Elie Mamane 2012-03-21 08:06:22 PDT --- Created attachment 58816 --> https://bugs.freedesktop.org/attachment.cgi?id=58816 right result -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Lionel Elie Mamane changed: What|Removed |Added Attachment #58813|application/octet-stream|application/vnd.oasis.opend mime type||ocument.database -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #3 from Lionel Elie Mamane 2012-03-21 08:05:13 PDT --- Created attachment 58814 --> https://bugs.freedesktop.org/attachment.cgi?id=58814 wrong result 2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #2 from Lionel Elie Mamane 2012-03-21 08:04:35 PDT --- Created attachment 58813 --> https://bugs.freedesktop.org/attachment.cgi?id=58813 example database One table (Assets), two rows. One has short text in "comments", the other has long text in comments. With the current system, one can only get two different kinds of "wrong" results: - "wrong result 1" (report in this database document): the short text takes too much space - "wrong result 2" (attached odt file and Assets report in this database document): the long text is cut to fit within one line, as indicated by a red triangle. The result I would like is in attachment "right result". Obtained by editing "wrong result 2", selecting the two data row and selecting optimal row height for those. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #1 from sasha.libreoff...@gmail.com 2012-03-21 07:20:06 UTC --- Thanks for new idea Please, attach small Database document that demonstrates this problem -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 Lionel Elie Mamane changed: What|Removed |Added Status Whiteboard||EasyHack ||DifficultyInteresting ||SkillCpp SkillJava TopicUI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
