[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51249

Aron Budea  changed:

   What|Removed |Added

 Blocks|83946   |139478


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=139478
[Bug 139478] [META] Tracking changes issues in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51249

Pénzes Dávid  changed:

   What|Removed |Added

 Blocks||83946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Bugs for tracking changes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=51249

Eike Rathke er...@redhat.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1

--- Comment #3 from Eike Rathke er...@redhat.com 2012-06-21 09:39:10 PDT ---
Good catch :-)  I could reproduce, and with the patch it seems fixed.
The change track replay modifying the document during save in between is
awkward.. but as things are the patch is a reasonable workaround.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=51249

Eike Rathke er...@redhat.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=51249

--- Comment #1 from Lionel Dricot lio...@lanedo.com 2012-06-20 02:07:31 PDT 
---

What is happening ?

According to our investigation, saving a Calc file is done in two steps:

1. For each table, if the table has not been modified, the previous save of the
Styles of the table is used, else the new Styles are computed.

2. For each table, if the table has not been modified, the previous save of the
Content is used else the new Content is computed.


Whit track-changes enabled, the content is computed by replaying all the
changes.

It seems that, in some case, replying the file to compute the content may be
interpreted as content has changed. But if the table was not modified,
Styles were not computed but instead copied from the last save. This means
that an inconsistency between Styles and Content appear and lead to a crash.


A straightforward solution would be to not allow the direct copy optimisation
when track-change is enabled.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51249] Crash while saving a document with track-changes enabled

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=51249

--- Comment #2 from Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com 
2012-06-20 04:53:16 PDT ---
Created attachment 63261
  -- https://bugs.freedesktop.org/attachment.cgi?id=63261
Patch disallowing usage of stream copy when Changes Record is enabled

 A straightforward solution would be to not allow the direct copy optimisation
 when track-change is enabled.
This is short patch is an implementation of this, and is enough to prevent the
bug.
I'm not sure it's 100% correct though, as I'm not much familiar with this part
of the code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs