[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Urmas changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #20 from Urmas --- *** Bug 53245 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Rainer Bielefeld changed: What|Removed |Added Summary|Writer 3.6 creates and |creates and applies empty, |applies empty automatic |useless automatic styles |styles everywhere, leading | |to needless file complexity | |and size| --- Comment #6 from Rainer Bielefeld 2012-07-15 16:36:03 PDT --- This is a lot of stuff. As a first step I compared the flatxml structure of reporter's test kit, found additional styles. I will do an own test trying to reproduce the results for Test A later. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Roman Eisele changed: What|Removed |Added OS/Version|Mac OS X (All) |All --- Comment #7 from Roman Eisele 2012-07-18 18:38:12 PDT --- I have tried myself if I can reproduce the problem on Windows. And indeed, both test A and B give me the same results as on MacOS X (tested with LibreOffice 3.6.0.1, Build-ID: 73f9fb6, German UI, on Windows XP Professional 5.1.2600, Service Pack 3). Only test C fails on WinXP -- but not because LibreOffice would not insert useless ... tags whenever I insert or append any text (this is true on Windows just like on MacOS X), but only because text is obviously rendered differently on Windows, so that kerning works even over a or tag. To state it clearly: on MacOS X, 'A' and 'T' in AT and AT don't get kerned, but on Windows, they get kerned (given the fact that the current font actually contains a kerning pair for 'A' + 'T', of course, and that "Pair kerning" is enabled in LibreOffice for that text). I wonder how kerning is handled in this situation on Linux ... According to these results, I change the Platform picker from 'MacOS X' to 'All'. However, I know that I can not (and do not want to) confirm my bug report myself, so we still need someone else who can confirm my results ;-) And then we need someone who fixes this bug soon ... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #8 from Rainer Bielefeld 2012-07-20 11:06:53 UTC --- I tried to reproduce "A", but NOT reproducible with Server Installation of "LibreOffice 3.6.0.2 rc German UI/Locale [Build-ID: 815c576] on German WIN7 Home Premium (64bit) @Roman: If you still reproduce with 3.6.0.2, I would do some additional chin-ups for y confirmation. For that may be we should meat on skype with screensharing. May be there is a very little difference in our proceedings what causes the difference?! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #9 from Rainer Bielefeld 2012-07-20 11:28:18 PDT --- Created attachment 64427 --> https://bugs.freedesktop.org/attachment.cgi?id=64427 Compares XML When I open both resulting .fodt, the one from 3.6.0 has 731 Words / 23025 Characters, 355 document 708 / 22129 Both documents have only 1 "office:automatic-styles" area. Comparing xml of both documents shows some differences, but I can't see reporter's problem. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Rainer Bielefeld changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #10 from Rainer Bielefeld 2012-07-20 12:20:51 PDT --- My mistake, searched for wrong xml statments. I can confirm "https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #11 from Rainer Bielefeld 2012-07-20 12:24:23 PDT --- @ Roman Eisele Did you already check whether (and if yes were) the problem appears in .odt? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #12 from Roman Eisele 2012-07-20 17:24:01 PDT --- Created attachment 64456 --> https://bugs.freedesktop.org/attachment.cgi?id=64456 Test A, LibO 3.6.0b3 .odt file, viewed with BBEdit, problematic sections emphasized (In reply to comment #8) > @Roman: If you still reproduce with 3.6.0.2 [...] I have checked with 3.6.0.1 -- still reproducible; I will check with 3.6.0.2 later this evening and report results (no free time earlier, sorry). (In reply to comment #11) > Did you already check whether (and if yes were) the problem appears in .odt? Yes, I did -- the problem also appears in the .odt files, exactly like in the .fodt files, the only difference is the location (due to the different file structure). It is in the "contents.xml" file inside of the .odt file/archive. To view "contents.xml", you can either un-zip the .odt file and then open the "contents.xml" file, or you can view the .odt file with some editor that can browse .odt files directly -- e.g., BBEdit (MacOS only, I don’t know about Windows editors, sorry). In "contents.xml", please search for the section ... or, if it is empty, like in my 3.5.5.3 sample files, just for ! Here are all the useless automatic styles. Additionaly, please look out for the first section of type ; here all these automatic styles get applied. Attached you find a screenshot of my LibO 3.6.0 beta 2 sample .odt file opened with BBEdit; I hope the screenshot shows better where to find the problem than my lengthy explanation ;-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #13 from Roman Eisele 2012-07-20 17:25:02 PDT --- Created attachment 64457 --> https://bugs.freedesktop.org/attachment.cgi?id=64457 Test A, LibO 3.5.3.3 .odt file, viewed with BBEdit, interesting (correct) sections emphasized -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #14 from Roman Eisele 2012-07-20 17:28:30 PDT --- (In reply to comment #12) > It is in the "contents.xml" file inside of the .odt file/archive. Sorry, typo -- the sub-file is named "content.xml", not "contents.xml", without the "s". The screenshots show it correctly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #15 from Roman Eisele 2012-07-20 19:15:12 PDT --- (In reply to comment #8) > @Roman: If you still reproduce with 3.6.0.2 [...] Still reproducible with LibreOffice 3.6.0.2 (Build ID: 815c576), German langpack installed, on MacOS X 10.6.8 German. Nothing has changed, my results are exactly the same as with LibreOffice 3.6 beta 3 (see original description and sample files). I have deleted my LibO user profile completely before doing the test, so no influence of corrupted settings etc. is possible. (In reply to comment #10) > I can confirm " 3.5.5 and existing in fodt from 3.6.0.0beta3 [...] > Now, of course, I also find this in "Compares XML" PDF document (Page 8) @Rainer: Thank you very much for your persistent testing! I know the issue is complicated, so I am really happy about that you can reproduce it now, at least case A. I hope (or fear) that you also can reproduce case B ... which shows the real dimension of the problem: every time one inserts or appends any text, Writer will also insert an annyoing -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #16 from Roman Eisele 2012-07-21 09:53:47 PDT --- I can't bibisect this problem because I'm not on Linux. But I have tested various older master builds for MacOS X which I have still on my HD, and the issue is already in the oldest LOdev version I can find: LOdev 3.6.0alpha0+, Build ID: 11e9ba6; Date: 2012-05-22; Installation file: master~2012-05-22_05.53.03_LibO-Dev_3.6.0alpha0_MacOS_x86_install_en-US.dmg The regression must be even older. So if someone could *please* bibisect this issue, he/she can probably start with this version/date and then go back. * No suprise: The issue is also in the current master branch. I can reproduce it with identical results in LOdev 3.7.0.0.alpha0+, Build ID: 042686d; Date: 2012-07-19; installation file: master~2012-07-19_10.04.11_LibO-Dev_3.7.0.0.alpha0_MacOS_x86_install_en-US.dmg -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #17 from Michael Stahl 2012-08-22 18:30:20 UTC --- so now i've finally had some time to read the lengthy description here :) and it's immediately obvious that the cause is: commit 062eaeffe7cb986255063bb9b0a5f3fb3fc8e34c sw: Improved document comparison based on RSIDs. so i think this is actually a feature, the "rsid" attributes are added to styles so the "document compare" feature gives better results. to what extent are the added spans an actual problem? while it is nice to illustrate the problem, i'd say no actual user writes a bunch of s into a document, saves it, loads it again and intersperses that with Ts. you can configure this via Tools->Options->Writer->Comparison, but it seems that only has an effect on the actual comparison, i.e. unchecked "Use RSID" will still cause them to be generated, they're just ignored when you compare documents. only thing odd to me is that in the simplest case we get a paragraph and inside that a span covering the entire content, both with the same rsid value, but different attributes (one a paragraph-rsid); i'm not familiar with how these things actually work to tell whether that is necessary. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Roman Eisele changed: What|Removed |Added Blocks|6 | --- Comment #18 from Roman Eisele 2012-08-24 14:55:19 UTC --- (In reply to comment #17) > so i think this is actually a feature, the "rsid" attributes are added > to styles so the "document compare" feature gives better results. @Michael Stahl: Thank you very much for looking into this issue! So we now have a much better understanding of what's going on. Nevertheless, I am still not sure if there isn't something wrong with this feature, or, to say it even more polite, something which needs to get improved about this feature. Therefore I ask you (and everybody else) not to close this bug yet. To tell exactly what IMHO is wrong about the state of affairs, I will think some days about it, experiment a bit with this feature, and will then give you an updated and clear and, if possible, not so lengthy description ;-) For now, I remove this bug from the MAB list, and ask you for some patience. Thank you in advance. * If somebody is curious, two hints just to make clear why I think that the state of affairs is not perfect: (In reply to comment #17) > while it is nice to illustrate the problem, i'd say no actual user writes > a bunch of s into a document, saves it, loads it again and > intersperses that with Ts. Right ;-) But the same problem also occurs in everyday editing situations, if you just insert or alter a single character somewhere. At least on MacOS X, additional spans disable character kerning, and therefore this feature will cause the text to appear visually inconsistent and with aesthetic defects. -> For this I will provide some simple samples with real-life background. > you can configure this via Tools->Options->Writer->Comparison, > but it seems that only has an effect on the actual comparison, > i.e. unchecked "Use RSID" will still cause them to be generated, > they're just ignored when you compare documents. Would it be possible to expand this option so that it completely disables the generation of RSID spans if unchecked? This is all what would be required to make everybody happy ... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #19 from George Nassar 2012-08-27 17:04:22 UTC --- (In reply to comment #18) > > you can configure this via Tools->Options->Writer->Comparison, > > but it seems that only has an effect on the actual comparison, > > i.e. unchecked "Use RSID" will still cause them to be generated, > > they're just ignored when you compare documents. > > Would it be possible to expand this option so that it completely disables the > generation of RSID spans if unchecked? This is all what would be required to > make everybody happy ... Makes sense from the UI perspective, too -- that's what I'd think that option would use. Perhaps a temporary workaround would be to be able to scrub RSID spans from a document. Not my idea, really; I cribbed it from http://blogs.msdn.com/b/ericwhite/archive/2008/11/04/remove-rsid-attributes-and-elements-before-comparing-documents.aspx who does it for Open XML documents, figuring the idea may be applicable. Come to think, I'm not sure the two are necessarily mutually exclusive options. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 --- Comment #21 from László Németh --- This “empty” segmentation combined with a hidden Graphite layout problem raised annoying text changes/editing problems, see Bug 53245. Now it results only missing Graphite ligatures. Note: there are other types of missing kerning, for example, at boundaries of different colors/background or the kerning before the hyphen marks in automatic hyphenation, but this is an ugly, underhand regression. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Joel Madero changed: What|Removed |Added Whiteboard||bibisectrequest CC||jmadero@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Michael Stahl changed: What|Removed |Added Whiteboard|bibisectrequest | --- Comment #22 from Michael Stahl --- remove "bibisectrequest", comment #17 already contains the commit -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] creates and applies empty, useless automatic styles
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Commit Notification changed: What|Removed |Added Whiteboard||target:4.2.0 --- Comment #23 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6db39dbd7378351f6476f6db25eb7110c9cfb291 fdo#52028: sw: let text formatting ignore RSID in automatic styles The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
