[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108441


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108441
[Bug 108441] [META] Database table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

jan iversen  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #16 from jan iversen  ---
My bad, overlooked comment 7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

--- Comment #15 from Lionel Elie Mamane  ---
(In reply to jan iversen from comment #14)
> Missing code pointer, which is mandatory for easy hacks.

You that comment 7 is not precise enough?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

jan iversen  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #14 from jan iversen  ---
Missing code pointer, which is mandatory for easy hacks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

Nielens Tim  changed:

   What|Removed |Added

   Assignee|tim.niel...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56676

Nielens Tim tim.niel...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |tim.niel...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

--- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk ---
Adding self to CC if not already on

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #8 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

--- Comment #3 from rob...@familiegrosskopf.de ---
(In reply to comment #1)
 Could you attach any example files to allow others to check on different
 system/build?

Any further questions? Could you reproduce - so please set Status to New. If
you couldn't reproduce set Status to Unconfirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk ---
Confirming, enclosed a screenshot of the Form Properties of your ODB file in LO
:

Version 4.0.3.3 (Build ID: 0eaa50a932c8f2199a615e1eb30f7ac74279539)


Where it can be clearly seen that the Form is supposed to allow Additions,
Modifications, and Deletions, which is clearly wrong because the Calc file can
not actually be written to when the Form is opened for normal use.


Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

--- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk ---
I have no idea whether LO in its form handling code is actually supposed to be
able to tell the difference between a r/o datasource and a r/w datasource. If
nothing is there already, this would turn into a request for enhancement.

Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

--- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk ---
Created attachment 82384
  -- https://bugs.freedesktop.org/attachment.cgi?id=82384action=edit
form properties for attached calc based database

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Whiteboard||EasyHack
   ||DifficultyInteresting
   ||SkillCpp SkillSQL TopicUI
   Severity|normal  |enhancement
   Priority|medium  |low

--- Comment #7 from Lionel Elie Mamane lio...@mamane.lu ---
I'm of two minds on this... I always understood these properties as should the
form impose these restrictions or not. Setting them to Yes does not
guarantee that these actions will work out in the end: the Database may not
allow them because the user does not have the required permissions, LibreOffice
may not be able to carry them out (e.g. because no primary key), ...

To me, it makes sense to keep these settings as such, orthogonal from the
issues that may keep these actions from succeeding in practice. Frim this POV,
this is not a bug.

OTOH, I kinda understand from a beginner-friendly POV that allowing the user to
set a non-meaningful setting that will have no effect in practice is only
confusing. From this POV, this is a valid enhancement request.

Oh well, if anyone feels like preparing a patch... let's see.

The code that decides whether a given propery is enabled or not is in file
extensions/source/propctrlr/formcomponenthandler.cxx; look for
_rxInspectorUI-enablePropertyUI calls. You'll need to add a case in
FormComponentPropertyHandler::actuatingPropertyChanged for everything that may
change the decision whether to enable or not, and there add
PROPERTY_ALLOWADDITIONS, DELETIONS and EDITS to aDependentProperties.

Then add a case to
FormComponentPropertyHandler::impl_updateDependentProperty_nothrow
for PROPERTY_ALLOWADDITIONS, DELETIONS and EDITS to make the actual decision to
enable or disable. For that, I think you just have to read out the underlying
RecordSet's Privileges property and test whether it includes
com::sun::star::sdbcx::Privilege::DELETE/INSERT/UPDATE

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

bfoman bfo.bugm...@spamgourmet.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||bfo.bugm...@spamgourmet.com
 Ever confirmed|0   |1

--- Comment #1 from bfoman bfo.bugm...@spamgourmet.com ---
Could you attach any example files to allow others to check on different
system/build?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

--- Comment #2 from rob...@familiegrosskopf.de ---
Created attachment 79257
  -- https://bugs.freedesktop.org/attachment.cgi?id=79257action=edit
Calc-document, base-file (must be connected, two screenshots)

Open the base-file. 
Connect the database to the calc-file (Edit → Database → Properties).
Open the form for editing (right click of the mouse → Edit).
Open the form-properties (right click of the mouse on a control → Form).
See Data - the properties show the Calc-Sheet with the properties 
Allow Additions - Yes 
Allow Modifications - Yes 
Allow Deletions - Yes 
Add Data only - No
All this fields must be disabled when connecting to a database, which couldn't
be edited.
Notice, that the wizards shows the same. So users might think: Editing of a
table is impossible - but with a form it is possible in LO. Why doesn't this
work here with my database?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56676] EDITING: Tables in databases based on calc are unwriteable - Form Properties show them as writable

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=56676

rob...@familiegrosskopf.de changed:

   What|Removed |Added

  Attachment #69432|text/plain  |application/vnd.oasis.opend
  mime type||ocument.graphics

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs