[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible
https://bugs.freedesktop.org/show_bug.cgi?id=57929 Laurent BP changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr |desktop.org | CC||jumbo4...@yahoo.fr --- Comment #8 from Laurent BP --- Proposed solution: - retrieve external information during parse - if it is an external ref, as I don't know how to retrieved an ScDocument pointer on external document, I bypass all information about file name and tab name and toggle only the row/column reference It seems to work in all test case I used. Please note that tab is always considered as absolute in an external reference, because there is no way to check the other tabs of the external document. Under review as commit: https://gerrit.libreoffice.org/11218 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible
https://bugs.freedesktop.org/show_bug.cgi?id=57929 --- Comment #7 from Eike Rathke --- Hey Dan, that's a good start :-) Now that you see that ScAddress::Parse() bails out because pExtInfo is NULL, wouldn't it be worth a try to pass a valid ExternalInfo* to Parse()? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible
https://bugs.freedesktop.org/show_bug.cgi?id=57929 --- Comment #6 from Dan --- Thanks to Eike Rathke I was able to start debugging this and found that the line >266: sal_uInt16 nResult = aAddr.Parse(aExpr, mpDoc, aDetails); returns 0 for nResult when external references are used. This causes the if() statement to evaluate to false and so the reference is never toggled. Tracing it into the "Parse()" function in address.cxx, it seems to get set at >1197: if (!pExtInfo) >1198: nRes = 0; Unfortunately, I'm not sure how the "Parse()" function is supposed to be called (I can't find any documentation or comments in the code to explain its purpose), so I can't work out if this is a bug in the ScRefFinder::ToggleRel portion of the code, or the ScAddress::Parse function. The value of aExpr that I'm getting when I debug this (at line 262 in reffind.cxx) is: >(gdb) print aExpr >$1 = "'file:///home/dan/Documents/ReferenceTo.ods'#$Sheet1.A1" which looks like a valid reference to my inexperienced eyes. Can anyone give a n00b a pointer in the right direction? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible
https://bugs.freedesktop.org/show_bug.cgi?id=57929 Eike Rathke changed: What|Removed |Added Whiteboard|ProposedEasyHack|EasyHack DifficultyBeginner ||SkillCpp CC||er...@redhat.com --- Comment #5 from Eike Rathke --- EasyHack code pointer: look into sc/source/core/tool/reffind.cxx ScRefFinder::ToggleRel() -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible
https://bugs.freedesktop.org/show_bug.cgi?id=57929 Eike Rathke changed: What|Removed |Added Summary|Switching between absolute |Switching between absolute |& relative external |& relative external |references not possible |references not possible |(regression)| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=57929 Joel Madero changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard||ProposedEasyHack CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #4 from Joel Madero --- If you manually type in it works fine - so it's just the shortcut that's doing some weird stuff. Confirmed Ubuntu 13.10 GNOME LibreOffice 4.3 build a few days ago New Minor - doesn't prevent high quality work but can slow it down (as I said you can manually type in the $ signs and it works) Low - likely not affecting many users, complex sheets referencing other files could be a headache but that's the minority of users. Possibly: ProposedEasyHack as it seems like just the shortcut is borked -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=57929 Joel Madero changed: What|Removed |Added Severity|normal |minor Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=57929 --- Comment #3 from Gerry --- Just as an update on this issue (of course, it is not a proof that it worked int he past): The Handbook on Calc 3.4 (https://wiki.documentfoundation.org/images/b/b7/CG34-CalcGuideLO.pdf): "To change references in formulas highlight the cell and press Shift-F4 to cycle through the four different types of references. This is of limited value in more complicated formulas; it is usually quicker to edit the formula by hand." --> they do not mention that is does not work for external references. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=57929 --- Comment #2 from Gerry --- Hi Markus, I remember that I have used it in older versions. I cannot pinpoint it to one particlar version. Here in the forum (last comment) there is some indication with regards to the "change": http://forum.ubuntuusers.de/topic/openoffice-org-calc-absolute-betraege-mit-f4-/#post-1742737 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57929] Switching between absolute & relative external references not possible (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=57929 --- Comment #1 from Markus Mohrhard --- Can you name a version where this worked? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
