[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.3.0   |target:5.2.0 target:5.3.0
   |target:6.0.0|target:6.0.0 target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #77 from Commit Notification 
 ---
ekuiitr committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a68f46e8e931c3d4b095a9394d6c050ac9c49d2

tdf#57950 replaced some O(U)StringBuffer::append() with operator+

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Muhammet Kara  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2689

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Muhammet Kara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #76 from Muhammet Kara  ---
(In reply to Xisco Faulí from comment #75)
> Dear Muhammet Kara,
> This bug has been in RESOLVED FIXED status for more than 6 months.
> Do you think it would make more sense to create a follow-up bug instead ?
> From my point of view, it would be much clearer for newcomers to copy the
> info from the description, the comment 74 in the new bug and mention a
> couple of commits. Anyway, up to you...
> Regards

Thanks for your suggestion! I was also thinking the same way, but wasn't sure
about it. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #75 from Xisco Faulí  ---
Dear Muhammet Kara,
This bug has been in RESOLVED FIXED status for more than 6 months.
Do you think it would make more sense to create a follow-up bug instead ? From
my point of view, it would be much clearer for newcomers to copy the info from
the description, the comment 74 in the new bug and mention a couple of commits.
Anyway, up to you...
Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Muhammet Kara  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #74 from Muhammet Kara  ---
There are still instances of chained OUStringBuffer::append(), which could be
replaced with operator+.

You may see the commit 7810858ee6cac233ce5868de1f2ef5de1d443af4 as an example:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7810858ee6cac233ce5868de1f2ef5de1d443af4

And you may check these files for some possible instances:
pyuno/source/module/pyuno_module.cxx
extensions/source/config/ldap/ldapaccess.cxx
extensions/source/propctrlr/selectlabeldialog.cxx
starmath/source/dialog.cxx
starmath/source/rtfexport.cxx
filter/source/graphicfilter/ipict/shape.cxx
ucb/source/ucp/ftp/ftpurl.cxx
ucb/source/core/provprox.cxx
desktop/source/deployment/registry/component/dp_component.cxx
svtools/source/misc/transfer.cxx
svtools/source/svhtml/htmlout.cxx
vcl/source/uitest/uiobject.cxx
vcl/source/window/mnemonic.cxx
vcl/unx/generic/fontmanager/fontconfig.cxx
cui/source/options/certpath.cxx
cui/source/options/optgdlg.cxx
cui/source/options/optlingu.cxx
unotools/source/config/configpaths.cxx
unotools/source/config/bootstrap.cxx
sax/source/tools/converter.cxx
connectivity/source/commontools/sqlerror.cxx
connectivity/source/drivers/firebird/Util.cxx
idlc/source/options.cxx
sc/source/ui/dbgui/foptmgr.cxx
sc/source/ui/condformat/condformathelper.cxx
sc/source/ui/condformat/condformatmgr.cxx
sc/source/ui/vba/vbahyperlink.cxx
sc/source/ui/view/tabview.cxx
sc/source/ui/view/cellsh1.cxx
sc/source/ui/view/editsh.cxx
sc/source/filter/html/htmlexp2.cxx
sc/source/filter/html/htmlexp.cxx
sc/source/filter/dif/difimp.cxx
sc/source/filter/oox/querytablebuffer.cxx
sc/source/filter/oox/worksheethelper.cxx
sc/source/filter/oox/formulabase.cxx
sc/source/filter/oox/drawingfragment.cxx
sc/source/filter/oox/autofilterbuffer.cxx
sc/source/filter/excel/xipivot.cxx
sc/source/filter/excel/xehelper.cxx
sc/source/filter/excel/xiescher.cxx
sc/source/core/tool/compiler.cxx
sc/source/core/tool/address.cxx
sc/source/core/tool/chgtrack.cxx
sc/source/core/data/postit.cxx
sc/source/core/data/validat.cxx
sc/qa/unit/subsequent_filters-test.cxx
sc/qa/unit/helper/qahelper.cxx
sal/test/testbootstrap.cxx
xmlhelp/source/cxxhelp/provider/databases.cxx
sw/source/ui/config/mailconfigpage.cxx
sw/source/ui/vba/vbarow.cxx
sw/source/ui/vba/vbacolumn.cxx
sw/source/filter/html/htmltabw.cxx
sw/source/filter/html/htmlflywriter.cxx
sw/source/filter/html/htmlftn.cxx
sw/source/filter/html/swhtml.cxx
sw/source/filter/html/htmldrawwriter.cxx
sw/source/filter/html/htmlplug.cxx
sw/source/filter/html/wrthtml.cxx
sw/source/filter/html/htmlfldw.cxx
sw/source/filter/html/htmlbas.cxx
sw/source/filter/ww8/docxsdrexport.cxx
sw/source/filter/ww8/rtfsdrexport.cxx
sw/source/filter/ww8/docxattributeoutput.cxx
sw/source/filter/ww8/wrtw8esh.cxx
sw/source/filter/ww8/rtfattributeoutput.cxx
sw/source/filter/ww8/rtfexport.cxx
sw/source/uibase/dbui/dbmgr.cxx
sw/source/uibase/docvw/edtwin.cxx
sw/source/uibase/docvw/edtwin2.cxx
sw/source/uibase/ribbar/inputwin.cxx
sw/source/core/doc/docbm.cxx
sw/source/core/crsr/bookmrk.cxx
sw/qa/core/layout-test.cxx
sw/qa/core/macros-test.cxx
basic/source/runtime/methods.cxx
sfx2/source/dialog/versdlg.cxx
sfx2/source/appl/childwin.cxx
sfx2/source/appl/newhelp.cxx
sfx2/source/appl/appuno.cxx
sfx2/source/appl/macroloader.cxx
sfx2/source/bastyp/frmhtmlw.cxx
oox/source/vml/vmlinputstream.cxx
oox/source/vml/vmlformatting.cxx
oox/source/ole/vbamodule.cxx
oox/source/export/vmlexport.cxx
oox/source/core/xmlfilterbase.cxx
oox/source/dump/dumperbase.cxx
oox/source/drawingml/chart/objectformatter.cxx
oox/source/drawingml/chart/titlecontext.cxx
oox/source/drawingml/lineproperties.cxx
i18npool/source/collator/collator_unicode.cxx
i18npool/source/breakiterator/breakiteratorImpl.cxx
i18npool/source/breakiterator/xdictionary.cxx
i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
i18npool/source/localedata/localedata.cxx
sdext/source/pdfimport/tree/genericelements.cxx
workdir/UnpackedTarball/hunspell/src/tools/hunspell.cxx
workdir/UnpackedTarball/icu/source/test/perf/DateFmtPerf/DateFmtPerf.h
workdir/UnpackedTarball/icu/source/common/unicode/localpointer.h
workdir/UnpackedTarball/firebird/src/dsql/DdlNodes.h
workdir/UnpackedTarball/firebird/src/common/StatusArg.h
sd/source/ui/remotecontrol/Listener.cxx
sd/source/core/drawdoc3.cxx
sd/source/core/sdpage2.cxx
sd/source/core/sdpage.cxx
editeng/source/misc/svxacorr.cxx
xmloff/source/forms/elementimport.cxx
xmloff/source/forms/layerimport.cxx
svl/source/misc/urihelper.cxx
svl/source/numbers/zforlist.cxx

-- 
You are receiving this mail because:
You are the assignee for the 

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #73 from Commit Notification 
 ---
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7810858ee6cac233ce5868de1f2ef5de1d443af4

tdf#57950: Replace chained OUStringBuffer::append() with operator+

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.3.0   |target:5.2.0 target:5.3.0
   ||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0|target:5.2.0 target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #72 from Commit Notification 
 ---
Arnold Dumas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=68900bad945c847f62a614cd2c2653ef3a9827ca

tdf#57950: Replace chained OUStringBuffer::append() with operator+

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

jan iversen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard|ToBeReviewed target:5.2.0   |target:5.2.0

--- Comment #71 from jan iversen  ---
There are several patches here, it seems that there are not more work to be
done. If there are more work, please add a description, with a relevant code
pointer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #70 from Commit Notification 
 ---
Steven Guo committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=74c93c91ebce735e0defacc30054ca809c2db02d

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #69 from Commit Notification 
 ---
Sedat Ak committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f0c38c67e4a5d1b1fa58873f2db88310d8bf295a

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #68 from Commit Notification 
 ---
irem committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bb148e74495b02f65483bd460cab762114177ea

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #67 from Commit Notification 
 ---
melikeyurtoglu committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e2de428a4910bb3c6dda45a59da09ed4a1889db

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|ToBeReviewed target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #65 from Commit Notification 
 ---
Arnold Dumas committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=53bf3ea58e0f4f9f4399a44bfc9ddecc71cb54c7

tdf#57950: Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

jan iversen  changed:

   What|Removed |Added

 Whiteboard|target:4.1.0 target:4.2.0   |ToBeReviewed
   |target:4.3.0 target:4.5.0   |
   |target:5.1.0 target:5.2.0   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack SkillCpp   |EasyHack SkillCpp
   |TopicCleanup|TopicCleanup
   |DifficultyBeginner  |DifficultyBeginner
   |target:4.1.0 target:4.2.0   |target:4.1.0 target:4.2.0
   |target:4.3.0 target:4.5.0   |target:4.3.0 target:4.5.0
   |target:5.1.0|target:5.1.0 target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #63 from Commit Notification 
 ---
Sedat Ak committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1c8e67a9d163e72916d33b5d16211965c9655e23

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #61 from Commit Notification 
 ---
Sedat Ak committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bfc9619fccd17c5059949afc06953695222dea3b

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #62 from Commit Notification 
 ---
Sedat Ak committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c4b71b0885122b67e05ed4aed89b0d12ce0f34c8

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #60 from Commit Notification 
 ---
Aybuke Ozdemir committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbfc031333aa74fbd4c6362c33405c49c22283f3

tdf#57950 Replace chained O(U)StringBuffer::append() with operator+

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack SkillCpp   |EasyHack SkillCpp
   |TopicCleanup|TopicCleanup
   |DifficultyBeginner  |DifficultyBeginner
   |target:4.1.0 target:4.2.0   |target:4.1.0 target:4.2.0
   |target:4.3.0 target:4.5.0   |target:4.3.0 target:4.5.0
   ||target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #57 from aybuke  ---
I sent following patch for this bug:
http://ci.libreoffice.org/job/lo_gerrit_master/7121/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #58 from aybuke  ---
I sent following patch for this bug:

https://gerrit.libreoffice.org/#/c/19027/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #59 from aybuke  ---
(In reply to aybuke from comment #58)
> I sent following patch for this bug:
> 
> https://gerrit.libreoffice.org/#/c/19027/

I sent accidentally recent reviews. I'm so sorry. 
I want to send the link patch:
https://gerrit.libreoffice.org/#/c/19225/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #56 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Krisztian Pinter committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f863d2602fca7d180f49cc4b6fb1bdba57e6a012

fdo#57950 Replace chained append() with operator+

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #55 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Austin Chen committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fb66458c08b9c0ce59bca85e77d26fad8b59e4b

tdf#57950: Replace chained O(U)StringBuffer::append() with operator+

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Austin Chen austinchen...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |austinchen...@gmail.com
   |desktop.org |

--- Comment #53 from Austin Chen austinchen...@gmail.com ---
Updated from verbose OUStringBuffer in formulabase.cxx and chartconverter.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

Tor Lillqvist t...@iki.fi changed:

   What|Removed |Added

   Assignee|austinche...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #54 from Tor Lillqvist t...@iki.fi ---
Austin: please don't assign to yourself. just submit changes to gerrit. you
must have very bad luck if two people happen to want to change the same lines
at the same time

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

mridul mridulgup...@gmail.com changed:

   What|Removed |Added

   Assignee|mridulgup...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57950

--- Comment #52 from mridul mridulgup...@gmail.com ---
hey,
i would like to contribute to this. can you please suggest me some files where
i can find this type of code?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Gehad ElRobey gehadelro...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gehadelro...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #28 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Marcos Paulo de Souza committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=75e6856b081ca29e3e0f19493780d9f8fa6d315c

fdo#57950: Remove chained appends in codemaker



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Thomas Arnhold tho...@arnhold.org changed:

   What|Removed |Added

  Attachment #71735|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Janit Anjaria janit_...@hotmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |janit_...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

   Assignee|janit_...@hotmail.com   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

   Assignee|janit_...@hotmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #24 from Lubos Lunak l.lu...@suse.cz ---
Please do not reassign this bugreport, multiple developers can work on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Janit Anjaria janit_...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |janit_...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Christos Strubulis strubu...@gmail.com changed:

   What|Removed |Added

  Attachment #71454|0   |1
is obsolete||

--- Comment #8 from Christos Strubulis strubu...@gmail.com ---
Created attachment 71735
  -- https://bugs.freedesktop.org/attachment.cgi?id=71735action=edit
Second proposed patch

Hi,
ok thanks for the detailed review and help.
Is it better now? What is your opinion?

(Ok, but I am almost sure you know that concatenation of strings can be made
like
this in java).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #9 from Lubos Lunak l.lu...@suse.cz ---
ww8graf.cxx: As pointed out by comment #2, the argument to OUStringBuffer
should  not be dropped, unless it is the default size (so the example given by
me in the initial description was indeed wrong in this case, I overlooked the
msSeed). As that was just a minor detail, I'll fix that and push your patch,
thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #5 from Christos Strubulis strubu...@gmail.com ---
Created attachment 71454
  -- https://bugs.freedesktop.org/attachment.cgi?id=71454action=edit
Indicative proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #6 from Christos Strubulis strubu...@gmail.com ---
Hi,
I attach an indicative proposed patch.

It seems that in the code there is some usage of sal_Unicode and appendAscii. 

In the first case, the + operator can't be used (or it can be used and it's
only me with an error?). 
In the second case,  I changed only one file (RDFaExportHelper.cxx) assuming
that instead of appendAscii, append can be used. 

I am not sure when append (and not appendAscii) should be used, but I saw a
recent commit with that replacement:
https://gerrit.libreoffice.org/#/c/854/2/basctl/source/basicide/bastype2.cxx

If the patch is right I can send an email to the list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #7 from Stephan Bergmann sberg...@redhat.com ---
ActivityChooserModel.java:  The changes discussed here only work in C++ code,
not in Java code.

bastype3.cxx:  You can simplify this even further by dropping the useless
OUStringBuffer.  Either make aName an OUString (and drop the makeSkingAndClear
call from the return statement), or just build the string directly in the
return statement.

bastype.cxx, javatype.cxx:  Same as above.

dbfld.cxx:  Some of the (performance) benefits are lost when you split the
concatenation into multiple operator+= (instead of operator+) expressions. 
(Also, please take care to not indent with tabs.  Tab widths are not universal,
which makes the code easily look oddly indented.  Your editor might be able to
help you with avoiding tabs.)

docexport.cxx and ww8graf.cxx look great already.

RDFaExportHelper.cxx:  s_prefix is defined as static const char s_prefix[] =
_:b at the top of that file, but only used here.  I would thus remove the
definition of s_prefix and directly use the _:b string literal here -- which
also makes it obvious that it is OK to drop the call of appendAscii, which in
general is only OK if the argument to appendAscii was a string literal, not an
arbitrary expression of pointer type.  (Also see the tabs-vs.-spaces note
above.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Christos strubu...@gmail.com changed:

   What|Removed |Added

 CC||strubu...@gmail.com

--- Comment #3 from Christos strubu...@gmail.com ---
Hi,

At first, I would like to start replacing the first one, i.e.,

rtl::OUString aFileName =
rtl::OUStringBuffer().append(charts/chart).append(nCount).append(.xml).makeStringAndClear();

Should I start?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

--- Comment #4 from Lubos Lunak l.lu...@suse.cz ---
Sure, just go ahead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Stephan Bergmann sberg...@redhat.com changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #2 from Stephan Bergmann sberg...@redhat.com ---
(In reply to comment #0)

In

 rtl::OUStringBuffer aName(msSeed);
 aName.append(++mnImportedGraphicsCount);
 aName.append(: );
 aName.append(rFixed);
 pFrmFmt-SetName(aName.makeStringAndClear());

to

 pFrmFmt-SetName(OUString::valueOf(++mnImportedGraphicsCount) + :  +
 rFixed);

note that an initial msSeed + is missing from the converted, unless msSeed is
an integer, in which case it would have preset the capacity of the
OUStringBuffer to something other than the default 16.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 Whiteboard|EasyHack,SkillCpp,TopicClea |EasyHack,SkillCpp,TopicClea
   |nup |nup,DifficultyBeginner

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57950] Replace chained O(U)StringBuffer::append() with operator+

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=57950

Lubos Lunak l.lu...@suse.cz changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Whiteboard||EasyHack,SkillCpp,TopicClea
   ||nup
 Ever confirmed|0   |1

--- Comment #1 from Lubos Lunak l.lu...@suse.cz ---
Note that the removal of rtl:: is not directly related to this EasyHack, but
as writing that is not necessary anymore, it can be removed in the process in
order to further make the code cleaner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs