[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Kohei Yoshida changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |kohei.yosh...@suse.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #14 from Kohei Yoshida --- Unless there is objection, here is what I'm going to do. When saving, I'll check if the directory path changes before and after the save, and if it does, I'll mark those sheets that have a hyperlink dirty, in order to prevent their stream caches from being used on save. As we discover other elements that depend on the full path of the host document, we will add more checks in the same routine. This will slightly increase the cost of the file save, but hopefully not too much. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #13 from Kohei Yoshida --- Alternatively, we could just disable stream cache only when the host document is saved into different directory. We could also do additional check and disable stream cache only when the sheet contains hyperlinks (or anything else that might depend on the full path of the host document), but that would require going through all cells in each sheet, which is a big overhead especially for large documents. I'm not sure if it's worth it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #12 from Kohei Yoshida --- (In reply to comment #11) > Note, my proposal will not remove this optimization. It will just disable > it for "Save As" operation. Let's ask ourselves, how many times do you > expect the users to "save as" a document as opposed to just "save"? It will be conceptually equivalent of saving a new document. We don't use this optimization when saving a new document, and IMO we shouldn't do it when saving an existing document as a different document either. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #11 from Kohei Yoshida --- (In reply to comment #10) > On the other hand the cached stream is a big speed-up for export. Our export > is already quite slow so we might want to keep this optimization. > > That does not mean that I'm generally in favor of this optimization just > that we need to think about the performance impact of such a change. Note, my proposal will not remove this optimization. It will just disable it for "Save As" operation. Let's ask ourselves, how many times do you expect the users to "save as" a document as opposed to just "save"? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #10 from Markus Mohrhard --- On the other hand the cached stream is a big speed-up for export. Our export is already quite slow so we might want to keep this optimization. That does not mean that I'm generally in favor of this optimization just that we need to think about the performance impact of such a change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #9 from Kohei Yoshida --- There may be other things that depend on the full path of the host document, not just hyperlinks. Hence my proposal. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #8 from Kohei Yoshida --- The solution that might work better is to mark all table streams dirty when saving as a different document. It makes no sense to re-use streams unless you are overwriting an existing document anyway. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #7 from Markus Mohrhard --- And of course it is not as easy as expected. The hyperlink is parsed somewhere in the shared rich text import. I still have no idea where the hyperlink is later stored or where we would have the right place to mark the stream dirty. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 --- Comment #6 from Markus Mohrhard --- I wonder how this could have worked in old releases. It is part of our old optimization to store the input stream for writing it out again unchanged when the stream is not marked dirty. o the solution is to mark the stream dirty during import if it contains a link. You can control that by adding a value to any cell between step 3 and 4. This forces an invalidation of the input stream and therefore a real export and not writing out the old input stream. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Joren De Cuyper changed: What|Removed |Added CC||joren.libreoffice@telenet.b ||e --- Comment #5 from Joren De Cuyper --- Reproducible with LibreOffice 4.0.0.0.beta2 (Bouw-id: 4104d660979c57e1160b5135634f732918460a0) TinderBox: MacOSX TDF Release, Branch:libreoffice-4-0, Time: 2012-12-18_17:13:13 Mac OSX 10.8.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Rainer Bielefeld changed: What|Removed |Added OS|Windows (All) |All --- Comment #4 from Rainer Bielefeld --- Modified OS due to Comment 3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||er...@redhat.com, ||kohei.yosh...@suse.de, ||markus.mohrhard@googlemail. ||com Ever confirmed|0 |1 --- Comment #3 from Julien Nabet --- On pc Debian x86-64 with master sources updated today (commit 24f0aa76c005d1506a6d13945c39dafc6e9b8d91), I reproduced this behaviour. Eike/Markus/Kohei: would one of you have some time about this tracker? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Rainer Bielefeld changed: What|Removed |Added Blocks||54157 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58069] FILESAVE in different path structure destroys relative hyperlinks
https://bugs.freedesktop.org/show_bug.cgi?id=58069 Rainer Bielefeld changed: What|Removed |Added Severity|major |critical Summary|FILESAVE: document destroys |FILESAVE in different path |relative hyperlinks |structure destroys relative ||hyperlinks --- Comment #2 from Rainer Bielefeld --- I did the same test with a Writer document, problem did not appear -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
