[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

Xisco Faulí  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||xiscofa...@libreoffice.org
   Assignee|rakshita...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #30 from Xisco Faulí  ---
Dear  Rakshita Varadarajan,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

Rakshita Varadarajan  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rakshita...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #24 from Rakshita Varadarajan  ---
(In reply to Buovjaga from comment #23)
> (In reply to Rakshita Varadarajan from comment #22)
> > Hello! Can I work on this issue? I just reproduced the error in Ubuntu 
> > 20.04.
> 
> As you can see from the comments and status, nobody is working on this as of
> now.

Okay great, I'll get started

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #23 from Buovjaga  ---
(In reply to Rakshita Varadarajan from comment #22)
> Hello! Can I work on this issue? I just reproduced the error in Ubuntu 20.04.

As you can see from the comments and status, nobody is working on this as of
now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #22 from Rakshita Varadarajan  ---
Hello! Can I work on this issue? I just reproduced the error in Ubuntu 20.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #21 from Rakshita Varadarajan  ---
Hello! Can I work on this issue? I just reproduced the error in Ubuntu 20.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #20 from Michael Stahl (CIB)  ---
follow up to comment #3 and comment #4:

some reading reveals that there is exactly 1 timezone in MSO binary files: the
type FILETIME is always UTC, as specified in [MS-DTYP]
https://msdn.microsoft.com/en-us/library/cc230273.aspx "2.3.3 FILETIME".

hence the import code in oleprops.cxx should set the util::DateTime value to
UTC, and the SfxDocumentInfoDialog may need to either display an UTC marker or
convert to local time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #19 from Lionel Elie Mamane  ---
(In reply to Yassine from comment #18)
> While trying to find the place into the code where this issue is situated,

> Could someone point us to the exact file where the date and time are saved
> into the properties of the document.

Please read comment 3 and comment 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #18 from Yassine  ---
While trying to find the place into the code where this issue is situated,
we've found multiple files related to datetime

- /core/include/tools/datetime.hxx
- /tools/source/datetime/datetime.cxx
- /core/tools/source/datetime/datetimeutils.cxx
- /core/include/sfx2/dinfdlg.hxx
- /core/sfx2/source/doc/docinfo.cxx
- /core/sfx2/source/dialog/dinfdlg.cxx
- /core/sax/qa/cppunit/test_converter.cxx
- /core/unotools/source/misc/datetime.cxx
- /core/ucb/source/ucp/webdav-neon/DateTimeHelper.cxx
-
/core/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/DateTime.hpp

Could someone point us to the exact file where the date and time are saved into
the properties of the document.

Could someone also explain the logic behind the file properties and how they
are recorded/loaded while closing/opening a file. 

Thanks for the help

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #17 from Yassine  ---
Steps to reproduce under GNU/Linux:
 - Modify the timezone in your terminal with the following command: 
  sudo dpkg-reconfigure tzdata
 - Create a new file and save it to disk
 - Modify again the timezone and go to your normal timezone again with the same
command: sudo dpkg-reconfigure tzdata
 - Open the newly created file, go to File -> Properties and then see that the
timezone was not modified according to the change into the timezone.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

Yassine  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All

--- Comment #16 from Yassine  ---
Changing status to "All operating systems", after successfully reproducing the
bug on Ubuntu GNU/Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #15 from jan iversen  ---
(In reply to nassimedu92 from comment #14)
> Hello, we try my friends and me to resolve this bug , I said we try lol. But
> I would have some explications about the SvStream file please


Why do you need SvStream, look at comment 3, it tell you which files to work
with.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/ displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #14 from nassimed...@hotmail.fr ---
Hello, we try my friends and me to resolve this bug , I said we try lol. But I
would have some explications about the SvStream file please

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

jan iversen  changed:

   What|Removed |Added

 Whiteboard|BSA |ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #10 from declan_moria...@yahoo.co.uk ---
Created attachment 113984
  -- https://bugs.documentfoundation.org/attachment.cgi?id=113984action=edit
LibreOffice Properties of test time.doc on OS X Mavericks 10.9.5

I have produced a new attachment that shows I am able to reproduce this bug
with the latest version of LO 4.4.0.3 on OS X Mavericks 10.9.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

Maarten Hoes hoes.maar...@gmail.com changed:

   What|Removed |Added

 OS|All |Mac OS X (All)

--- Comment #11 from Maarten Hoes hoes.maar...@gmail.com ---
(In reply to Maarten Hoes from comment #7)
 Created attachment 113961 [details]
 Screenshot of test time file with LibreOffice 4.3.6.2 on Windows 8.1
 
 I cannot reproduce this with LibreOffice 4.3.6.2 on Windows 8.1.


(In reply to declan_moriarty from comment #10)
 Created attachment 113984 [details]
 LibreOffice Properties of test time.doc on OS X Mavericks 10.9.5
 
 I have produced a new attachment that shows I am able to reproduce this bug
 with the latest version of LO 4.4.0.3 on OS X Mavericks 10.9.5.

I guess this means that it is reproducible on OS X, but not Windows 8.1.
Setting the OS from 'All' to 'MAC OS X'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #7 from Maarten Hoes hoes.maar...@gmail.com ---
Created attachment 113961
  -- https://bugs.documentfoundation.org/attachment.cgi?id=113961action=edit
Screenshot of test time file with LibreOffice 4.3.6.2 on Windows 8.1

I cannot reproduce this with LibreOffice 4.3.6.2 on Windows 8.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #6 from Souvik Chakraborty souvik.i...@gmail.com ---
Hi!

I'd like to help with this.

Will tweaking only the two mentioned files resolve this or do things need to be
fixed throughout the libreoffice code?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #9 from Souvik Chakraborty souvik.i...@gmail.com ---
(In reply to Tomaz Vajngerl from comment #8)
 or fix the cause of this bug in the source code - EASY.

Okay. Let me see what can be done...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65209

--- Comment #8 from Tomaz Vajngerl qui...@gmail.com ---
(In reply to Souvik Chakraborty from comment #6) 
 Will tweaking only the two mentioned files resolve this or do things need to
 be fixed throughout the libreoffice code?

You have the choice.. resolve the two mentioned files + every other people's
file that are wrong (involves visiting every possible LibreOffice user) - HARD,
or fix the cause of this bug in the source code - EASY.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=65209

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #5 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=65209

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 Whiteboard|BSA |BSA EasyHack
   ||DifficultyBeginner SkillCpp
 QA Contact|joren.libreoffice@telenet.b |
   |e   |
 CC||lio...@mamane.lu,
   ||mst...@redhat.com
Summary|FILEOPEN: MS Word generated |FILEOPEN: MS Word document
   |docs creation times in LO   |properties creation times
   |don't show British Summer   |etc. time zones not
   |Time.   |preserved/displayed
   Keywords|regression  |
  Component|Writer  |filters and storage

--- Comment #3 from Michael Stahl mst...@redhat.com ---
problem is that LO has never supported timezones in Document Properties.

but i believe it should be possible to do this properly with the
API changes to com.sun.star.util.DateTime for LO 4.1,
likely the Document Properties dialog in sfx2/source/dialog/dinfdlg.cxx
needs a little tweak to evaluate the timezone,
and/or the DocumentSummaryInformation
import/export in sfx2/source/doc/docinf.cxx needs to be taught
about timezones.

removing regression due to contradictory version information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65209] FILEOPEN: MS Word document properties creation times etc. time zones not preserved/displayed

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=65209

--- Comment #4 from Lionel Elie Mamane lio...@mamane.lu ---
(In reply to comment #3)
 problem is that LO has never supported timezones in Document Properties.
 but i believe it should be possible to do this properly with the
 API changes to com.sun.star.util.DateTime for LO 4.1,

Nothing happened wrt to timezone for 4.1. I originally planned to
add timezone support in some way, but it did not happen yet.

I expect that such a support is not necessary for this bug, though. That's how
I would do it: If the timestamp (datetime) in the file is given with
timezone, it should be converted to UTC upon reading, stored in memory as UTC
and converted to localtime for display.

When writing a file, we can just store the time always as UTC.

 likely the Document Properties dialog in sfx2/source/dialog/dinfdlg.cxx
 needs a little tweak to evaluate the timezone,
 and/or the DocumentSummaryInformation
 import/export in sfx2/source/doc/docinf.cxx needs to be taught
 about timezones.

Reading this file, sfx2/source/doc/oleprops.cxx and
tools/source/datetime/datetime.cxx, from the comments the intention of the
current design seems to be to convert to *local* time upon reading and then
keep everything in local time. That can work too.

I don't see this conversion happening, though:

 - SfxOleFileTimeProperty::ImplLoad seems to read two raw 32-bit values
   from the file (the SvStream is the file I presume?)
 - and passes them to DateTime::CreateFromWin32FileDateTime
 - which possibly buggily (e.g. it ignores leap seconds) converts that
   to a ::DateTime

But possibly I'm missing it in some other place.

This seems to suggest that the file does not contain any timezone information
after all... So the bug is in being *consistent* throughout internal
LibreOffice code (either use localtime everywhere, or UTC everywhere), or in
the conversion to localtime for display, or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs