[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 OS|Linux (All) |All
 Blocks|6   |54157

--- Comment #15 from tommy27 ba...@quipo.it ---
confirmed on Win7 64bit using LibO 4.0.4.
changing platform to ALL
moving this from mab3.6 list (3.6.x is EOL) to mab4.0 list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

tommy27 ba...@quipo.it changed:

   What|Removed |Added

Summary|When Undo is used too   |When Undo is used too
   |often, no prompt to save|often, no prompt to save
   |document on close.  |document on close

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

tommy27 ba...@quipo.it changed:

   What|Removed |Added

Version|3.5.7.2 release |3.4.6 release
   Keywords||regression

--- Comment #16 from tommy27 ba...@quipo.it ---
I was also able to reproduce it in LibO 3.4.6 while it worked in LibO 3.3.4

changed version field and added regressione keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close

2013-08-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #17 from Michael Stahl mst...@redhat.com ---
most likely regression from OOo 3.4 beta, CWS undoapi

fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-07-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Terrence Enger lo_b...@iseries-guru.com changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #14 from Terrence Enger lo_b...@iseries-guru.com ---
 caolanm-mstahl: What do you think. 
 a) We add a flag to the undo manager that the undo limit was reached at some
 point so that an empty undo stack doesn't mean there was no modifications to
 the document. 

Well, I find it useful to have the document-modified flag cleared when
I undo everything I have done.  Could this be accomplished by saving
the document-modified flag with each undo entry and restoring the flag
when the action is undone?

 b) ... calc, draw, impress, math etc don't appear to ever unset their
 modified state when undo-ed back to the start and writer is the odd one out.

As an occasional user of Calc, I would like it to reset the
document-modified flag when everything has been undone back to the
original state of the file.

Terry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 Blocks|60270   |6

--- Comment #12 from Michael Meeks michael.me...@novell.com ---
Adjusting - clearly a rather old MAB then if it affects 3.5 :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-07-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it
Version|4.1.0.1 rc  |3.5.7.2 release

--- Comment #13 from tommy27 ba...@quipo.it ---
changing version to last 3.5 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Caolán McNamara caol...@redhat.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||caol...@redhat.com
Summary|Crash, when Undo is used|When Undo is used too
   |too often   |often, no prompt to save
   ||document on close.

--- Comment #7 from Caolán McNamara caol...@redhat.com ---
So the backtrace in comment #5 has neon and ssl in it, so I think that
backtrace is actually for bug #66009 (reported by the same user, so that makes
sense) and not this actual bug.

In the original comment, and all the other ones, there is no crash as far as I
can see, but a failure to prompt to save when closing the document. So I've
retitled this bug as When Undo is used too often, no prompt to save document
on close.

*But* if this is a document where undo has undone every change to the document
then there are no changes to save then that's the correct behaviour. i.e. the
exact same behaviour we have with a blank new document, you can close that
without getting prompted to save it too.

So the question now is: Is there a bug where we have a document which *does*
have changes in it which causes no prompt to save when you attempt to close ?

bfoman: Your comment suggests there is ?, if so how to reproduce a situation
where there are unsaved changes and no prompt to save on close ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

--- Comment #8 from bfoman bfo.bugm...@spamgourmet.com ---
(In reply to comment #7)
 So the question now is: Is there a bug where we have a document which *does*
 have changes in it which causes no prompt to save when you attempt to close ?
 bfoman: Your comment suggests there is ?, if so how to reproduce a situation
 where there are unsaved changes and no prompt to save on close ?

Just add a letter per line till you are over default 100 undos limit (or change
it to lower value) and start undoing. Ctrl+w when you are done and you will go
back to StartCenter. The document with rest of changes will be lost. No prompt
to save.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Caolán McNamara caol...@redhat.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
   Keywords|want-backtrace  |

--- Comment #9 from Caolán McNamara caol...@redhat.com ---
indeed, confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

--- Comment #10 from Caolán McNamara caol...@redhat.com ---
like this all the way back to 3.5 AFAICS

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 66071] When Undo is used too often, no prompt to save document on close.

2013-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66071

Caolán McNamara caol...@redhat.com changed:

   What|Removed |Added

 CC||mst...@redhat.com

--- Comment #11 from Caolán McNamara caol...@redhat.com ---
caolanm-mstahl: What do you think. 
a) We add a flag to the undo manager that the undo limit was reached at some
point so that an empty undo stack doesn't mean there was no modifications to
the document. 

b) Or (cheaper) remove the m_rState.ResetModified in
sw/source/core/undo/docundo.cxx currently hooked off
SdrUndoManager::HasTopUndoActionMark on the basis that calc, draw, impress,
math etc don't appear to ever unset their modified state when undo-ed back to
the start and writer is the odd one out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs