[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|target:4.3.0|target:4.3.0 target:4.2.1 --- Comment #19 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tor Lillqvist committed a patch related to this issue. It has been pushed to libreoffice-4-2: http://cgit.freedesktop.org/libreoffice/core/commit/?id=53bd91ad654495130ceba74dd72d4a6f95c94fc5h=libreoffice-4-2 fdo#70376: Put only document (file) name in window title on OS X It will be available in LibreOffice 4.2.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #9 from Emir Sarı bitig...@openmailbox.org --- Where does the code reside for this? I searched but I could not find. I want to try to fix this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #10 from Khaled Hosny khaledho...@eglug.org --- Check https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=vcl/osx/salframe.cxx;h=6b236d6779840c0bc251f9798e092f2aab62cb51;hb=HEAD#l299 and the code that calls it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #11 from Emir Sarı bitig...@openmailbox.org --- I just did a quick search on the Apple Developer Base, and found this. If we would drop the file name from the titlebar, would this fix this bug: NSString* pTitle = CreateNSString( rTitle ); [mpNSWindow setTitleWithRepresentedFileName: pTitle]; -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #13 from Tor Lillqvist t...@iki.fi --- Like all (?) Objective-C method names, the first letter is lower-case: setTitleWithRepresentedFilename. But that won't help, I think, or at least will be confusing, as it will just make OS X think the whole title string, including the - LibreOffice BlaBla, is part of the file name. Instead, you should find out what it is that constructs the window title on higher levels (unfortunately, a quick git grep for - did not help), and there drop the application name in the case of OS X. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #14 from Tor Lillqvist t...@iki.fi --- Could possibly be the code in TitleHelper::impl_updateTitleForFrame() in framework/source/fwe/helper/titlehelper.cxx , testing that. (But it will take a while as my Mac build is currently ongoing.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.3.0 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tor Lillqvist committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=eeb840d6ba930015b969c3d0a98031f0ae508d61 fdo#70376: Put only document (file) name in window title on OS X The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Emir Sarı bitig...@openmailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=59163 --- Comment #15 from Emir Sarı bitig...@openmailbox.org --- I also read that setTitleWithRepresentedFilename does always force displaying of proxy icon, in whick LO has a problem already (Bug 59163). I think this titlebarhelper.cxx is the part which displays LibreOffice Writer, Calc on the title bar according to the component wouldn't it make more sense to drop it all completely? In Mac all modern Mac applications app name is never shown on the title bar, in LO case it is understandable since it has many components, but I think it would not harm to drop it all completely, since I think everyone knows which component they are working on. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #12 from Emir Sarı bitig...@openmailbox.org --- Update: I replaced the string in salframe.cxx, first build attempt aborted because I did not add the string to salframe.h. For the second build attempt I got this error: /Users/Emir/lo/core/vcl/osx/salframe.cxx:308:5: warning: instance method '-SetTitleWithRepresentedFileName:' not found (return type defaults to 'id') [-Wobjc-method-access] [mpNSWindow SetTitleWithRepresentedFileName: pTitle]; ^ ~~~ /Users/Emir/lo/core/vcl/osx/salframe.cxx:328:13: warning: instance method '-SetTitleWithRepresentedFileName:' not found (return type defaults to 'id') [-Wobjc-method-access] [mpDockMenuEntry SetTitleWithRepresentedFileName: pTitle]; Any ideas? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #17 from Emir Sarı bitig...@openmailbox.org --- Created attachment 93340 -- https://bugs.freedesktop.org/attachment.cgi?id=93340action=edit after the patch! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Emir Sarı bitig...@openmailbox.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #18 from Emir Sarı bitig...@openmailbox.org --- Thank you Tor! Fixed and verified! LO titlebar looks neater now! Any chance to port this for 4.2 as well? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Ahmad Harthi aalhar...@kacst.edu.sa changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #8 from Ahmad Harthi aalhar...@kacst.edu.sa --- I can reproduce this bug, marked as NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #1 from tommy27 ba...@quipo.it --- would you please attach a test document with such a problematic filename? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #2 from Khaled Hosny khaledho...@eglug.org --- Is this LibreOffice/OpenOffice specific? Looks like OS issue to me, what happens if you open the file (or similarly named one) in other applications? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #3 from Urmas davian...@gmail.com --- That bug does not manifest on Windows as the program window is not mirrored there. But that's how the current title is displayed when titlebar is RTL. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #4 from Emir Sarı bitig...@openmailbox.org --- Created attachment 89684 -- https://bugs.freedesktop.org/attachment.cgi?id=89684action=edit Same file in TextEdit This is a LO/AOO/NO specific issue, here you can see the same file opened with TextEdit. Anyway, I am setting this issue to NEW, since it is obviously broken. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #5 from Foss f...@openmailbox.org --- Emir, would a test odt be useful in this case? Can you point out clearly what is not displayed correctly? For people unfamiliar with arabic or hebrew text it might not be obvious. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #6 from Khaled Hosny khaledho...@eglug.org --- In my system TextEdit shows only the file name in the titlebar, so I can’t compare this. But the LibreOffice issue can be easily explained; LibreOffice sets the title as file name - LibreOffice app name, if the file name starts with a strong left to right character then Mac OS X displays the string with RTL base direction, and then we get the ugly mix of RTL and LTR text. You can easily reproduce this by typing the string: نص.odt - LibreOffice Writer In Writer and setting the text direction to RTL, you will end up with the same mix. One solution to this is to drop the - LibreOffice app name from the title bar entirely. Another solution is to force the title to always have a LTR direction by appending a U+200E (Left To Right Mark), but what about users using RTL UI? Detect it and insert U+200F (Right To Left Mark) instead? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 --- Comment #7 from Emir Sarı bitig...@openmailbox.org --- I'll try to reproduce the issue with different software and post the results to see how they are handling. I think the best way would be dropping the LibreOffice name, software name is already displayed on the menu bar, so there is no need for a second presentation I think. Also this would prevent any future bugs or inconsistencies possible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Emir Sarı emir_s...@msn.com changed: What|Removed |Added Attachment #87457|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70376] RTL file names do not display properly on the window bar
https://bugs.freedesktop.org/show_bug.cgi?id=70376 Emir Sarı emir_s...@msn.com changed: What|Removed |Added QA Contact||emir_s...@msn.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
