[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard||EasyHack ||DifficultyInteresting ||SkillScript Severity|normal |enhancement CC||er...@redhat.com Ever confirmed|0 |1 --- Comment #1 from Eike Rathke --- The only platform we bundle an internal ICU is Windows, all other platforms usually use whatever is the current ICU on their system. Note that installing another ICU on your system does not make LibreOffice use that other ICU because the ICU versioning mechanism which it was compiled against prevents that. However, upgrading the internal ICU to 52.1 (or whatever will be current when this request is picked up) is a valid request anyway. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #2 from Robert M Campbell --- I am thinking having it in Windows would be useful - the only solution that exists in the language right now is specifically for MS Office, which means almost eveything in the country is pirated. On top of that, the solution requires a third-party add-on, which is well done, but not open source. It would be awesome if Laos could get away from pirated MS Office and move to open source. :) As for Linux and Mc side of things, if it could look for the latest (52.1), that would be good. I currently have systems with LibreOffice that would benefit (and I know quite a few friends who would like to use it as well). I have ICU installed but LibreOffice is using something else, and not the latest version (not sure how to override that - but workaround hints could be hlpeful). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #3 from Eike Rathke --- You can't override the ICU version unless you build LibreOffice yourself against a newer ICU. ICU C++ symbols include the version used as namespace prefix. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #4 from Robert M Campbell --- Ok, makes perfect sense now! (Had been told by several others - install latest ICU on system and it'll just work, but obviously it's not that easy...) Is it possible for me to compile against the newer version just by modifying LibreOffice, or should it just be as simple as dl-and-compile then LibreOffice will use the latest? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #5 from Robert M Campbell --- Just built it for Ubuntu 13.10. And it works like a charm with Lao! Is it possible for the next pre-release binaries (Linux / Windows / Mac) to be built with ICU 52.1? Or, I guess it's probably the same as asking if the internally used ICU can be upgraded to ICU 52.1... I know of several who would test it here in Laos... Or, is that something I can take on personally? (I don't mind helping contribute to LibreOffice and the like on a regular basis) What do I need to do in order to help in that process? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #6 from Eike Rathke --- Hey great it worked! And if you'd like to help out and invest some time to substitute the internal ICU so we'd be good at least on Windows I'd really appreciate. I just uploaded 9e96ed4c1d99c0d14ac03c140f9f346c-icu4c-52_1-src.tgz to our lookaside cache of external sources so it can be used by builds once things are setup. So what to do: In current master the ICU build related things are located in the directory external/icu/ There * in the UnpackedTarball_icu.mk file remove the gb_UnpackedTarball_set_pre_action labeled "# *ONLY* for ICU 51(.1)!" that unpacks ICU_51_LAYOUT_FIX_TARBALL * for each patch in gb_UnpackedTarball_add_patches * check if the patch still needs to be applied or if for the ICU ticket mentioned, if any, the code was fixed * check if a needed patch applies correctly * if not, adapt the patch if applicable * if unsure whether a patch should still be applied or how the whole thing works just cry for help ;-) In the build root: * edit download.lst and * replace export ICU_TARBALL := 6eef33b229d0239d654983028c9c7053-icu4c-51_1-src.tgz with export ICU_TARBALL := 9e96ed4c1d99c0d14ac03c140f9f346c-icu4c-52_1-src.tgz * remove the line export ICU_51_LAYOUT_FIX_TARBALL := 7650341b04f05ff2595bf064f3e41f41-icu-51-layout-fix-10107.tgz * edit configure.ac and search for ICU_MAJOR=51 and change to ICU_MAJOR=52 Then (be sure you did not have --with-system-icu configured ...) make clean && ./autogen.sh && make && make check and cross fingers ;-) Run the suite and check things you are interested in. If everything's fine create a commit and submit it to our gerrit for review, see https://wiki.documentfoundation.org/Development/gerrit for details about working on a branch, creating commits and submitting to gerrit. I hope that helps and works, and thanks again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #7 from Eike Rathke --- One thing to check after ./autogen.sh just to be sure that indeed the new internal ICU is used: the file config_host.mk should contain export ICU_MAJOR=52 export ICU_MINOR=1 export SYSTEM_ICU=NO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #8 from Robert M Campbell --- I am reading a bit on crosscompiling on Linux for Windows XP - that would take a LOT less time than building it on Windows XP (which is a VM) and requiring the download of loads of Windows code I won't normally need on that VM. I've been reading http://www.derivativezero.com/blog/2012/07/tech-update-libreoffice-cross-compile-msi-installer-generation/. Seems doable, but not quite sure what the best seetings are... The settings that site lists are: CC=ccache i686-w64-mingw32-gcc CXX=ccache i686-w64-mingw32-g++ CC_FOR_BUILD=ccache gcc CXX_FOR_BUILD=ccache g++ –with-distro=LibreOfficeMinGW Does that build for Windows XP 32bit or a 64bit? Never done anything like this before... (It does, however, look really cool!) Noting I am working on a amd 64 bit version of Ubuntu 13.10 Saucy, and wanting to build for Windows XP 32bit, what should the CC, CXX, etc be set to? I'll report the results of my build if I can get it to crosscompile on Linux, or if my Internet speed allows me to do it on the Windows XP VM. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #9 from Robert M Campbell --- Access forbidden on http://dev-www.libreoffice.org/src/9e96ed4c1d99c0d14ac03c140f9f346c-icu4c-52_1-src.tgz Will do an Ubuntu build first, then figure out how to cross compile for Windows XP or build on Windows XP. To cross compile for Windows XP, what should build / host / target be set to? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #10 from Eike Rathke --- Oops, sorry, missed a chmod on the file, should work now. I suggest to do all work on Linux and only if it works there do a Windows build. I never cross-compiled for Windows so can't help with that, but hopefully the README.cross file contains all necessary information. If you want to persuade that and run into trouble you may want to join the #libreoffice-dev channel on freenode.net IRC and/or the dev mailing list. However, once the patch is on gerrit we can trigger a Windows build from that to see if it builds, so you don't necessarily have to build on/for Windows yourself. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #11 from Robert M Campbell --- Playing around with patches... At least one of the patches no longer works correctly, as the file has changed. I have disabled all the ICU patches, and will see if it will run without them. It may be wise to take a look at them as well... The first IndicReordering one is the one it failed on. Doing a on gerrit would be nice! (my system is good and all, but it's slower than some...) README.cross doesn't work out-of-the-box for me currently... I could also be doing something wrong. It's complaining: configure: error: cannot determine MinGW sysroot Got all of the packages for MinGW-W64 for Ubuntu, but not sure what else I might be missing... Could a testable snapshot for windows be built from gerrit? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #12 from Eike Rathke --- Patches that don't apply anymore because a file has changed but otherwise does not implement the fix the patch provides will have to be adapted to the new file and a new patch be generated to be included in the build. Running ICU without the patches probably is possible, but each addresses a different problem. Sorry, no idea about the MinGW stuff, I suggest to ask on the mailing list or IRC. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #13 from Robert M Campbell --- Good news, it compiles and runs nicely - at least on my machine. :) As for the patches, this is what my research has come up with so far... 10318 -> fixed in ICU 52.1, patch not needed, I think 7601 -> Closed, but not may not be fixed http://bugs.icu-project.org/trac/ticket/7601 The bug was closed, but may not be satisfactory I think the old patch should be adjusted and used 8198 -> Open - Patch still needed http://bugs.icu-project.org/trac/ticket/8198 9948 -> Open - Patch still needed Major Target for 53.1 2014-04-02 http://bugs.icu-project.org/trac/ticket/9948 10129 -> Fixed, patch not needed, I think --- The rest probably just need to be adjusted to the new code... I think I will give it a try to add the patches to here once I am done. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #14 from Robert M Campbell --- Sadly, it looks like I won't be able to do the patches the same way as they were done before at this time. I downloaded a compressed version of the source previously, due to the slower speeds we have of DSL here in Laos. I wanted to grab the source from git, but it failed last night - will try again, but not certain it will work. I have not worked with many (maybe one or two) patches, and I think I was mostly applying them as opposed to making them. Does it matter if the file locations noted in the top part is different? Also, my patches look different than the format used in the previous patches. Not using Git, is it possible for me to replicate the same format here using diff? If so, how? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #15 from Eike Rathke --- The file locations in the diff header may be different, as long as the number of subdirectories (should be one) before icu/... in the paths match, you can edit them to suit the needs. Something like misc/icu/... should do. The patches applied during build are not generated using git, just plain diff of original and modified source. As for the diff format we use unified diffs, diff -u -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #16 from Robert M Campbell --- Created attachment 88959 --> https://bugs.freedesktop.org/attachment.cgi?id=88959&action=edit Patch 1 of 13 to update to ICU 52.1 This is my first attempt at creating a patch, so please review throughouly. Any suggestions are greatly helpful! (Patch 1 of 13) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #28 from Robert M Campbell --- Created attachment 88976 --> https://bugs.freedesktop.org/attachment.cgi?id=88976&action=edit Patch 13 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #19 from Robert M Campbell --- Created attachment 88965 --> https://bugs.freedesktop.org/attachment.cgi?id=88965&action=edit Patch 4 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #20 from Robert M Campbell --- Created attachment 88966 --> https://bugs.freedesktop.org/attachment.cgi?id=88966&action=edit Patch 5 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #21 from Robert M Campbell --- Created attachment 88967 --> https://bugs.freedesktop.org/attachment.cgi?id=88967&action=edit Patch 6 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #22 from Robert M Campbell --- Created attachment 88968 --> https://bugs.freedesktop.org/attachment.cgi?id=88968&action=edit Patch 7 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #23 from Robert M Campbell --- Created attachment 88970 --> https://bugs.freedesktop.org/attachment.cgi?id=88970&action=edit Patch 8 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #17 from Robert M Campbell --- Created attachment 88962 --> https://bugs.freedesktop.org/attachment.cgi?id=88962&action=edit Patch 2 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #18 from Robert M Campbell --- Created attachment 88963 --> https://bugs.freedesktop.org/attachment.cgi?id=88963&action=edit Patch 3 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #24 from Robert M Campbell --- Created attachment 88972 --> https://bugs.freedesktop.org/attachment.cgi?id=88972&action=edit Patch 9 of 13 to update to ICU 52.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 Eike Rathke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #31 from Eike Rathke --- Thanks a lot! Though I would had preferred one complete changeset on gerrit (see https://wiki.documentfoundation.org/Gerrit ) that would had included the changes to UnpackedTarball_icu.mk, download.lst, configure.ac and added/removed files, I'll give this a try. What do you mean with "test the layout patches"? icu4c-build.patch is for building on Darwin and Arm, so you won't notice a difference on other platforms. icu4c-rpath.patch sets RPATH=$ORIGIN for relocatable runtime linkage dependencies, so building without you don't notice anything except when installing the package and something isn't found or pulled from the wrong location. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
