[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #26 from Julien Nabet  ---
Argh, I did a git diff > patch instead of git diff
dbaccess/source/ui/tabledesign/TableController.cxx > patch

so forget about "dbaccess/source/ui/tabledesign/TEditControl.cxx" part in the
patch, the main point is in dbaccess/source/ui/tabledesign/TableController.cxx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #25 from Julien Nabet  ---
Created attachment 189617
  --> https://bugs.documentfoundation.org/attachment.cgi?id=189617=edit
incomplete prerequisite patch

Lionel: just an idea about preparing implementations

First I reverted locally my workaround patch + did this change:
diff --git a/dbaccess/source/ui/tabledesign/TEditControl.cxx
b/dbaccess/source/ui/tabledesign/TEditControl.cxx
index 55696fe36463..3e9d4d851315 100644
--- a/dbaccess/source/ui/tabledesign/TEditControl.cxx
+++ b/dbaccess/source/ui/tabledesign/TEditControl.cxx
-sal_Int32 nPastePosition =
GetView()->getController().getFirstEmptyRowPosition();
-if ( !GetView()->getController().getTable().is() )
-nPastePosition = GetSelectRowCount() ? FirstSelectedRow() :
m_nDataPos;
+//sal_Int32 nPastePosition =
GetView()->getController().getFirstEmptyRowPosition();
+//if ( !GetView()->getController().getTable().is() )
+sal_Int32 nPastePosition = GetSelectRowCount() ? FirstSelectedRow() :
m_nDataPos;

It allows to put the cursor to insert a field at the right pos (instead of it
jumps to the end), then of course if you can type a name field and choose var
type when saving, the new field is at the end.

Then I tried to add some columns and noticed this bt for hsqldb:
#0  connectivity::OColumnsHelper::appendObject(rtl::OUString const&,
com::sun::star::uno::Reference const&)
(this=0x56357a993d90, _rForName="test", descriptor=uno::Reference to
(dbaccess::OTableColumnDescriptor *) 0x56357ab44d38) at
connectivity/source/commontools/TColumnsHelper.cxx:176
#1  0x7f64b0eeddd0 in dbaccess::OColumns::appendObject(rtl::OUString
const&, com::sun::star::uno::Reference
const&)
(this=0x56357a993d90, _rForName="test", descriptor=uno::Reference to
(dbaccess::OTableColumnDescriptor *) 0x56357ab44d38) at
dbaccess/source/core/api/column.cxx:356
#2  0x7f64d3973c3b in
connectivity::sdbcx::OCollection::appendByDescriptor(com::sun::star::uno::Reference
const&)
(this=0x56357a993d90, descriptor=uno::Reference to
(dbaccess::OTableColumnDescriptor *) 0x56357ab44d38) at
connectivity/source/sdbcx/VCollection.cxx:373
#3  0x7f64a3d59403 in dbaui::OTableController::alterColumns()
(this=0x56357aa546e0) at
dbaccess/source/ui/tabledesign/TableController.cxx:1197

appendObject is a generic method which can overloaded in the different DB
drivers located in connectivity.

Now between these lines in dbaccess/source/ui/tabledesign/TableController.cxx:
   1196 ::dbaui::setColumnProperties(xColumn,pField);
   1197 xAppend->appendByDescriptor(xColumn);
we could add 3 more info in xColumn (which is an XPropertySet):
- column name before (or empty if current is first column)
- column name after (or empty if current is last column)
- position (Firebird begins with 1,
https://firebirdsql.org/file/documentation/chunk/en/refdocs/fblangref30/fblangref30-ddl-table.html#fblangref40-ddl-tbl-altraltrpos)

Now drivers could use these infos or not so could be a first step.

To give a more precise idea, I attached an incomplete prerequisite patch.
Incomplete because it seems the extra info must be declared in some interface.

I don't think I'll know how keep on this but just wonder if it could be a
interesting way to follow for some coders.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |

--- Comment #24 from Julien Nabet  ---
Let's remove target since it's just a workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #23 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4bab6b0b870ae56b8d40eac22dbb0a433006789e

tdf#71224: Remove "Insert fields" option for an existing table (workaround)

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #22 from Julien Nabet  ---
Workaround here (I removed the entry "Insert fields" when the table already
exists):
https://gerrit.libreoffice.org/c/core/+/156948

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #21 from Alex Thurgood  ---
(In reply to Julien Nabet from comment #20)
> (In reply to Robert Großkopf from comment #19)

> But when editing, I meant perhaps there shouldn't be the entry "Insert Rows"
> (or should be grayed out) and for the moment, it's not the case.
> It's this entry during editing (and only during editing) which is disturbing
> since we see the cursor jumping at the end of table instead of inserting.

This would be my preferred solution, pending someone being able to write the
conditional code for handling the various supported insert DSL statements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #20 from Julien Nabet  ---
(In reply to Robert Großkopf from comment #19)
> (In reply to Julien Nabet from comment #18)
> > What about letting "Insert Rows" during creation of table since in this case
> > it works and removing it when editing the table?
> 
> That is, what is already implemented. I could insert a new row at any
> position while creating a new table. If I try to insert a new row (by
> context menu of mouse) at a special position when reopening an existing
> table for editing the cursor will be set at last row.
> ...
During creation everything is fine so I won't come back here.

But when editing, I meant perhaps there shouldn't be the entry "Insert Rows"
(or should be grayed out) and for the moment, it's not the case.
It's this entry during editing (and only during editing) which is disturbing
since we see the cursor jumping at the end of table instead of inserting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #19 from Robert Großkopf  ---
(In reply to Julien Nabet from comment #18)
> What about letting "Insert Rows" during creation of table since in this case
> it works and removing it when editing the table?

That is, what is already implemented. I could insert a new row at any position
while creating a new table. If I try to insert a new row (by context menu of
mouse) at a special position when reopening an existing table for editing the
cursor will be set at last row.

Base is a GUI for many database connections. How should it be implemented when
database engine won't support to insert new rows at a special position? We
would need special code for every database.

OK, it looks nice to get the position I want, but I could do this in forms or
queries.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #18 from Julien Nabet  ---
What about letting "Insert Rows" during creation of table since in this case it
works and removing it when editing the table?

I mean, it seems there's no SQL standard to do this as it had been already
indicated in various comments and some DBs like Postgresql still don't support
this (see https://wiki.postgresql.org/wiki/Alter_column_position).
Mysql (and so I suppose Mariadb) doesn't support "BEFORE" but "FIRST" and
"AFTER" (see https://dev.mysql.com/doc/refman/8.0/en/alter-table.html).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Alex Thurgood  changed:

   What|Removed |Added

 CC||kermit...@live.co.uk

--- Comment #17 from Alex Thurgood  ---
*** Bug 157190 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Alex Thurgood  changed:

   What|Removed |Added

 CC||vloxom...@gmail.com

--- Comment #16 from Alex Thurgood  ---
*** Bug 154620 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||petersmith60...@gmail.com

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
*** Bug 153340 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Jorge Teixeira  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9294

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #14 from rob...@familiegrosskopf.de ---
HSQLDB supports adding a new field at a position before an old field.
ALTER TABLE "Table" ADD "Name" VARCHAR(25) BEFORE "Existing Fieldname";

Firebird supports this:
ALTER TABLE "Table" ADD "Name" VARCHAR(25);
ALTER TABLE "Table" ALTER "Name" POSITION 2;

With Firebird you have to insert the row first. Then you could change the
position of the row afterwords. So it does work also with old and new added
fields.

Would be good if GUI supports adding a *new* field at a special position,
because both internal databases will support to set a field this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #13 from Buovjaga  ---
*** Bug 105935 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 CC||kacper-pac...@linux.pl

--- Comment #12 from rob...@familiegrosskopf.de ---
*** Bug 105935 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

--- Comment #11 from Heiko Tietze  ---
Removing needsUXEval. Ideally "Insert Row" works as expected (and actually is
effective when the new table hasn't been saved), as known from Kexi for
instance (formerly part of the Calligra suite). Alternatively a simple renaming
to "Add row" is also possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

--- Comment #10 from Lionel Elie Mamane  ---
Not all databases support adding new fields at an arbitrary place in the table.
For example PostgreSQL does not, it can add only at the end.

Whether embedded HSQLDB (and embedded Firebird) supports it, I'm not sure out
of the top of my head. If it does, yes, it would be nice for the GUI to support
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||needsDevEval, needsUXEval

--- Comment #9 from Alex Thurgood  ---
The other alternative would be to remove the "Insert Rows" entry from the
context menu, so that users would not be misled, leaving only the current UI
direct mouse click addition of adding a new field to the end of the already
available fields, however, it would be better to strive for a product that
allows such changes as originally intended.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working ( ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71224

Alex Thurgood  changed:

   What|Removed |Added

   Priority|high|medium

--- Comment #8 from Alex Thurgood  ---
It is not a bug, rather more a feature request, as the feature did not exist
already when the LibreOffice project came into being. As Robert has correctly
stated in comment 1, new fields are currently always added to the end of the
table definition, so the UI does not currently cater for the possibility of
adding new fields before/after other fields or changing the order of fields in
a database table.

Should such a feature be enabled ? Yes, absolutely, as the UI seems, at least
in appearance from the context menu, to allow this. Confirming that this indeed
is a feature request. Whether or not this is high on the list of priorities for
Base is another matter. The current feature deficit can be resolved by
resorting to SQL commands via the Tools > SQL menu entry, so there is a
workaround. Consequently, this RFE is probably not going to feature as a high
priority, unless someone volunteers to do the coding.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

--- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk ---
Adding self to CC if not already on

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

   Priority|highest |high

--- Comment #6 from Björn Michaelsen bjoern.michael...@canonical.com ---
(This is an automated message.)

LibreOffice development currently prioritizes bugs with the so called MAB (most
annoying bugs) -- as this bug has not run through that process (including
writing a short rationale for this bug being a candidate and other who are
watching the tracker bug silently approving that rationale etc.) its priority
is set to high. Note this is effectively no change in the urgency assigned to
this bug, as we are currently not making a difference between high and highest
and severity is untouched.

You can find out more about MABs and how the process works by contacting
libreoffice qa on irc:

 http://webchat.freenode.net/?channels=libreoffice-qa

The QA wiki page also gives you hints on how to get in contact with the team
(if IRC fails you, your next best choice is the mailing list):

 https://wiki.documentfoundation.org/QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

Kevin Suo suokunl...@gmail.com changed:

   What|Removed |Added

   Priority|medium  |highest

--- Comment #4 from Kevin Suo suokunl...@gmail.com ---
I set this feature request to highest, because this is the main reason which
blocks me from using libreoffice base.

To design a table, nobody can make all the fields done during the first time
they create a table. They have to move/insert fields later if needed. Currently
it's only possible to run SQL commands to re-arrange field order.

Almost all the database management software allows to insert fields between two
fields which already exist, except libreoffice base.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

--- Comment #5 from Kevin Suo suokunl...@gmail.com ---
Created attachment 102977
  -- https://bugs.freedesktop.org/attachment.cgi?id=102977action=edit
test database

steps:
1. Try to insert a new field CITY before NAME, AFTER ID.

In the GUI, the inserted fields always go to the bottom.

From tools-sql, run:
ALTER TABLE Table1 ADD CITY VARCHAR(25) BEFORE NAME;

New field is correctly inserted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

Kevin Suo suokunl...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=51605

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

suokunl...@gmail.com changed:

   What|Removed |Added

Summary|Insert row/s into table not |Insert new fields between
   |working |existing fields not working
   ||(ALTER TABLE ADD
   ||BEFORE/AFTER)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71224] Insert new fields between existing fields not working (ALTER TABLE ADD BEFORE/AFTER)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=71224

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   Severity|normal  |enhancement
Version|4.1.2.3 release |Inherited From OOo

--- Comment #3 from rob...@familiegrosskopf.de ---
This never worked before. So I set the Version to Inherited From OOo.

It was not implemented into the GUI for changing a table. There are very much
SQL-statements, which doesn't work in the GUI, but would work with direct SQL
(example: Default values in tabledesign and other default-values in  SQL). So
this is a ask for an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs