[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #7 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hi (In reply to comment #6) Here's a workaround. ... I confirm the workaround. Well found Julien :) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||ke...@collabora.com --- Comment #8 from Julien Nabet serval2...@yahoo.fr --- Jan: I saw in git history some commits about accelerators. I thought you might be interested since the form which make LO to crash doesn't contain accelerator. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178
--- Comment #9 from Julien Nabet serval2...@yahoo.fr ---
I tried this patch:
diff --git a/framework/source/accelerators/presethandler.cxx
b/framework/source/accelerators/presethandler.cxx
index f9ce7d4..5df2fde 100644
--- a/framework/source/accelerators/presethandler.cxx
+++ b/framework/source/accelerators/presethandler.cxx
@@ -599,7 +599,12 @@ css::uno::Reference css::io::XStream
PresetHandler::openTarget(const OUString
// e.g. module without any config data ?!
if (!xFolder.is())
- return css::uno::Reference css::io::XStream ();
+{
+if (bCreateIfMissing)
+m_xWorkingStorageUser = xFolder = getOrCreateRootStorageUser();
+else
+return css::uno::Reference css::io::XStream ();
+}
OUString sFile(sTarget);
sFile += .xml;
The form doesn't crash.
However, even if I modify the form, the accelerator part isn't created.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #10 from Caolán McNamara caol...@redhat.com --- broke between a96b6f4708d587d93101e51e52dec4e87b7e..e1b85e77b15a02d40049994e9829a0e3b921850c I believe -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.3.0 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolan McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=637bb5adf7593c26e17e83482e42ccb8fac845a8 Resolves: fdo#79178 Crash when opening a form created with a previous version The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #12 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolan McNamara committed a patch related to this issue. It has been pushed to libreoffice-4-3: http://cgit.freedesktop.org/libreoffice/core/commit/?id=94f4d28eb4d0a2cb73581f1483f18bb072c81b4ah=libreoffice-4-3 Resolves: fdo#79178 Crash when opening a form created with a previous version It will be available in LibreOffice 4.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #1 from Firas Hanife firashan...@gmail.com --- I can reproduce this issue on openSUSE 13.1 with: LibreOffice 4.3.0.0.beta1 Build ID: 2e39c7e59c8fc8b16a54c3d981dceef27fb0c07f Works as expected with 4.1.6.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #2 from ribotb rib...@gmail.com --- Hello, I confirm this problem and I add some precisions: 1) the crash does not occur systematically with forms created in a previous version of LO (some forms can be open without crash); 2) the crash is independent of the access method to the tables (direct access, SQL commands, Queries); 3) it can occur even if there is no control in the form (empty form)! Regards, Bernard -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- Created attachment 99745 -- https://bugs.freedesktop.org/attachment.cgi?id=99745action=edit bt with symbols On pc Debian x86-64 with master sources updated yesterday, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr Keywords||have-backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- I don't know if there's a link with the crash but unzipping the odb file shows that only Client form does contain meta.xml -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- Here's what I got after a gdb debug session The pb is in XMLBasedAcceleratorConfiguration::reload see http://opengrok.libreoffice.org/xref/core/framework/source/accelerators/acceleratorconfiguration.cxx#223 More precisely line 243-245 of this part: 239 css::uno::Reference css::io::XInputStream xIn; 240 if (xStream.is()) 241 xIn = xStream-getInputStream(); 242 if (!xIn.is()) 243 throw css::io::IOException( 244 OUString(Could not open accelerator configuration for reading.), 245 static_cast ::cppu::OWeakObject* (this)); the static_cast doesn't seem to work here. Also, if we unwind from here. LO goes into this part with Client because: xStream.is() is false because of this part: 231 xStream = m_aPresetHandler.openTarget(PresetHandler::TARGET_CURRENT(), true); // sal_True = open or create! This part calls 591 css::uno::Reference css::io::XStream PresetHandler::openTarget(const OUString sTarget , 592 bool bCreateIfMissing) see http://opengrok.libreoffice.org/xref/core/framework/source/accelerators/presethandler.cxx#590 but this method returns empty stream because m_xWorkingStorageUser is empty too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79178] Crash when opening a form created with a previous version
https://bugs.freedesktop.org/show_bug.cgi?id=79178 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||lio...@mamane.lu --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- Here's a workaround. unzip odb file and do this: - mkdir ./forms/Obj11/Configurations2/accelerator - touch ./forms/Obj11/Configurations2/accelerator/current.xml - in META-INF/manifest.xml, add this line manifest:file-entry manifest:full-path=forms/Obj11/Configurations2/accelerator/current.xml manifest:media-type=/ in Obj11 block Rezip and rename in odb, it works. Lionel: any idea how to solve this? (I attached a bt + gdb session) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
