[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Commit Notification changed: What|Removed |Added Whiteboard|NoRepro:4.0.0.0.beta1:Ubunt |NoRepro:4.0.0.0.beta1:Ubunt |u NoRepro:4.2.6.1:WinXP |u NoRepro:4.2.6.1:WinXP |target:4.4.0 target:4.2.7 |target:4.4.0 target:4.2.7 ||target:4.3.1 --- Comment #14 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cf2cf1d4fbb1622c1789cb893d5e9fd9de1cd61&h=libreoffice-4-3 Resolves: fdo#81641 the new style shouldn't be a conditional style It will be available in LibreOffice 4.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Commit Notification changed: What|Removed |Added Whiteboard|NoRepro:4.0.0.0.beta1:Ubunt |NoRepro:4.0.0.0.beta1:Ubunt |u NoRepro:4.2.6.1:WinXP |u NoRepro:4.2.6.1:WinXP |target:4.4.0|target:4.4.0 target:4.2.7 --- Comment #13 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=30ef30970073b969430011da25e9412ffc217e8b&h=libreoffice-4-2 Related: fdo#81641 create new styles with an initial name It will be available in LibreOffice 4.2.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Caolán McNamara changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #12 from Caolán McNamara --- ok, so the style should be created immediately, appear in the list, but on cancel get removed. It should not be a conditional style, and if we instead ok and delete it manually, then undoing and redoing should not crash. I didn't tackle the ugly extra "change style" undo. Its fairly cosmetic and there's enough to be getting on with. https://gerrit.libreoffice.org/#/c/10502/ for 4-3 https://gerrit.libreoffice.org/#/c/10503/ for 4-2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #9 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2223ff6cb99df097a357674801835c7a260b551d Related: fdo#81641 exclude 'all styles' category from organizer page The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #10 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=183bde5bf5aa048792880292ac7577fcd13b Related: fdo#81641 implement undo of Conditional Text style creation The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #11 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e904562af54545684b32d2042ded6bdb9459edca Related: fdo#81641 create new styles with an initial name The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Commit Notification changed: What|Removed |Added Whiteboard|NoRepro:4.0.0.0.beta1:Ubunt |NoRepro:4.0.0.0.beta1:Ubunt |u NoRepro:4.2.6.1:WinXP |u NoRepro:4.2.6.1:WinXP ||target:4.4.0 --- Comment #8 from Commit Notification --- Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1af0e46102350114dd5e854b7692c640dae2727f Resolves: fdo#81641 the new style shouldn't be a conditional style The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Caolán McNamara --- Looks like a comedy of errors here a) the style is created as a "conditional" style, conditional style creation has no undo implemented, which is an error and we should implement that. b) it shouldn't be a conditional style in the first place c) undo in master shows a format change to the newly created style, which shouldn't be shown in undo d) fixing a or b and creating the style, then deleting the style and then undoing the three steps (including the annoying change style) crashes -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Whiteboard|NoRepro:4.0.0.0.beta1:Ubunt |NoRepro:4.0.0.0.beta1:Ubunt |u |u NoRepro:4.2.6.1:WinXP -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #6 from Kevin Suo --- Reproduce with 4.0.6.2 Not reproduce with 4.0.0 beta1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #5 from Julien Nabet --- (In reply to comment #3) > I believe the style is created when the dialog appears, and on cancel > "undo(1)" is called which is supposed to undo adding the style Indeed, I noticed this on console: warn:legacy.osl:4274:1:svl/source/undo/undo.cxx:711: SfxUndoManager::Undo: undo stack is empty! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Whiteboard||NoRepro:4.0.0.0.beta1:Ubunt ||u -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Version|4.2.4.2 release |4.0.6.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Keywords||regression --- Comment #4 from Kevin Suo --- Do not reproduce in 3.6.7.2 --> REGRESSION. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Version|4.2.5.2 release |4.2.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Kevin Suo changed: What|Removed |Added Hardware|x86 (IA32) |All OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 --- Comment #3 from Caolán McNamara --- I believe the style is created when the dialog appears, and on cancel "undo(1)" is called which is supposed to undo adding the style -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com, ||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated 2 days ago, I could reproduce this. In comparison Calc styles dialog doesn't have this problem. sw: - sw/uiconfig/swriter/ui/templatedialog2.ui - sw/source/ui/fmtui/tmpdlg.cxx - sfx2/source/dialog/styledlg.cxx calc: - sc/uiconfig/scalc/ui/paratemplatedialog.ui - sc/source/ui/styleui/styledlg.cxx - sfx2/source/dialog/styledlg.cxx ? I noticed some differences between both parts - sw has an "Ok" method - GetRefreshedSet() in sw is not virtual - sw : pInSet->SetParent( &GetStyleSheet().GetItemSet() ); whereas sc : pItemSet->SetParent( GetStyleSheet().GetItemSet().GetParent() ); But found nothing about cancel. I must recognize I don't understand why cancel doesn't work in sw. Caolan: any idea? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 tommy27 changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|4.2.6.1 rc |4.2.5.2 release Ever confirmed|0 |1 --- Comment #1 from tommy27 --- confirmed under WinXP 32bit using 4.2.5.2 we should retest against early 4.2.x and late 4.1.x release to see if it's a regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81641] Cancel style creation still creates a new style
https://bugs.freedesktop.org/show_bug.cgi?id=81641 tommy27 changed: What|Removed |Added CC||ba...@quipo.it Summary|Cancle style creation still |Cancel style creation still |creates a new style |creates a new style -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
