[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||143781


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports and tasks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

Hossein  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 reviewed:2022

--- Comment #16 from Hossein  ---
Re-evaluating the EasyHack in 2022

This enhancement is still relevant. Both prewin.h and postwin.h wrapper headers
are still present and used in many files:

$ git grep postwin.h|wc -l
57

$ git grep prewin.h|wc -l
54

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #15 from Commit Notification 
 ---
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5a571307fb3306b74ab46b085cde6388270a770

tdf#82580 tools: rename Rectangle to tools::Rectangle

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #14 from jan iversen  ---
Please be aware, that this easyhack is considered an important but large scale
cosmetic change as described in
https://wiki.documentfoundation.org/Development/LargeScaleChanges

It was in decided by the ESC to close this kind of easyhacks, and send them
directly as mail, to new contributors.
https://lists.freedesktop.org/archives/libreoffice/2016-August/074920.html

Please do not submit patches with many files !!

This particular easyhack is kept open as an exception to the rule.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

jan iversen  changed:

   What|Removed |Added

 Whiteboard|target:4.4.0|ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #11 from Fernando Montes fernandomonte...@me.com ---
Darn ok. I will find another easy hack to be my first

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

Tor Lillqvist t...@iki.fi changed:

   What|Removed |Added

   Assignee|fedor...@mail.ru|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #6 from Tor Lillqvist t...@iki.fi ---
Please don't just sign a bug to yourself out of the blue. That is not how it
works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #7 from Fedor fedor...@mail.ru ---
Assign this bug to me. I think it is good start before refactoring god objects
at gsoc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #8 from Tor Lillqvist t...@iki.fi ---
It is enough to say you are working on this. If somebody else (another GSoC
hopeful?) is rude enough to jump onto this task just at the same time (for a
few weeks), we will notice, and take that as a sign that he/she is not good at
cooperation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #9 from SirFernanders fernandomonte...@me.com ---
any chance you need help on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

--- Comment #10 from Fedor fedor...@mail.ru ---
Still not need help.
Eclipse searchs well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82580

Fedor fedor...@mail.ru changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |fedor...@mail.ru
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

--- Comment #4 from Noel Grandin noelgran...@gmail.com ---
Personally I think we should do what Cygwin have done and create our own copy
of the win32 header that only contains the definitions we need, thus minimizing
the odds of conflict.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

--- Comment #5 from Tor Lillqvist t...@iki.fi ---
That is madness. We can't cross-compile a complete LibreOffice because the
reverse-engineered headers provided by mingw-w64 are incomplete. And those
headers have a very long history. So you expect us to be able to create
something similar, and in a legally valid clean-room fashion, just like that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

--- Comment #1 from Tor Lillqvist t...@iki.fi ---
One note, that I sadly think needs to be spelled out: Please don't attempt to
do this unless you actually have Windows, Visual Studio, etc and are able to
build LibreOffice on Windows. Don't submit changes without verifying yourself
that they don't break the compilation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
   |SkillCpp TopicCleanup   |SkillCpp TopicCleanup
   ||target:4.4.0

--- Comment #2 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8669b56b194a7cd6da771dfb9904710da24c0b4

fdo#82580: Win32 GetObject() simplification



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

--- Comment #3 from Thomas Arnhold thomas-l...@arnhold.org ---
(In reply to comment #0)
 2) in some cases it can be avoided to have the Win32 type
and the LO type visible in the same LO source file
by not including both the defining LO and Win32 headers

Note, that this could be complicated, because we (mostly) use precompiled
headers on Windows, which include nearly all headers needed by a module. See
for example oox/inc/pch/precompiled_oox.hxx, which includes all headers from
the oox module. And thus avoiding to include one file could be problematic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82580] get rid of prewin.h / postwin.h wrapper headers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82580

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 Whiteboard||EasyHack DifficultyBeginner
   ||SkillCpp TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs