[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

raal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||r...@post.cz
 Resolution|--- |FIXED

--- Comment #12 from raal  ---
patch committed, closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

--- Comment #10 from Julien Nabet serval2...@yahoo.fr ---
I was just astonished that the patch was first in 5.0 branch instead of master
branch, thank you for your quick feedback Cédric.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

--- Comment #9 from Cédric Bosdonnat cedric.bosdonnat@free.fr ---
(In reply to Julien Nabet from comment #8)
 Cédric: I don't find Szymon Kłos in Bugzilla, do you know what's planned for
 master branch?

His patch is sitting in his gsoc branch that will be merged in master before
the end of summer: so master is targetted too

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

Cédric Bosdonnat cedric.bosdonnat@free.fr changed:

   What|Removed |Added

 CC||eszka...@gmail.com

--- Comment #11 from Cédric Bosdonnat cedric.bosdonnat@free.fr ---
Adding Szymon as CC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

--- Comment #8 from Julien Nabet serval2...@yahoo.fr ---
Cédric: I don't find Szymon Kłos in Bugzilla, do you know what's planned for
master branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

--- Comment #7 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Szymon Kłos committed a patch related to this issue.
It has been pushed to libreoffice-5-0:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=050c4f9ceca3046159f7a24d3d5abf8ec4e47fb3h=libreoffice-5-0

tdf#84190 : when auth fails, don't remember passwords for cmis

It will be available in 5.0.0.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84190

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|| target:5.0.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

--- Comment #5 from Julien Nabet serval2...@yahoo.fr ---
Thank you Caolan for your feedback.

I tried again to investigate but got lost among all these functions:
GetCanRememberPassword, GetIsRememberPassword, IsSavePassword,
getRememberModes, rPreferredMode, rAlternateMode, Get and SetErrorText etc.
(Couldn't it be a litle less complicated!?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

--- Comment #6 from Cédric Bosdonnat cedric.bosdonnat@free.fr ---
The problem is more likely to be in the caching of content objects. The
corresponding code is in:
http://cgit.freedesktop.org/libreoffice/core/tree/ucb/source/ucp/cmis/cmis_provider.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

--- Comment #4 from Caolán McNamara caol...@redhat.com ---
from that dialogs perspective its correct, the user pressed ok and not
cancel so the return looks ok. Somewhere else the password must be rejected
by some authentication method silently which is the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #3 from Julien Nabet serval2...@yahoo.fr ---
Caolan: thought you might have an idea about this one since it concerns a
dialog box.
I noticed that even when I put the wrong password, executeLoginDialog returns
ERRCODE_BUTTON_OK, is it normal?
See:
http://opengrok.libreoffice.org/xref/core/uui/source/iahndl-authentication.cxx#275

If needed, here's a cmis server for test:
https://cmis.alfresco.com/cmisatom
http://cmis.alfresco.com/cmisatom
username: admin
password: admin
(from https://www.libreoffice.org/bugzilla/show_bug.cgi?id=72277#c10)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

--- Comment #2 from Julien Nabet serval2...@yahoo.fr ---
Another code pointer:
http://opengrok.libreoffice.org/xref/core/ucbhelper/source/provider/simpleauthenticationrequest.cxx#111

If changing ucb::RememberAuthentication_SESSION to
ucb::RememberAuthentication_NO + bAllowPersistentStoring = false, the dialog
box appears again.
1) I don't know if both changes are mandatory
2) the dialog box always appears even if the login/password is ok.
So now, we must find a way to retain the password when ok and to display the
dialog box if ko.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet serval2...@yahoo.fr ---
Cédric: Investigating a bit, it seems there's an exception when running
http://opengrok.libreoffice.org/xref/core/ucb/source/ucp/cmis/cmis_repo_content.cxx#182
This one comes from session-factory.cxx SessionFactory::createSession

However, I don't know why AuthProvider::authenticationQuery method from
auth_provider.cxx asks user/passwd first time and not the other times.

Any idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84190] libcmis: Wrong Password Entered For Alfresco Never Allows For Correction

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=84190

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||cedric.bosdonnat.ooo@free.f
   ||r, f...@libreoffice.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs