[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #6 from Buovjaga  ---
After checking with Chris, I am closing this. Thanks for the note, Felipe.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

--- Comment #5 from Felipe Lema  ---
Hi, there

I was taking a look at this in order to do an EasyHack, although it seems that
the request no longer applies: there are no constructors of `VirtualDevice`
that receive `uint_16` as bitCount or alphaBitCount)

I guess this means this can be closed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

--- Comment #3 from Michael Meeks  ---
I suspect the ambiguity is unpleasant - ie. if there are two constructors with
similar arguments we should have nice, readable, descriptive enum that
distinguishes between the two use-cases; rather than a random number that is
always the same value nAlphaBitCount added to the end =)

It seems we have:

ScopedVclPtrInstance pDevice(, Size(1, 1),
DeviceFormat::DEFAULT);

I wonder if we could overload something into the vdev creation along those
lines; not sure.

Beyond that the bigger problem is that VirtualDevices get created at a 1x1 size
initially - complete with OS resources behind them, which are slow & expensive
to create - and then we re-size them deleting the original stuff =) really the
creation needs to have a smoother flow that passes in the size correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

--- Comment #2 from Chris Sherlock  ---
Hi Michael, what is it that makes the constructor problematic? Could you give
some more info?

Thanks :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

jan iversen  changed:

   What|Removed |Added

 Whiteboard||ToBeReviewed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

Robinson Tryon (qubit)  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup

--- Comment #1 from Robinson Tryon (qubit)  ---
Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp,
topicCleanup)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

Robinson Tryon (qubit)  changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |
   |SkillCpp TopicCleanup   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86249

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||fdb...@neosheffield.co.uk
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86249] clean VirtualDevice constructor ...

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=86249

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Whiteboard||EasyHack DifficultyBeginner
   ||SkillCpp TopicCleanup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs