[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Maxim Monastirsky changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 --- Comment #14 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d8b1b4b085088487837ef6ffd0dc4580b2acbb12&h=libreoffice-5-0 tdf#88290 Adapt the numbering popup to more than 8 items It will be available in 5.0.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Commit Notification changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 ||target:5.0.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Maxim Monastirsky changed: What|Removed |Added Attachment #114068|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Commit Notification changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 --- Comment #13 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=71b35212265bb93b10ca35ab964a36e6b6cc552b tdf#88290 Adapt the numbering popup to more than 8 items It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Kevin Suo changed: What|Removed |Added Keywords||patch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 --- Comment #12 from Maxim Monastirsky --- Created attachment 114068 --> https://bugs.documentfoundation.org/attachment.cgi?id=114068&action=edit quick patch I believe that the attached patch, or a similar one, should solve that bug. But it's not tested at all, and unfortunately I'm unable to do any further investigation on this, or any other LO related stuff these days, due to personal reasons. So someone else would need to take care of testing/fixing/pushing that patch. Sorry. Some explanation: The nbdtmg.cxx part is the most important here, that's where the 8 items limit was set (DEFAULT_NUM_VALUSET_COUNT define is 8). Other parts are trying to deal with the behavior of the 10th item (as mentioned in comment 7). The old Sidebar popup had a "None" item which id was set to 10, that's where it came from. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Eike Rathke changed: What|Removed |Added CC||er...@redhat.com --- Comment #11 from Eike Rathke --- I don't like the approach to remove the entries from the locale data file. They are working from the dialog, just not from the tool bar. Rather fix the real cause. Furthermore this affects all locales with more than 8 NumberingLevel entries, I really don't want we end up removing entries from all those locales, even if it's just a few (apparently 3, bg_BG, th_TH, zh_CN). This would actually hide the bug so someone wanting to fix it would have extra work. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 Kevin Suo changed: What|Removed |Added Keywords||bisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.documentfoundation.org/show_bug.cgi?id=88290 --- Comment #10 from Kevin Suo --- Hi all, any update on this? The problem here is: * On the numbering dialog (Format -> Bullets and Numebering), more than 8 entries are allowed, and when there are more than 8 it works perfectly. * On the toolbar icon, if there are more than 8 entries, it does not work start from the 9th one. Seems that for now we have to revise the following commit to bring it back to 8 entries for now: https://gerrit.libreoffice.org/#/c/13646/ (ACTom is trying to making a patch on this) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 --- Comment #9 from Jay Philips --- I'm running master 2015-01-04, which doesnt have your patch. :D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 --- Comment #8 from Kevin Suo --- (In reply to Jay Philips from comment #7) @Jay Philipz: Thanks for your reply. > When in the chinese local, the drop down has 15 entries in it Yes, the Simplified Chinese dropdown has more than 8 entries because of my fix to bug 87626 not long time ago. > the drop down has 15 entries in it, while in english it has only 8 entries Some devs told me that the locale file (i18npool/source/localedata/data/*.xml) allows more than 8 entries, so we can add as many entries within LC_NumberingLevel as we want. Not only Simplified Chinese, but also many other locales have more than 8 numbering type entries, Thai for example. And it works perfect when using the "Formatting - Bullets and Numbering", but not with the toolbar icon. > This problem doesnt happen in master with chinese locale > as there are only 8 entries and when you click on them it works just fine. I don't think so. This commit was initially for master, and then backported to 4.4 branch. Version 4.4.0.2 is the first version the fix for bug 87626 takes effect. Master: https://gerrit.libreoffice.org/#/c/13646/ 4.4 branch: https://gerrit.libreoffice.org/#/c/13647/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 Jay Philips changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=85804 --- Comment #7 from Jay Philips --- Seems i was initially mistaken. When in the chinese local, the drop down has 15 entries in it, while in english it has only 8 entries. Entries 9 to 15 all act as if a user was pressing entry number 1. Then you also have Entry 10 which is preselected when no numbering is enabled and pressing it has no affect other than removing numbering if another numbering style is already set. This problem doesnt happen in master with chinese locale as there are only 8 entries and when you click on them it works just fine. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 Jay Philips changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||momonas...@gmail.com Ever confirmed|0 |1 --- Comment #6 from Jay Philips --- Yes there is some problem with the entries displayed in the drop down. It seems when you open it the first time, it shows one set and when you open it again, it shows a different set. @Maxim: Can you have a look at this. :D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 --- Comment #5 from Kevin Suo --- Created attachment 112111 --> https://bugs.freedesktop.org/attachment.cgi?id=112111&action=edit screenshot for Thai locale -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 --- Comment #4 from Kevin Suo --- Created attachment 112110 --> https://bugs.freedesktop.org/attachment.cgi?id=112110&action=edit screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 Kevin Suo changed: What|Removed |Added Hardware|x86-64 (AMD64) |All OS|Linux (All) |All --- Comment #3 from Kevin Suo --- Also reproducible in Win 7 X86, set OS to ALL. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 Kevin Suo changed: What|Removed |Added CC||philip...@hotmail.com --- Comment #2 from Kevin Suo --- Adding Jay Philipz in cc, I assume he worked on the toobar icons improvements and may know sth about this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88290] Numbering toolbar icon not working for certain locales
https://bugs.freedesktop.org/show_bug.cgi?id=88290 Kevin Suo changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=87626 --- Comment #1 from Kevin Suo --- Adding bug 87626 as see also. In bug 87626 I changed the zh_CN locale data (added some LC_NumberingLevel) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
