[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Michael Meeks changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Whiteboard||EasyHack DifficultyBeginner ||SkillCpp TopicCleanup -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #1 from Lovekesh Garg --- Hello ,I want to work on this issue But I need some more clarification. Thanks for your help. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #2 from Soumyadip Ghosh --- Could I get some details on this please ? i want to take up this issue -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #3 from Michael Meeks --- Um; quick reality check - go read about what the C++ "const" keyword means; absent that there is little point asking questions here. For code pointers - cut/paste the 'git grep' command I suggested. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Robinson Tryon (qubit) changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp, ||topicCleanup --- Comment #4 from Robinson Tryon (qubit) --- Migrating Whiteboard tags to Keywords: (easyHack, difficultyBeginner, skillCpp, topicCleanup) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Robinson Tryon (qubit) changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner | |SkillCpp TopicCleanup | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #5 from Dipankar Niranjan --- I have been pondering over this bug for about half a day now. I guess I could do something if I understand what 'when incompatibility ok' means. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #6 from Dipankar Niranjan --- (In reply to Dipankar Niranjan from comment #5) > I have been pondering over this bug for about half a day now. > I guess I could do something if I understand what 'when incompatibility ok' > means. Is doing this, heading in the right direction? http://pastebin.com/q8PxXVKL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #7 from Michael Meeks --- Ah - so, "when incompatibility is ok" - originally at Sun it was not possible to break internal API much at all; this is an artifact from then. Your patch looks fine; can you submit it to gerrit ? =) Beyond that - this deletion listener stuff is a bit of a nightmare, and is (now) un-necessary. Instead we can hold a VclPtr<> reference on the item, and then check if it is disposed after the call instead =) It would be wonderful to start going through the code removing cases where we use deletion listeners =) Would that be interesting to you ? =) Thanks ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #8 from Dipankar Niranjan --- Umm, Since you wanted to stop using deletion listeners, I haven't submitted a patch yet.. I would be interested to look into what you suggest. Please look into this and see if you could help with filling in the gaps and tell me what I have assumed is correct http://pastebin.com/gdWzhGXc And I would need your advice on whether to submit a patch with the "constify" done i.e. the patch from the previous comment (I may not be able to submit any patches for the next couple of days as I'm having trouble sshing to gerrit and am in the process of resolving it) or to complete whatever you suggest and then submit a patch as a whole. Thanks ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #9 from Michael Meeks --- Hi there, > Since you wanted to stop using deletion listeners, I haven't submitted > a patch yet.. Lets get your initial pastebin'd patch included for now =) then we can work on killing this method separately. Will setup a new bug for removing the deletion listeners with a good description in it. Thanks ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Michael Meeks changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||888 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #10 from Dipankar Niranjan --- Hi, I've submitted the small patch. Please review when free. And could you possibly notify when you setup that new bug.. Like I said, I'm interested. Thanks.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Michael Meeks changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Michael Meeks --- Thanks for that - good work; I've merged your commit. I also added this to 'see also' - but here is a link =) it would be great to have help & testing of a series of small patches to solve that bug: https://bugs.documentfoundation.org/show_bug.cgi?id=96888 Thanks ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 --- Comment #12 from Commit Notification --- Ras-al-Ghul committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c29a6e1541f57d2a2ba8372af30e65a2a7b32a9f tdf#89382 - vcl: unwind 'TODO' comment It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89382] vcl: unwind 'TODO' comment ...
https://bugs.documentfoundation.org/show_bug.cgi?id=89382 Commit Notification changed: What|Removed |Added Whiteboard|| target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
