[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 Łukasz Leszko changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |leszko.lu...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #22 from Mike Kaganski --- (In reply to Vaibhav Malik from comment #21) Please use gerrit for discussion of code. Your task is to create a change, even if it doesn't work; it will show your code, and there you may include code comments, or post gerrit comments, explaining your ideas, the specific problems (including specific points, passed values, expected and actual results, call stacks etc.), and would enable review and advices. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #21 from Vaibhav Malik --- (In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I use GDB to debug, but I do not know how to invoke XclExpRoot::IsRelUrl() and lclEncodeDosUrl methods. using "call lclEncodeDosUrl()" won't work until I step into the file "sc/source/filter/excel/xehelper.cxx" can you please provide some hint regarding this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #20 from Vaibhav Malik --- (In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I am working on this bug, so far I could find that: 1. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001\002down\003slave.xls". 2. when XclImpUrlHelper::DecodeUrl is called using mso_master.xls doc, the value of rEncodedUrl is "\001down\003slave.xls" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #19 from Vaibhav Malik --- (In reply to Mike Kaganski from comment #18) > Code pointer: > > The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. > > The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl > (sc/source/filter/excel/xehelper.cxx). > > The latter *unconditionally* tries to store *drive* relative to base, but > *does not* try to save directory path relatively. > > There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, > that does the opposite cf. to lclEncodeDosUrl. > > Basically the task of the easy hack is: check with an Excel-generated XLS > containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; > then implement passing the value of XclExpRoot::IsRelUrl() down to > lclEncodeDosUrl; and then in the latter, implement proper generation of > relative address depending on the passed IsRelUrl value. Sir, I am working on this bug, so far I could find that: 1. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001\002down\003slave.xls". 2. when XclImpUrlHelper::DecodeUrl is called using lo_master.xls doc, the value of rEncodedUrl is "\001down\003slave.xls" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 Mike Kaganski changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp --- Comment #18 from Mike Kaganski --- Code pointer: The path is saved in XclExpSupbook::WriteBody, using maUrlEncoded. The encoding of the URL for storing to BIFF happens in lclEncodeDosUrl (sc/source/filter/excel/xehelper.cxx). The latter *unconditionally* tries to store *drive* relative to base, but *does not* try to save directory path relatively. There is XclImpUrlHelper::DecodeUrl in sc/source/filter/excel/xihelper.cxx, that does the opposite cf. to lclEncodeDosUrl. Basically the task of the easy hack is: check with an Excel-generated XLS containing a relative reference, what arrives to XclImpUrlHelper::DecodeUrl; then implement passing the value of XclExpRoot::IsRelUrl() down to lclEncodeDosUrl; and then in the latter, implement proper generation of relative address depending on the passed IsRelUrl value. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #17 from geeker --- (In reply to geeker from comment #14) > Win7x64 Version: 5.1.1.3 (x64) Build ID: > 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d > Unfortunately, work with external links was broken also in xlsx. Confirming the problem in the Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #16 from QA Administrators --- Dear geeker, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:xls Blocks||109072 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109072 [Bug 109072] [META] XLS (binary) format bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #15 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #14 from geeker--- Win7x64 Version: 5.1.1.3 (x64) Build ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d Unfortunately, work with external links was broken also in xlsx. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #13 from Cor Nouws--- (to be honest, I get the feeling too that links tend to work not always reliable, in the various scenario's.. Have seen, tested and commented quite some issues about it.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #12 from Gunnar Eikman--- If I open the files (unzipping and inspection the content.xml) it turns out that both newly modified files and older ones actually contain "absolute paths". Somehow these must be dealt with when the file is opened, but I can't figure out how. I guess I am suggesting that there has been a change (although I can't figure it out) as to how file paths/names are managed in new LO versions. Possibly the same change fools not only OO 3.4.1 but also Excel... Sounds vague, I guess... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #11 from Gunnar Eikman--- I have a set of Calc (.ods) spreadsheets which I share between a Linux and a Windows computer. There are references between the files, which used to work fine. I upgraded the Linux from Ubuntu from 12.04 to 14.04 and now references across files don't work when I open the files on the Windows computer. The references appear to be "absolute", when using Windows. I see the Linux paths/filenames in cell formulas. However, if I copy the files to a different directory on the Linux machine, Libre Office 4.2.8.2 happily opens them, dealing with the references. On Linux I use Libre Office 4.2.8.2. On the Windows machine I have Open Office 3.4.1. My conclusion: LO 4.2.8.2 and OO 3.4.1 both deal correctly with relative file references, but somehow they don't agree on the file format (like LO 3.5 (?) and OO 3.4.1 used to. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 Cor Nouwschanged: What|Removed |Added CC||c...@nouenoff.nl Hardware|x86-64 (AMD64) |All Version|4.4.0.3 release |3.5.0 release See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||759 --- Comment #10 from Cor Nouws --- version 3.5 per comment 8. Possibly inherited from OOo ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 geeker gj...@mail.ru changed: What|Removed |Added Priority|medium |high --- Comment #9 from geeker gj...@mail.ru --- It's reproduced in Version 5.0.0.5. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from raal r...@post.cz --- Tested now with 4.4.1.2 ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432, win7 and can not confirm. I created new files. Please test with 4.4.1.2, https://www.libreoffice.org/download/libreoffice-fresh/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #6 from geeker gj...@mail.ru --- Created attachment 114468 -- https://bugs.documentfoundation.org/attachment.cgi?id=114468action=edit test with 4.4.1.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #7 from geeker gj...@mail.ru --- (In reply to raal from comment #5) Tested now with 4.4.1.2 ID build: 45e2de17089c24a1fa810c8f975a7171ba4cd432, win7 and can not confirm. I created new files. Please test with 4.4.1.2, https://www.libreoffice.org/download/libreoffice-fresh/ I tested with 4.4.1.2 yesterday. And repeated now (see test with 4.4.1.2 attachment). Can you load your new file? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 raal r...@post.cz changed: What|Removed |Added Priority|high|medium Status|NEEDINFO|NEW OS|Windows (All) |All Severity|major |normal --- Comment #8 from raal r...@post.cz --- I can reproduce with Version: 4.4.3.0.0+ Build ID: 3eba5eb1774ab621a1f0f4dcc7e82cce6c025b0a TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-4-4, Time: 2015-03-27_09:07:12 reproducible with LO 3.5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 raal r...@post.cz changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #3 from geeker gj...@mail.ru --- (In reply to m.a.riosv from comment #2) There is an option for save with relative/absolute paths. Menu/Tools/Options/Load-Save/General - Save URLs relative to file system. Is the option marked? Yes, it's marked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 --- Comment #4 from geeker gj...@mail.ru --- (In reply to raal from comment #1) Please try following: - In down/slave.xls rename name of the sheet Лист1 - new name for example list1. No cyrillic characters. - in lo_master.xls delete all formulas and create new link to slave.xls. Let me know if it works for you and set to bug to unconfirmed. Thank you (ref.85617) No, it don't work -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added CC||mari...@miguelangel.mobi --- Comment #2 from m.a.riosv mari...@miguelangel.mobi --- There is an option for save with relative/absolute paths. Menu/Tools/Options/Load-Save/General - Save URLs relative to file system. Is the option marked? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- Hello geeker, thanks for reporting bug. Please try following: - In down/slave.xls rename name of the sheet Лист1 - new name for example list1. No cyrillic characters. - in lo_master.xls delete all formulas and create new link to slave.xls. Let me know if it works for you and set to bug to unconfirmed. Thank you (ref.85617) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls
https://bugs.documentfoundation.org/show_bug.cgi?id=90299 geeker gj...@mail.ru changed: What|Removed |Added Priority|medium |high Severity|critical|major -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs