[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||103152


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #29 from Commit Notification 
 ---
pasqualm committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a425218aae218356421df9e62bf9dd5d1d809bb=libreoffice-5-1

tdf#90319: make image flipping work when aLinearContext(...) code path chosen

It will be available in 5.1.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Commit Notification  changed:

   What|Removed |Added

 Whiteboard| target:5.2.0   | target:5.2.0
   |target:5.1.0.2  |target:5.1.0.2 target:5.1.4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #28 from Justin L  ---
Created attachment 124167
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124167=edit
screenshot that belonged in comment 22 which documents the problem

confirmed in 12.04 that the bug is resolved now.
confirmed that 16.04 continues to work properly.
Marking as verified: fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

 Attachment #122648|0   |1
is obsolete||
 Attachment #122648|JPG screenshot of   |I must have uploaded the
description|FlipImage_horizontal on |wrong file.  This is not a
   |12.04 LO5.2 |screenshot as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Adolfo Jayme  changed:

   What|Removed |Added

 Attachment #122648|application/x-msdownload|application/pdf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #27 from Commit Notification 
 ---
pasqualm committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e3d634e413abf2b4c2a6c70a87586d8c598054c

tdf#90319: make image flipping work when aLinearContext(...) code path chosen

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #26 from pasqual milvaques  ---
(In reply to Justin L from comment #22)
> > In which version and os do you reproduce the problem? 
> Cinnamon Mint Maya (Ubuntu 12.04) on master (LO 5.2 development)

Justin, please take a look to patch in:
https://gerrit.libreoffice.org/#/c/22753/

to see if it solves the problem with mint 13(or 17 or …), for me it's working

Thanks :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #25 from pasqual milvaques  ---
Problem reproduces in cinnamon mint 17.3 (which is based on ubuntu 14.04). I'm
not sure if in a vanilla ubuntu 14.04 the problem reproduces, I will try to
take a look tomorrow. Anyway I now have a functional development environment in
mint 17.03 so perhaps I could take a deeper look to what is happening there

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #24 from Justin L  ---
(In reply to Justin L from comment #23)
> I compiled on Ubuntu 16.04, and flipping works well - BUT it always takes
> the "else" path 

Somehow I was mistaken - it does NOT always take the else path.  It always does
display properly in 16.04 so marking as resolved/fixed again - I only see the
problem in 12.04 which is nearing the end of its supported life.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #23 from Justin L  ---
I compiled on Ubuntu 16.04, and flipping works well - BUT it always takes the
"else" path (whereas in 12.04 "if" returned true), so my suggestion in Comment
19 still seems valid to force this in all flipped occurrences.  Pasqual can
probably confirm that the ELSE path is always chosen in 14.04 too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #22 from Justin L  ---
Created attachment 122648
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122648=edit
JPG screenshot of FlipImage_horizontal on 12.04 LO5.2

(In reply to pasqual milvaques from comment #21)
> In which version and os do you reproduce the problem? 
Cinnamon Mint Maya (Ubuntu 12.04) on master (LO 5.2 development)

Am export to PDF seems to work properly (it's different from the LO
screenshot), so perhaps this is just a 12.04 visual thing.  There is a similar
sounding bug relating to flipping and LXDE as well.  If my test document works
for you, then it isn't a big deal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #21 from pasqual milvaques  ---
In which version and os do you reproduce the problem? In master it seems solved
in my Linux build but it reproduces in 5.0.4. The patch was ported to 5.1 but
not to 5.0, perhaps that was the problem. I have cherry-picked for 5.0 now 

Additional code changes have been made to the code so in master the patched
BlendBitmap  function seems to not being used anymore, I'm rebuilding 5.0 in my
testing machine to verify the is a change of behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

pasqual milvaques  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #20 from pasqual milvaques  ---
I will take a look to it, thanks for the report :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||jl...@mail.com
   Assignee|pasqual.milvaq...@gmail.com |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

--- Comment #19 from Justin L  ---
potential fix:
if (!bHMirr && !bVMirr && aLinearContext.blendBitmap(
Bitmap::ScopedWriteAccess(aBmp).get(), pBitmapReadAccess.get(),
pAlphaReadAccess.get(), nDstWidth, nDstHeight))

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90319] Image flip vertically or horizontally not working with png files in writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90319

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||610

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs