[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vmik...@collabora.co.uk
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #7 from Michael Stahl  ---
the real question is why is 4.4 not export draw:opacity attribute to go along
with the fill attributes.

for API compatibility, the implementation of old property BackColorTransparency
return 100% if the fill style is bitmap, which is exported as
style:background-transparency="100%".

so for "bitmap" background, it was never the case in older versions that
style:background-transparency="100%" actually *meant* anything - it was always
wrong - the real value was exported on the background-image child element.

therefore the fix for bug 90130 - which is really a fix-up for
4.4.0 - 4.4.3.1 *omitting* draw:opacity attribute - needs to be
restricted not to affect bitmaps.

so there are 3 different bugs here.

fixed on master

thanks Paddy for quickly finding and reporting this bug!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

Michael Stahl  changed:

   What|Removed |Added

   Keywords||bisected
 CC||caol...@redhat.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||130
 Whiteboard||odf

--- Comment #6 from Michael Stahl  ---

this changed with:

commit bc892b04144d82507ccd59953c9f4da357c2e7b4
Author: Caolán McNamara 
AuthorDate: Tue Apr 14 10:14:42 2015 +0100

Related: tdf#90130 gradient transparency goes missing


but it's not clear to me that it's a bug, a stored document from 4.4.2.2
contains this:

  fo:background-color="transparent" style:background-transparency="100%"
draw:fill="bitmap" draw:fill-image-name="Sky"

the properties contain both old style:background-image and new draw:fill*:

  

  

... so reading that and setting it transparent looks like the right
thing to do, question is why does 4.4 store that transparency thing?

LO 4.3 (and OOo 3.3) writes something similar:

  

  


... so the transparency is overridden by the draw:opacity="100%" on the image.

so it's possible that the harmless transparent attributes should not be written
by 4.4 since they're no longer harmless because of the new draw:fill
attributes.  or perhaps that commit was wrong after all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

Paddy Landau  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #5 from Paddy Landau  ---
By the way, as this is a regression, shouldn't the importance be rated as
"high"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

Paddy Landau  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||784

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

--- Comment #4 from Paddy Landau  ---
> I'm guessing other people testing this bug were fixing the transparency by 
> using the sidebar?

In my case, I think that it might have been luck of the draw, as I didn't even
know that you could do it from the tool bar.

If the transparency tab is opened without opening the area tab (e.g. if you
have opened that tab previously), the area won't be changed.

I have just tested and indeed you are right: bug #82784 does confuse the issue
greatly. I shall add these two bugs as "see also" to each other.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

tmacalp  changed:

   What|Removed |Added

 CC||tmac...@gmail.com

--- Comment #3 from tmacalp  ---
Interesting.  This bug appears to affect all bitmaps, even those chosen from
the list.

Also, bug 82784 can add confusion to those testing this bug for those
attempting to fix the 100% transparency in frames with an image set as the
background.  If you use the normal frame properties dialog and visit the Area
tab, the bitmap list will change your custom image to the first item in the
list, "Blank."  At that point, the background really will be white.

I'm guessing other people testing this bug were fixing the transparency by
using the sidebar?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document

2015-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90640

Paddy Landau  changed:

   What|Removed |Added

Summary|Text frame background   |Text frame background
   |graphic set to 100% on  |graphic set to 100%
   |saving a document   |transparency on saving a
   ||document

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs