https://bugs.documentfoundation.org/show_bug.cgi?id=91222
Bug ID: 91222
Summary: VclBuilder constructor cleanup ...
Product: LibreOffice
Version: unspecified
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: michael.me...@collabora.com
The VclBuilder code has a set of nice public symbols, one for each custom
method that can be looked up by the relevant code to create those widgets (cf.
vcl/source/window/builder.cxx).
These are all declared by macros eg.
VCL_BUILDER_FACTORY(FooType)
checkout include/vcl/builderfactory.hxx
But some of these constructor functions are over-complex and we can only
partially macro-ise those eg.
VCL_BUILDER_DECL_FACTORY(SwCaptionPreview)
{
WinBits nBits = 0;
OString sBorder = VclBuilder::extractCustomProperty(rMap);
if (!sBorder.isEmpty())
nBits |= WB_BORDER;
return VclPtr<SwCaptionPreview>::Create(pParent, nBits);
}
It would be great to go over these instances and move these pieces into a
SwCaptionPreview constructor that takes a (VclBuilder::stringmap &rMap)
parameter - meaning we can shrink the above to a new macro:
VCL_BUILDER_FACTORY_CONSTRUCTOR(SwCaptionPreview)
or something =) that is unless Caolan disagrees (?)
Thanks !
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
