[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|bibisected  |bibisected target:5.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #14 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dd971d008780186c88cc33df3610ed8cc9f0a2f4

tdf#92296: Fix off-by-one formatting of text runs on OOXML export

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #13 from Kevin Suo  ---
(In reply to Katarina Behrens (CIB) from comment #11)
Of course you can use it, please go ahead, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #12 from Andras Timar  ---
*** Bug 93115 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #11 from Katarina Behrens (CIB)  ---
@Kevin: The sample document you've posted is actually very useful and I'd like
to use it in an unit (bugfix) test. What it means is that I'll be placed in
LibO git repository. Can I do that?

(I know there are absolutely no confidential or personal data in it, but I
thought I'd ask anyway)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Robert Pollak  changed:

   What|Removed |Added

 CC||robert.pol...@mykolab.com

--- Comment #10 from Robert Pollak  ---
I can reproduce this with LO 5.0.2.2 on German Windows 7 Pro. According to LO's
info dialog, my locale is "en-US (de_AT)".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #8 from Matthew Francis fdb...@neosheffield.co.uk ---
Could be less reproducible than it first appears then, or could just have
missed the target - I'll take a look when I get a minute

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC|nthieb...@gmail.com |yogesh.bhar...@synerzip.com

--- Comment #9 from Matthew Francis fdb...@neosheffield.co.uk ---
The below appears to be the correct commit
Adding Cc: to yogesh.bhar...@synerzip.com; Could you possibly take a look at
this one? Thanks

commit 8865ed2efecd03722d10e522265f31c99b13b2bb
Author: yogesh.bharate001 yogesh.bhar...@synerzip.com
AuthorDate: Mon Apr 27 15:08:16 2015 +0530
Commit: Joren De Cuyper jore...@libreoffice.org
CommitDate: Mon May 11 19:02:45 2015 +

tdf#90812: rPr is not exported after roundtrip.

Problem Description:
XML Difference: In sharedStrings.xml
Original file :
r
  rPr
  sz val=11/
  color rgb=/
  rFont val=Calibri/
  family val=2/
  scheme val=minor/
  /rPr
   tRed/t
/r

Roundtrip file:
r
  tRed/t
/r

rPr is missing in roundtrip file.

Conflicts:
sc/qa/unit/subsequent_export-test.cxx

Change-Id: I79efd0f8f1a735ef7e4ebd3fda220b3e339ea91c
Reviewed-on: https://gerrit.libreoffice.org/15548
Reviewed-by: Joren De Cuyper jore...@libreoffice.org
Tested-by: Joren De Cuyper jore...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

   Keywords||bisected
 CC||fdb...@neosheffield.co.uk,
   ||nthieb...@gmail.com

--- Comment #6 from Matthew Francis fdb...@neosheffield.co.uk ---
(see comment 5)

Adding Cc: to nthieb...@gmail.com; Could you possibly take a look at this one?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #7 from Norbert Thiebaud nthieb...@gmail.com ---
I've checked out 2523972f6a066488c649ab97dcba4f458126f18b

built it.. and ran the scenario..
can't reproduce here...
I did not switch to a Chinese locale though...
is that relevant ? 

in any case 2523972f6a066488c649ab97dcba4f458126f18b is
+++ b/vcl/source/gdi/impimagetree.cxx
@@ -181,7 +181,7 @@ bool ImplImageTree::doLoadImage(OUString const  name,
OUString const  style, B
 }

 if (found)
-maIconSet[maCurrentStyle].maIconCache[name.intern()] =
std::make_pair(localized, bitmap);
+maIconSet[maCurrentStyle].maIconCache[name] =
std::make_pair(localized, bitmap);

 return found;
 }

there is _no_ way that is related with the described problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #1 from Kevin Suo suokunl...@126.com ---
Created attachment 116782
  -- https://bugs.documentfoundation.org/attachment.cgi?id=116782action=edit
the test ods file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #2 from Kevin Suo suokunl...@126.com ---
Created attachment 116783
  -- https://bugs.documentfoundation.org/attachment.cgi?id=116783action=edit
the saved xlsx file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

--- Comment #3 from Kevin Suo suokunl...@126.com ---
Created attachment 116788
  -- https://bugs.documentfoundation.org/attachment.cgi?id=116788action=edit
screenshots showing the difference

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Jacques Guilleron guillero...@aol.com changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #4 from Jacques Guilleron guillero...@aol.com ---
Hello Kevin,

I reproduce with all LO 5 releases  Windows 7 Home premium
Works with LO 4.4.4.2 Build ID: f784c932ccfd756d01b70b6bb5e09ff62e1b3285 so
regression.

Jacques

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92296] Character formating (bold, underline, color etc) corrupted when save as xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92296

Terrence Enger lo_b...@iseries-guru.com changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com
 Whiteboard||bibisected
 OS|Windows (All)   |All

--- Comment #5 from Terrence Enger lo_b...@iseries-guru.com ---
Working in the 50max bibisect repository, I see from `git bisect good` ...

2faf2a5126e3ccf78be3d6619b571358bb7af742 is the first bad commit
commit 2faf2a5126e3ccf78be3d6619b571358bb7af742
Author: Matthew Francis mjay.fran...@gmail.com
Date:   Wed May 27 22:54:13 2015 +0800

source-hash-2523972f6a066488c649ab97dcba4f458126f18b

Bibisect: This commit covers the following irrelevant source commit(s)
cfdd89f10fdc15b36bd0d1023e49ca3752feb51e

commit 2523972f6a066488c649ab97dcba4f458126f18b
Author: Norbert Thiebaud nthieb...@gmail.com
AuthorDate: Sat May 9 19:39:55 2015 -0500
Commit: Caolán McNamara caol...@redhat.com
CommitDate: Sun May 10 19:43:06 2015 +

remove a use of OUString::intern()

maIconCache is defined as a std::unordered_map
'interning' a OUString to give to it as a key seems completely
superfluous since no-one will ever use it by address, even less
compare the address.

Change-Id: Iab5d106d7d51fcdfbd0a0dfd50ae28d686b9b2b7
Reviewed-on: https://gerrit.libreoffice.org/15692
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com

:04 04 ed730dac997bd3b47036945e349d224d12b820ba
d2a7f7d865af57772da4e51f1ba6c7a7cceb7f08 Mopt

and from `git bisect log` ...

# bad: [dda106fd616b7c0b8dc2370f6f1184501b01a49e]
source-hash-0db96caf0fcce09b87621c11b584a6d81cc7df86
# good: [5b9dd620df316345477f0b6e6c9ed8ada7b6c091]
source-hash-2851ce5afd0f37764cbbc2c2a9a63c7adc844311
git bisect start 'latest' 'oldest'
# good: [0c30a2c797b249d0cd804cb71554946e2276b557]
source-hash-45aaec8206182c16025cbcb20651ddbdf558b95d
git bisect good 0c30a2c797b249d0cd804cb71554946e2276b557
# good: [2ce02b2ce56f12b9fcb9efbd380596975a3a5686]
source-hash-17d714eef491bda2512ba8012e5b3067ca19a5be
git bisect good 2ce02b2ce56f12b9fcb9efbd380596975a3a5686
# good: [40875247f0002056effdf6d2fbe43627691cd86c]
source-hash-93f0b14458a618ad575cd446680e5c4aa7d87bdc
git bisect good 40875247f0002056effdf6d2fbe43627691cd86c
# skip: [61f66b1a251477193d796411ca95f50d606ead45]
source-hash-3fd5f8919ec2256c70ff26c14cb9f8065c5cb2f1
git bisect skip 61f66b1a251477193d796411ca95f50d606ead45
# good: [e7374cd735af2344dae55be40946d96633d2f6ee]
source-hash-8a91528a3e03fe6e2923c33327b687ecf57adb0b
git bisect good e7374cd735af2344dae55be40946d96633d2f6ee
# bad: [541837707e7b0c5f5335180de535043c43e78e8d]
source-hash-0811de12ee6727bbb9d4265217833ba02301eed8
git bisect bad 541837707e7b0c5f5335180de535043c43e78e8d
# bad: [2faf2a5126e3ccf78be3d6619b571358bb7af742]
source-hash-2523972f6a066488c649ab97dcba4f458126f18b
git bisect bad 2faf2a5126e3ccf78be3d6619b571358bb7af742
# good: [8f6f05e17a2972f3b9f83bbc4e10231626b44c13]
source-hash-2c70139d6a8d8fabd671455d3edd32117783d4d7
git bisect good 8f6f05e17a2972f3b9f83bbc4e10231626b44c13
# good: [3629c94e7c28b3be63abd20c606ce2928ee00d2b]
source-hash-d133a87c1e518f14b0fa0e0e8e372a9925c55f1a
git bisect good 3629c94e7c28b3be63abd20c606ce2928ee00d2b
# good: [944d3cc98286a9d17d6b400cb180fdcdd41008e3]
source-hash-39707f9448d65ba14e04fc9377f87086dab58e89
git bisect good 944d3cc98286a9d17d6b400cb180fdcdd41008e3
# good: [16429ce8f5cc10184a338003387ab7b375869fc9]
source-hash-892cb24be673e8441a75bdde950c2087a24bdf74
git bisect good 16429ce8f5cc10184a338003387ab7b375869fc9
# good: [a8b54baa305bc4121cd8a059aec583c94c30940f]
source-hash-1f43eab48a0397d9f7c272116aeb150694b1721d
git bisect good a8b54baa305bc4121cd8a059aec583c94c30940f
# good: [56f483752729e9d0061347d5a4b28e23060e3af0]
source-hash-dc6dc631e25b6ad3de5018b9be03b129d40d7375
git bisect good 56f483752729e9d0061347d5a4b28e23060e3af0
# good: [74abe1ef6a9336dcc1ae2291e34a22b9d3b6751f]
source-hash-0b4e3f5ebd2511c7ba39cbcc83d5faddb842404d
git bisect good 74abe1ef6a9336dcc1ae2291e34a22b9d3b6751f
# good: [a5b688ef540d5189edde1faea5d8d64cf777f6da]
source-hash-8908f10fe3b6566db469a1f2bd2674d8d0425165
git bisect good a5b688ef540d5189edde1faea5d8d64cf777f6da
# first bad commit: [2faf2a5126e3ccf78be3d6619b571358bb7af742]
source-hash-2523972f6a066488c649ab97dcba4f458126f18b

I am setting O/S = All and whiteboard bibisected.

-- 
You are receiving this mail because:
You are the assignee