[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #9 from Yousuf (Jay) Philips  ---
(In reply to Olivier Hallot from comment #0)
> The following issues were noted in a roundtrip edition of a help page with
> the latest version of the HelpAuthoring.oxt extension.
> 
> File analyses is (but not bounded to)
> 
> helpcontent2/source/text/shared/optionen/01060500.xhp

Which version number is this, as i'm unable to open that file with the latest
version (3.1.0).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #8 from Jan Holesovsky  ---
Let's split this bug to several ones, and have this as meta-issue for
dependency :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93979

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93981

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93982

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93982

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on|93979, 93981, 93982 |

--- Comment #10 from Jan Holesovsky  ---
I've created bug 93979 for Issue 01, bug 93981 for Issue 03, and bug 93982 for
Issue 04.

I did not create a bug for Issue 02 as Regina's comment 3 says that these
attributes are not necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93979

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580
Bug 93580 depends on bug 93979, which changed state.

Bug 93979 Summary: helpauthoring: Keyword  in  looses initial 
'/'
https://bugs.documentfoundation.org/show_bug.cgi?id=93979

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Jan Holesovsky  changed:

   What|Removed |Added

 Depends on||93981

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||93985

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #7 from Yousuf (Jay) Philips  ---
(In reply to Regina Henschel from comment #4)
> (A) in line 57 in Function SetMetaDataOnSave in module _Main
> -   Path = Right(Path,Len(Path)-Len(sDocRoot))
> +   Path = Right(Path,Len(Path)-Len(sDocRoot)+1)

Yes this was the same solution that i came up with and it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #4 from Regina Henschel rb.hensc...@t-online.de ---
(In reply to Olivier Hallot from comment #0)

 Issue 01:
 
 Keyword filename in meta looses initial slash (/)
 
  filename/text/shared/optionen/01060500.xhp/filename
 
  filenametext/shared/optionen/01060500.xhp/filename

The problem is in Function SetMetaDataOnSave in module _Main.
In string is build in line 57. The variable sDocRoot contains a character '/'
as last character. Therefore subtracting sDocRoot removes the character '/'
from the variable Path. I'm not sure about the solution:

(A) in line 57 in Function SetMetaDataOnSave in module _Main
-   Path = Right(Path,Len(Path)-Len(sDocRoot))
+   Path = Right(Path,Len(Path)-Len(sDocRoot)+1)

or save the HelpPrefix without slash. I don't know what further implications
that will have and where other parts would have to be adapted then.
(B) in line 1057 in Function SetDocumentRoot in module Helpers
-   sHelpPrefix = oFolderDialog.getDirectory + /
+   sHelpPrefix = oFolderDialog.getDirectory

I prefer (A). What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #5 from Joel Madero jmadero@gmail.com ---
Reading comments it seems like this has been confirmed (as the discussion is
about a solution not about the problem itself). Setting to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #6 from Olivier Hallot olivier.hal...@documentfoundation.org ---
(In reply to Regina Henschel from comment #3)
 (In reply to Olivier Hallot from comment #0)
()
 
 Therefore the extension does it right, to remove both attributes. Perhaps
 these attributes should be removed in all help files.

Right, so since this is innocuous, let is stay as is for later cleanup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

Regina Henschel rb.hensc...@t-online.de changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel rb.hensc...@t-online.de ---
(In reply to Olivier Hallot from comment #0)

 Issue 02:
 
 Attribute l10n and oldref in paragraph deleted.
 
 Note: this may be irrelevant or deprecated.

Read in table Attributes in section Paragraphs on page 58 in
OOo2HelpAuthoring.pdf.

The attribute 'oldref' can surely be removed totally. It is not required and
the comment says This contains the reference number used by the old help files
and is only used for migration purposes. and migration is finished long ago.

The attribute 'l10n' is described with required in that document, but when
you look at the current /help/helpers/xmlhelp.dtd, it is actually not required.
It has the same comment, so I think it can be removed too.

Therefore the extension does it right, to remove both attributes. Perhaps these
attributes should be removed in all help files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #1 from Olivier Hallot olivier.hal...@documentfoundation.org ---
Issue 03:

In another file(*) the paragraph attribute localize (=true/false) is deleted.
This affects translations, and will pollute Pootle server with useless
translations (e.g. translate keywords, numbers, etc...)

(*) helpcontent2/source/text/scalc/01/statistics.xhp

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93580] [HELPAUTHORING] Issues in roundtrip Helpcontent2 edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93580

--- Comment #2 from Olivier Hallot olivier.hal...@documentfoundation.org ---
Issue 04:

In the same file as comment#1 the sections with id=howtoget were renamed
SectionN, where N is a number 2.

This is probably to keep section id's uniqueness inside the file.

But we loose the To access this command sections, except the first
occurrence.

Manually naming id's as howtoget in the xhp file does work and the To access
this command... sections are displayed.

But I don't know if that obfuscate another issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs