[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #24 from Mike Kaganski  ---
So: you are able to open the file, *if* you open it using an *explicitly
selected* DOCX filter in the Open dialog.

Why it fails when opened normally:
1. It uses a normal auto-detect procedure.
2. In it, it iterates all filters, asking each to try to detect the file.
3. In the list, DOCX filters happen to come prior to ODF ones ...
4. But DOCX filters, when encountering the ZIP error, fail silently
5. While ODF ones, when see the same ZIP error, produce the warning, and then
proceed with the procedure from comment 23 - which is described by "We don't do
any type detection on broken packages (f.e. because it might be impossible),
so for repairing we'll use the requested type, which was detected by the flat
detection" comment there.

Which makes LibreOffice use an ODF filter unconditionally on this file, which
finally expectedly fails elsewhere.

The problem is: we need to handle the ZIP error early, and introduce the repair
mode early, still keeping the autodetection with it. Because it won't help to
allow DOCX filters do the same as ODF, which would then disallow broken ODF
opening - DOCX would intercept them then, and the problem would be reversed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #23 from Mike Kaganski  ---
(In reply to Mike Kaganski from comment #22)
> The missing bit is to make sure that, when such a situation is detected
> during the load, and a warning is shown to the user asking to try to
> *repair*, we don't switch to the recovery mode.

Hmm. filter/source/storagefilterdetect/filterdetect.cxx has the code to do
exactly that [1]; and so, it is the wrong implementation (or a breakage) of
what was implemented in 426a2f22678f89706b4db474243ab27b4a4d6c06.

[1]
https://opengrok.libreoffice.org/xref/core/filter/source/storagefilterdetect/filterdetect.cxx?r=b1560344#121

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=104759

--- Comment #22 from Mike Kaganski  ---
Since commit fa66eeb587f11bea88ab5950ffd94aee221d6b31, there is a "recovery
mode" in ZIP package, triggered by "RepairPackage" media descriptor property
[1].

Since commit 426a2f22678f89706b4db474243ab27b4a4d6c06 (for #i104759#), this
mode also handles the backslashes in packages (it is done explicitly to handle
this problem).

The missing bit is to make sure that, when such a situation is detected during
the load, and a warning is shown to the user asking to try to *repair*, we
don't switch to the recovery mode.

[1]
https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1document_1_1MediaDescriptor.html#ab5ae6f2c9a82bcb8f006f4b46fee1691

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #21 from petur  ---
As per request, just verified that the issue is still present, though I have
lately not received any such problematic documents do there is a slight chance
that Microsoft has changed something on their end.

However, the file I originally included with this report still fails to open

Tested on a fully updated Debian Sid with:

Version: 7.5.8.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: nl-BE (en_GB.UTF-8); UI: en-GB
Debian package version: 4:7.5.8-1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2023-11-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #20 from QA Administrators  ---
Dear petur,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2021-11-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #19 from Kevin Suo  ---
As explained in https://bugs.documentfoundation.org/show_bug.cgi?id=97379#c9
the code pointer would be in function OStorageHelper::IsValidZipEntryFileName()
in comphelper/source/misc/storagehelper.cxx:536

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2021-11-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Kevin Suo  changed:

   What|Removed |Added

 CC||david.keller...@gmail.com

--- Comment #18 from Kevin Suo  ---
*** Bug 97379 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error, backslash "\" as filename separator)

2021-11-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Kevin Suo  changed:

   What|Removed |Added

Summary|FILEOPEN: DOCX - Specific   |FILEOPEN: DOCX - Specific
   |file reported as corrupted  |file reported as corrupted
   |(openable in MSO but not in |(openable in MSO but not in
   |other programs because of   |other programs because of
   |unzip error)|unzip error, backslash "\"
   ||as filename separator)

-- 
You are receiving this mail because:
You are the assignee for the bug.