[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 steve -_- changed: What|Removed |Added Status|RESOLVED|VERIFIED Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | --- Comment #11 from steve -_- --- Maxim, thanks a lot for your quick fix. Verified with Version: 5.2.0.0.alpha0+ Build ID: c995196ff0e9f7041b03fc513d703d6e60b8c867 CPU Threads: 8; OS Version: -; UI Render: default; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-01-12_23:55:31 Locale: de-DE (de.UTF-8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 Maxim Monastirsky changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Maxim Monastirsky --- Hope that's fine now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 --- Comment #9 from Commit Notification --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cbd483211e1ac9d9e724b5ba3e3e38a0c5abe55c tdf#96875 Make OS X native context menus compatible It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 Commit Notification changed: What|Removed |Added Whiteboard|| target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 --- Comment #8 from Maxim Monastirsky --- (In reply to Maxim Monastirsky from comment #7) > Oddly the text is still missing - although AquaSalMenu::SetItemText > seems to be called with the right strings. So need to investigate more. Think I found it: AquaSalMenu::ShowNativePopupMenu is creating a copy of the NSMenu, so most likely AquaSalMenu::SetItemText is modifying the wrong NSMenu instance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96875] Submenus of MenuBarManager based context menus don't work (OS X native menus only)
https://bugs.documentfoundation.org/show_bug.cgi?id=96875 Maxim Monastirsky changed: What|Removed |Added Component|Calc|graphics stack Version|unspecified |5.2.0.0.alpha0+ Master Summary|missing menu options for|Submenus of MenuBarManager |"Paste Only" (OS X only)|based context menus don't ||work (OS X native menus ||only) --- Comment #7 from Maxim Monastirsky --- What happened recently is the switch to MenuBarManager for handling these menus. MenuBarManager sets the text/select handler when the submenu activates - in MenuBarManager::Activate, but it's never called. The solution is apparently to adapt menuNeedsUpdate delegate (vcl/osx/salnsmenu.mm#37) to call Menu::Activate, which indeed makes these menu items work when clicking them. Oddly the text is still missing - although AquaSalMenu::SetItemText seems to be called with the right strings. So need to investigate more. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
