[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||0198 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 sam tygier changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #27 from sam tygier --- I opened bug 100198 for the underlying issue, so we can close this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #26 from Xisco Faulí --- I'd rather to close this one and open a new one, but that's just my 2 cents -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #25 from sam tygier --- There is still an underlying issue that is not fixed (style resolution is sometimes (maybe always) wrong in some cases). The merged patch just means that we don't crash in that case (also reduces unneeded work). So it would be good to have real fix, that works without the current patch, even though I think the current patch should remain. I have test case in progress to show the wrong style attributes being picked, and I suspect that a sensible solution that passes the test probably resolves the underlying issue. So, do we continue that work here (as per comment 19), or leave this bug for the crash, and start a new bug for the deeper issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #24 from Caolán McNamara --- can we close this as fixed now ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #23 from Commit Notification --- Sam Tygier committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=08c8d094390c7ccedde7d9c04c503a62ed907ae2&h=libreoffice-5-2 tdf#4 Avoid invalid access by reusing getFontFamily() result It will be available in 5.2.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Commit Notification changed: What|Removed |Added Whiteboard|target:5.3.0 target:5.1.5 |target:5.3.0 target:5.1.5 ||target:5.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Commit Notification changed: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:5.1.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #22 from Commit Notification --- Sam Tygier committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e687739eb4849014f7f2657e94d8ab67e4d74625&h=libreoffice-5-1 tdf#4 Avoid invalid access by reusing getFontFamily() result It will be available in 5.1.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #21 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9bf1dac4be55f8591d5fd2b8aa93c9369191c02c tdf#4: Add unittest It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #20 from Commit Notification --- Sam Tygier committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=68ccab350ca5b907f185c729e94a14df15fedc23 tdf#4 Avoid invalid access by reusing getFontFamily() result It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Commit Notification changed: What|Removed |Added Whiteboard||target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #19 from Aron Budea --- I thought about what should happen with this report after the fix is in, and suggest to keep it open with the specific guide for the developer to temporarily undo the fix in their system, take care of the underlying issue until the crash is gone, and publish their fix (while keeping Sam's fix as well). It's a bit inconvenient, but the steps are straightforward, and it won't get forgotten. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #18 from Xisco Faulí --- Hi Armin, Just for the record, your commit also introduced bug 99115, which looks to be related to the css style hierachy too -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Armin Le Grand (CIB) changed: What|Removed |Added Assignee|samtyg...@yahoo.co.uk |libreoffice-b...@lists.free ||desktop.org --- Comment #17 from Armin Le Grand (CIB) --- Hi, I will try to keep an eye on thhis one, it seems that the orig merge caused conflicts and that it was merged incomplete/uncorrect - I'll have to check what exactly I'd done there. I remember that it was about styles support, demanded/requested by Regina (who is already on CC)... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Xisco Faulí changed: What|Removed |Added CC||aniste...@gmail.com Assignee|libreoffice-b...@lists.free |aniste...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #9 from sam tygier --- Without that commit the "*" selector is not being used, so the bug would not be triggered. In the process of debugging this i'd like to write some tests, but I am having trouble with the "assertXPath()" method in SvgImportTest. Is there a way to show the xmlDocPtr so that I can work out what the paths should be for a given svg file? I keep hitting "In <>, XPath '/primitive2D/transform/text' number of nodes is incorrect" messages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 raal changed: What|Removed |Added Keywords||bibisected, bisected CC||armin.le.gr...@me.com, ||r...@post.cz --- Comment #8 from raal --- This seems to have begun at the below commit. Adding Cc: to Armin ; Could you possibly take a look at this one? Thanks 1014698a0bea59d60f4e092c7dbd35a2e1473371 is the first bad commit commit 1014698a0bea59d60f4e092c7dbd35a2e1473371 Author: Matthew Francis Date: Sun Mar 15 03:52:44 2015 +0800 source-hash-e17a730c0076b10678c860ae3285bc8a98282415 commit e17a730c0076b10678c860ae3285bc8a98282415 Author: Armin Le Grand AuthorDate: Thu Oct 9 15:03:55 2014 + Commit: Caolán McNamara CommitDate: Thu Oct 9 17:30:13 2014 +0100 Resolves: #i125329# Take care of Css selector '*' (cherry picked from commit f73813d9e0f13e3bdf735f8626dbf540701a1900) Conflicts: svgio/source/svgreader/svgnode.cxx Change-Id: Ifc5df8bed47d69709ef590eced19635b6b9580d0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode:: createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 sam tygier changed: What|Removed |Added Attachment #125249|0 |1 is obsolete|| --- Comment #7 from sam tygier --- Created attachment 125255 --> https://bugs.documentfoundation.org/attachment.cgi?id=125255&action=edit test2.svg I uploaded the wrong test2.svg. here is the crashy version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #6 from Regina Henschel --- Created attachment 125251 --> https://bugs.documentfoundation.org/attachment.cgi?id=125251&action=edit 4 testfiles Your test2.svg does not crash for me. But you are right in your analysis, the problem is the combination of the * in the style element and a font-family rule on the parent. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #5 from sam tygier --- Created attachment 125249 --> https://bugs.documentfoundation.org/attachment.cgi?id=125249&action=edit test2.svg Here as more minimal example file. I think the required conditions are: A text element, with a parent which has a style attribute containing a font, and a top level css style element with a "*" rule that does not contain font. In this case I thing the first call to getFontFamily() gives the parent's font, and the second call gives the empty list from the style element. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Aron Budea changed: What|Removed |Added Keywords||filter:svgInsert Severity|normal |major --- Comment #4 from Aron Budea --- (In reply to sam tygier from comment #2) > This is the quick fix, but maybe a more in depth approach is needed. Yes, I agree. While the patch solves the crash, the bug that caused two consecutive getFontFamily() calls to return different font families would remain hidden, and might cause issues elsewhere. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 Aron Budea changed: What|Removed |Added Keywords||patch, regression Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Version|5.0.6.2 release |4.4.0.3 release Ever confirmed|0 |1 --- Comment #3 from Aron Budea --- Thanks for the bug report and the analysis, Sam. Reproduced in current versions, and in 4.4.0.3, not reproduced in 4.3.0.4, so it's a regression. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #2 from sam tygier --- Created attachment 125234 --> https://bugs.documentfoundation.org/attachment.cgi?id=125234&action=edit 0001-tdf-4-Avoid-invalid-access-by-reusing-getFontFam.patch This is the quick fix, but maybe a more in depth approach is needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99994] Crash on insert SVG file svgio::svgreader::SvgCharacterNode::createSimpleTextPrimitive
https://bugs.documentfoundation.org/show_bug.cgi?id=4 --- Comment #1 from sam tygier --- The bug occurs in SvgCharacterNode::createSimpleTextPrimitive() in the section: OUString aFontFamily = rSvgStyleAttributes.getFontFamily().empty() ? OUString("Times New Roman") : rSvgStyleAttributes.getFontFamily()[0]; The second clause gets called, and tries to access the zeroth element of an empty vector. The "empty()" test is not effective at preventing this as getFontFamily() returns a different vector on the second call. (Fun Heisenbug as putting "cout << rSvgStyleAttributes.getFontFamily().size()" or similar above changes the behaviour.) The problem is that getFontFamily() can call SvgStyleAttributes::setCssStyleParent() and so the style can be changed. The simple fix is to just reuse the result from the first call to getFontFamily(). That way the test is effective and preventing the invalid access. I guess proper fix is to make getFontFamily() deterministic. I have not yet quite understood the code well enough to understand how. Perhaps it needs to be made so that that all the style resolution that can call the the 'set' methods occurs before createSimpleTextPrimitive() gets called. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs