[Libreoffice-qa] Calc Import Unit Tests - Financial Functions
Hello, See the attached two files: functions.ods and financial-functions.csv. I extended functions.ods with tests (normal values only) for every financial function except OPT_BARRIER and ODDFYIELD. I don't fully understand OPT_BARRIER, so I will write a test for it after further study. ODDFYIELD has a bug inherited from AOO Bugzilla #92177. financial-functions.csv contains the expected results. I welcome any feedback - positive or constructive criticism. I license this content under MPL/LGPLv3+. --Ken Biondi kenbio...@hotmail.com financial-functions.csv Description: Binary data functions.ods Description: Binary data ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Calc Import Unit Tests - Financial Functions
Hey Ken, On Sun, Feb 16, 2014 at 2:25 AM, Ken Biondi wrote: > Hello, > > See the attached two files: functions.ods and financial-functions.csv. > > I extended functions.ods with tests (normal values only) for every > financial function except OPT_BARRIER and ODDFYIELD. I don't fully > understand OPT_BARRIER, so I will write a test for it after further study. > ODDFYIELD has a bug inherited from AOO Bugzilla #92177. > > financial-functions.csv contains the expected results. > > I welcome any feedback - positive or constructive criticism. > > I license this content under MPL/LGPLv3+. > > Sorry that I missed that mail. I'm going to review the patch and integrate it. Thanks for your work. Are you interested in continuing with more functions? Regards, Markus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Calc Import Unit Tests - Financial Functions
> Date: Thu, 27 Feb 2014 17:00:20 +0100 > > Sorry that I missed that mail. I'm going to review the patch and > integrate it. > > Thanks for your work. Are you interested in continuing with more functions? > > Regards, > Markus Hi Markus, Yes, I plan to continue with more functions. I'll wait for your feedback to make sure I'm doing this correctly. Cheers, Ken ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Calc Import Unit Tests - Financial Functions
Hey, On Thu, Feb 27, 2014 at 8:19 PM, Ken Biondi wrote: > > > Date: Thu, 27 Feb 2014 17:00:20 +0100 > > > > Sorry that I missed that mail. I'm going to review the patch and > > integrate it. > > > > Thanks for your work. Are you interested in continuing with more > functions? > > > > Regards, > > Markus > > > Hi Markus, > > Yes, I plan to continue with more functions. I'll wait for your feedback > to make sure I'm doing this correctly. > > Cheers, > > Ken I finally managed to get to this patch. It has been integrated after some struggles. I missed that the file contains windows line endings but after fixing that it works now like a charm. Thanks a lot for your patch. I hope to see more of them in the future. Regards, Markus http://cgit.freedesktop.org/libreoffice/core/commit/?id=35f39285991043a70f65c796c38624c9c51ec4b1 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
