[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Joel Madero changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #1 from Joel Madero --- Valid enhancement request. I don't see this being very easy to accomplish but if you have code pointers maybe we could turn it into an easy hack. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Yousuf Philips (jay) changed: What|Removed |Added Keywords|needsUXEval |needsDevEval, topicUI CC||philip...@hotmail.com --- Comment #2 from Yousuf Philips (jay) --- Definitely worth doing, as the user shouldnt be automatically jumped out of the application because no local help is installed. Would be useful to have different text strings for different OSes. @Samuel: You interested in working on this? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #3 from Adolfo Jayme --- (In reply to Yousuf Philips (jay) from comment #2) > Definitely worth doing, as the user shouldnt be automatically jumped out of > the application because no local help is installed. Many of today’s applications do exactly that (including every single bundled program in Windows, such as Notepad), and I don’t see anybody complaining. I don’t think people are confused because they click “Help” in a certain program and they get redirected to their browser. It’s common enough. That said, I definitely like how GIMP handles this with its (brief!) interstitial dialog, so +1. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Katarina Behrens (CIB) changed: What|Removed |Added Keywords|needsDevEval|difficultyBeginner, ||easyHack, skillCpp --- Comment #4 from Katarina Behrens (CIB) --- A good easy hack candidate The code opening either help window or online help is in sfx2/source/appl/sfxhelp.cxx, in particular SfxHelp::Start_Impl function. Use imp_hasHelpInstalled function to check if help is installed, or simply plug your code in where this function is already called. For the question dialog implementation, you may want to use MessageBox class (vcl/source/windows/layout.cxx), or inherit from it to create your own dialog class -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #5 from Katarina Behrens (CIB) --- And to avoid scope-creep, I'd initially only implement this as binary choice [Read help online] [Cancel] Downloading local help packages is different process on different platforms, thus challenging to implement and remembering user's choice is also non-trivial task -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Yousuf Philips (jay) changed: What|Removed |Added Blocks||102019 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102019 [Bug 102019] [META] Dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #6 from Vidhey PV --- I am new and interested in contributing to libreoffice and also interested to resolve this easyhack. but i have a question: is there any wiki or some doc,where I can find the logic of the code or the pointers related to the code??? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Vidhey PV changed: What|Removed |Added CC||vidhe...@gmail.com Assignee|libreoffice-b...@lists.free |vidhe...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Vidhey PV changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #7 from jan iversen --- (In reply to Vidhey PV from comment #6) > I am new and interested in contributing to libreoffice and also interested > to resolve this easyhack. > but i have a question: > is there any wiki or some doc,where I can find the logic of the code or the > pointers related to the Welcome have a look at comment #4 that is the code pointer you search for. You might also want to look at https://wiki.documentfoundation.org/Development/GetInvolved which help you get started. rgds jan i -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #8 from Vidhey PV --- I looked into sfx2/source/appl/sfxhelp.cxx and SfxHelp::Start_Impl function.I tried to understand it ,but I was not able to understand "what the structs used in the function does and some functions used in the Start_impl does".I think the comments are not sufficient enough to understand the code.Is there any doc or READMe where all the structs used or what a function does is explained??? ---Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #9 from Vidhey PV --- This functionality, is this mostly needed on linux or windows?? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #10 from jan iversen --- A polite ping, still working on this issue ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #11 from Katarina Behrens (CIB) --- So 1st patch is here: https://gerrit.libreoffice.org/#/c/31385/ and it works Next steps: * Tweak helpmanual.ui to include checkbox (see eg. sfx2/uiconfig/ui/alienwarndialog.ui as for how) * Introduce a new boolean configuration variable: for example org.openoffice.Office.Common.Misc.AskOpenOnlineHelp (it'll then come to officecfg/registry/data/org/openoffice/Office/Common.xcu) * Write a class deriving from MessageDialog (see eg. sfx2/source/dialog/alienwarn.cxx as for how) that'll include code setting check box on/off * Read configuration and set checkbox state, like for example here: http://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/templdlg.cxx#686 * On disposing the dialog, write the configuration depending on the state of checkbox, like for example here: http://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/templdlg.cxx#2029 That's it -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #12 from Katarina Behrens (CIB) --- And I forgot: in sfx2/source/app/sfxhelp.cxx, if this AskShowOnlineHelp variable is set to false, no dialog should be opened, so some conditionals need to be added there as well -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #13 from Siddhartha Gairola --- Could you please explain the second point in your second last comment. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #14 from Siddhartha Gairola --- (In reply to Siddhartha Gairola from comment #13) > Could you please explain the second point in comment 11. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Commit Notification changed: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #15 from Commit Notification --- pv2k committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a41cef3f9972a88de378a1117697199dbf1d436 tdf#103391: ask user whether to open online help It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #16 from jan iversen --- Is this solved ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #17 from Heiko Tietze --- Created attachment 130364 --> https://bugs.documentfoundation.org/attachment.cgi?id=130364&action=edit LibreOffice dialog Function wise the issue is fixed. The design has room for improvements. Version: 5.4.0.0.alpha0+ Build ID: 229d98e94a5d6b350c4d5fd5469be8e4a260a40c CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Yousuf Philips (jay) changed: What|Removed |Added CC|libreoffice-ux-advise@lists |f...@libreoffice.org, |.freedesktop.org|vstuart.fo...@utsa.edu --- Comment #18 from Yousuf Philips (jay) --- (In reply to Heiko Tietze from comment #17) > Created attachment 130364 [details] > LibreOffice dialog > > Function wise the issue is fixed. The design has room for improvements. Yes the sentence has room for improvement. @Stuart, @Adolfo: Any suggestions? Also it might be nice if there were a third button which would link to how to install local help, as the behaviour would be different on different OSes. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 jan iversen changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #21 from Heiko Tietze --- (In reply to Adolfo Jayme from comment #20) > I fixed the spacing and added a title and secondary text; please review. > https://gerrit.libreoffice.org/33103 Can you supply a screenshot? Makes it easier to review here. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #22 from Katarina Behrens (CIB) --- > Also it might be nice if there were a third button which would link to how > to install local help, as the behaviour would be different on different OSes. Installing any additional software in multi-architecture, multi-platform code is a HARD problem. This bug, however, is an easy hack ... I for sure don't have to (wo)mansplain what that means. I explicitly prevented the easy hacker from adding such a button, this is no way a task for an easy hack => so please open a new ticket -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #23 from Adolfo Jayme --- Created attachment 130524 --> https://bugs.documentfoundation.org/attachment.cgi?id=130524&action=edit gerrt#33103 looks like this -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #24 from Heiko Tietze --- (In reply to Adolfo Jayme from comment #23) > Created attachment 130524 [details] > gerrt#33103 looks like this Thanks. Now it doesn't look like avoiding good design by all means. But the dialog has still room for improvement when you compare it with the GIMP example. My suggestion is to be more verbose like "You may either install the offline version from our website or via repository depending on your operating system. Or read the online help in your default Internet browser." (three lines of text just looks better), and to have a friendly image on the left, a big LibreOffice logo perhaps. If that's too much you could 'move' the subtext a little bit upward as it is somewhat mounted to the buttons right now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Vidhey PV changed: What|Removed |Added Assignee|vidhe...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Heiko Tietze changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #25 from Heiko Tietze --- >2017-02-09 11:09:22 UTC Assignee vidhe...@gmail.com -> >libreoffice-b...@lists.freedesktop.org Hope you didn't get my reply wrong. Of course the dialog is much better than before, only nitpicking. I'm fine with setting it as resolved/fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 --- Comment #26 from Commit Notification --- Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=170b4f451d752d92dd56880a04d64ebad5b165a4 tdf#103391 Add missing title and secondary text to message box It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Adolfo Jayme changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Yousuf Philips (jay) changed: What|Removed |Added Blocks|102019 |106040, 112521 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102019 [Bug 102019] [META] Dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=106040 [Bug 106040] [META] Help bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=112521 [Bug 112521] [META] Message box dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 103391] Show dialog when no local help is installed
https://bugs.documentfoundation.org/show_bug.cgi?id=103391 Yousuf Philips (jay) changed: What|Removed |Added Blocks|106040, 112521 |114957 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106040 [Bug 106040] [META] Help bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=112521 [Bug 112521] [META] Message box dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114957 [Bug 114957] [META] Help not installed dialog box bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
