[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement Keywords|needsUXEval | Ever confirmed|0 |1 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| --- Comment #11 from Heiko Tietze --- We discussed the idea in the design meeting. There is no objection to have icons next to the radio buttons and the change is welcome. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #10 from Heiko Tietze --- (In reply to Maxim Monastirsky from comment #8) > Note that for gtk3 we don't follow the system settings at all, so you won't > see any icons in menus unless explicitly enabled under Tools > Options... Automatic is a scam :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261
--- Comment #7 from andreas_k ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Maxim Monastirsky from comment #4)
> > As said, that's *not* the case in e.g. gtk3 where the context menu shows an
> > icon *and* a checkbox.
>
> Side note: on my LXQt desktop with Breeze as Gtk2/3 theme I don't get icons
> and radio buttons neither with SAL_USE_VCLPLUGIN=gtk nor gtk3 (show icons is
> enabled in KDE settings > widget style on gnome apps). Icons are shown
> ("Edit Styles" for example) at least with gtk2.
>
> Haven't compiled for qt5 since a while.
there is an setting for show icons by default gtk3 didn't show icons (which
will follow in another bug report)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261
--- Comment #8 from Maxim Monastirsky ---
(In reply to andreas_k from comment #5)
> can we show both radio button and icon.
Yes, e.g. take a look at View > Normal menu item.
(In reply to Heiko Tietze from comment #6)
> Side note: on my LXQt desktop with Breeze as Gtk2/3 theme I don't get icons
> and radio buttons neither with SAL_USE_VCLPLUGIN=gtk nor gtk3 (show icons is
> enabled in KDE settings > widget style on gnome apps).
Note that for gtk3 we don't follow the system settings at all, so you won't see
any icons in menus unless explicitly enabled under Tools > Options...
> Icons are shown
> ("Edit Styles" for example) at least with gtk2.
Are you talking about the main menu here? Because the context menu does show
the icons for me. And the main menu is expected to not show icons currently, as
that's what this bug is discussing (the reason is that the main menu uses
different commands than the context menu, e.g. .uno:DefaultCharStyle vs
.uno:StyleApply?Style:string=StandardFamilyName:string=CharacterStyles).
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #9 from andreas_k --- Created attachment 149148 --> https://bugs.documentfoundation.org/attachment.cgi?id=149148=edit DefaultCharStyle I would use menu:id=".uno:DefaultCharStyle" menu:style="radio" first selected item in the screenshot the the one with radio button and icon. than I would change the behaviour also in context menu and calc, ... whereever styles was used. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261
--- Comment #6 from Heiko Tietze ---
(In reply to Maxim Monastirsky from comment #4)
> As said, that's *not* the case in e.g. gtk3 where the context menu shows an
> icon *and* a checkbox.
Side note: on my LXQt desktop with Breeze as Gtk2/3 theme I don't get icons and
radio buttons neither with SAL_USE_VCLPLUGIN=gtk nor gtk3 (show icons is
enabled in KDE settings > widget style on gnome apps). Icons are shown ("Edit
Styles" for example) at least with gtk2.
Haven't compiled for qt5 since a while.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #5 from andreas_k --- can we show both radio button and icon. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #4 from Maxim Monastirsky --- (In reply to andreas_k from comment #3) > As I don't understood why the styles commands should have an radiobutton, It was requested in Bug 106999 to have an indication when a style entry is active. > and show radiobutton more like an hack is (you have to define it in > addition), If you don't define a radio button you get a checkbox, which doesn't fit as styles are mutually exclusive. > I'm for remove the hack and show the icon only, like we have it > in the context menu. As said, that's *not* the case in e.g. gtk3 where the context menu shows an icon *and* a checkbox. Style commands have either a radio button or a checkbox, and there's no way around it (except reverting the fix of Bug 106999, but that will also affect the toolbar). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #3 from andreas_k --- As I don't understood why the styles commands should have an radiobutton, and show radiobutton more like an hack is (you have to define it in addition), I'm for remove the hack and show the icon only, like we have it in the context menu. But Maxim is true it should be consistent. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 --- Comment #2 from Maxim Monastirsky --- (In reply to Heiko Tietze from comment #1) > Radio buttons are easier to recognize. But IIRC there was also a bug. Maxim, > your memory is more capable... :-) No bug that I'm aware of. Only that there's a difference in how this case of a radiobutton+icon is shown across different platforms. For platforms with native menus (gtk3, qt5, macOS), the radio button and the icon will be shown *both*, next to each other. While for other platforms only the icon will be shown, only that it will have a frame around it when that radio button is active. And we already show icons for styles in the context menu (except that the context menu use checkboxes instead of radio buttons, which probably should be corrected), so that's a pure UX question whether we should do the same for the main menu. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 123261] Styles Menubar show icons
https://bugs.documentfoundation.org/show_bug.cgi?id=123261 Heiko Tietze changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||momonas...@gmail.com --- Comment #1 from Heiko Tietze --- (In reply to andreas_k from comment #0) > In the (styles) toolbar we show icons for the different styles, why we don't > show the icons in the menubar? Radio buttons are easier to recognize. But IIRC there was also a bug. Maxim, your memory is more capable... :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
