[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has "Record Changes" (Track Changes) options

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47677

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||83946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #37 from Joel Madero jmadero@gmail.com ---
FIXED but there is room for improvement that should be reported in a new bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Qubit qu...@runcibility.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jmadero@gmail.com
   |desktop.org |
 CC||qu...@runcibility.com

--- Comment #36 from Qubit qu...@runcibility.com ---
This bug is in 'ASSIGNED' state but not actually assigned to anyone...

Assigning to Joel (as that appears to make the most sense)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|ProposedEasyHack|ProposedEasyHack
   ||target:4.2.0

--- Comment #35 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Joel Madero committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=686ab95e97e3a432f88ae30b8ad6eed1b2b4

fdo#47677 - Track Changes Toolbar



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #33 from Michael Meeks michael.me...@collabora.com ---
Hi Joel - I couldn't see your commit :-) is it stalled in gerrit or something ?
- the feature freeze is looming for 4.2 and I'd love to get this one in...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #34 from Joel Madero jmadero@gmail.com ---
Well, that's interesting ;) I'll ping you on IRC to figure out how to get to it
- I submitted it with one of the git GUI's for the first time - wonder if
something wacky happened

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jmadero@gmail.com
   |desktop.org |

--- Comment #32 from Joel Madero jmadero@gmail.com ---
So I've made a commit on this but several things still need done - I am going
to open new reports for each:

1. Track changes for Spreadsheet (this one only encompasses Writer which seemed
to be the most natural)

2. New uno commands for Accept All and Reject All

3. Ideally the accept and reject buttons would automatically select the
next word (currently you have to click on the word and then you can either
accept or reject the change)

That being said, it's a start

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #31 from Zeki Bildirici kobz...@gmail.com ---
(In reply to comment #24)
Hi,
 That extension does actually do everything you're looking for - I wonder if
 we can just incorporate it into our code -
 http://extensions.libreoffice.org/extension-center/review-toolbar/
 pscreleasefolder.2011-12-03.6583332356/201204.12.0.1

This extension is very useful and the functions are satisfying but i think
-because of being crucial functions on review process- having Compare Document
and Merge Document functions in this toolbar will be great.

Hope to have this soon.

Best regards,
Zeki

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #29 from Michael Meeks michael.me...@novell.com ---
Hi Joel - really looking forward to having this; do you have a patch ? :-) I'd
love to read it over and/or get it polished up  merged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 CC||cl...@cup.uni-muenchen.de

--- Comment #25 from Michael Meeks michael.me...@novell.com ---
I'd love to get that functionality included. I'd have this set of actions
there:

+ re-write as C++:
++ so it won't impact startup-performance (extensions do sadly)
++ so we can include a sidebar pane / area for this
+ get it MPLv2 licensed

Otherwise it looks like a sexy feature to add; I'd love it as a stock toolbar
that automatically shows up for documents with red-lining enabled :-)

Who is the author ? Cloph - any chance you can dig that out of plone ? also
re-writing this as a built-in toolbar should be an easy-hack I think - with
enough code-pointers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #26 from Joel Madero jmadero@gmail.com ---
well if you want it just re-written, I have at least 50% of the work already
done;) So I'll take it. the only thing I'm currently lacking is icons and a
couple of the functions which I think will be easy enough to add. 

So I'm still having some issues with the icons - weird thing is when I
installed the extension icons came up on the toolbar I added - so maybe the
extension adds icons?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #23 from Joel Madero jmadero@gmail.com ---
If it's just text - like the image I showed in the link I provided - the
toolbar is basically done. I'll try to add at least accept/reject all and then
it would be done with text.

The interesting thing is - there's an extension for this already but I tried
installing it and it failed 

http://extensions.libreoffice.org/extension-center/review-toolbar/pscreleasefolder.2011-12-03.6583332356/201204.12.0.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   Assignee|jmadero@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
  Component|Writer  |ux-advise

--- Comment #17 from Joel Madero jmadero@gmail.com ---
I've done as much as I can without icons - from what I can see we do not have
icons for any of these options:

Record Changes
Show Changes
Accept/Reject
Accept All
Reject All
Next/Previous
Protect

UX - any input here would be appreciated so I can tackle this one :-D

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #18 from Eyal Rozenberg eyal...@technion.ac.il ---
So, is there a patch with the toolbar?

Also, are rudimentary icons necessary for this to be committed? If that's the
case, provide a link to a file/folder with existing icons in the appropriate
format and maybe we'll do something about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 47677] New Toolbar that has Record Changes (Track Changes) options

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47677

--- Comment #19 from Joel Madero jmadero@gmail.com ---
Currently I don't see any icons at all and yes - we'd want icons before I
submit a patch to git as right now it's just text:
https://lh5.googleusercontent.com/-DzF5fk6XVYI/UfGxEgpW9KI/AQs/Pn2P7VIAgQU/w1046-h654-no/shot-2013-07-25_16-12-41.jpg

In terms of icons and what folder - if someone just makes some icons for me
that fit the general theme (Galaxy) I can probably start with that. Just zip it
up and attach to this report but even with this UX team probably will have to
give the +1 before an actual commit happens.

For a patch of what I've done already - I'd prefer not to provide just quite
yet as I haven't cleaned and I still have a bit of stuff to add - going to try
to add the Accept All Reject All if I can track the uno. commands down.


Best

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise