[sr #111069] libtool: patch: Fix dynamic_lookup warnings from new Mac linker

[Carlo Cabrera]

Follow-up Comment #5, sr #111069 (group libtool):

Actually, checking the behaviour of ld64 when it's given unknown flags isn't
hard:

```
❯ clang -xc - -Wl,-nonexistent_flag -o /dev/null <<<'int main(){}'
ld: unknown options: -nonexistent_flag
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
❯ echo $?
1
```

[comment #4 comment #4:]
> Now I wonder if a feature test might be better here in libtool, rather than
a linker version number test.

Yes, I suspect that might be more appropriate. But I don't do any libtool
development, so my opinion probably doesn't count for much.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #111069] libtool: patch: Fix dynamic_lookup warnings from new Mac linker

[Dave Allured]

Follow-up Comment #4, sr #111069 (group libtool):

[comment #3 comment #3:]
> I personally tested this a while back

Thanks for letting me know about that testing.  Now I wonder if a feature test
might be better here in libtool, rather than a linker version number test.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[sr #111069] libtool: patch: Fix dynamic_lookup warnings from new Mac linker

[Carlo Cabrera]

Follow-up Comment #3, sr #111069 (group libtool):


> My original patch assumes that `-no_fixup_chains` would be silently ignored
by intermediate linker versions older than Xcode 13.  I have not yet tested
this assumption on any such Macs.

This is not a good assumption, I'm afraid. I personally tested this a while
back and found that older versions of ld64 will error when passed the
`-no_fixup_chains` flag.

See https://github.com/pybind/pybind11/pull/4301#issuecomment-1446551317.
(Unfortunately, the actions logs are no longer available from those tests.)


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/