Re: autoreconf: Allow variable override

2005-09-26 Thread Tim Rice
On Mon, 26 Sep 2005, Tim Rice wrote:

> 
> CVS HEAD
> 
> Here is a patch to tests/defs.m4sh to fix the hard coded autoreconf.

Oops, missed one.  tests/testsuite.at needed tuning up too.

> 
> 
> 

-- 
Tim RiceMultitalents(707) 887-1469
[EMAIL PROTECTED]
--- ChangeLog.old   2005-09-26 15:22:52.0 -0700
+++ ChangeLog   2005-09-26 18:15:08.945737083 -0700
@@ -1,3 +1,8 @@
+2005-09-26  Tim Rice  <[EMAIL PROTECTED]>
+
+   * tests/defs.m4sh tests/testsuite.at
+   : Allow variable override.
+
 2005-09-26  Ralf Wildenhues <[EMAIL PROTECTED]>
 
* HACKING: Only update libltdl version info before release.
--- tests/defs.m4sh.old 2005-08-24 06:39:51.0 -0700
+++ tests/defs.m4sh 2005-09-26 16:27:42.929977009 -0700
@@ -31,6 +31,7 @@
 m4_include([general.m4sh])
 
 : ${AUTOCONF="autoconf"}
+: ${AUTORECONF="autoreconf"}
 : ${LIBTOOL="./libtool"}
 
 # Sed that helps us avoid accidentally triggering echo(1) options like -n.
@@ -187,7 +188,7 @@
 
 func_msg "Configuring in $my_dir"
 
-test -f "$my_testdir/configure" || autoreconf --force --install $my_testdir
+test -f "$my_testdir/configure" || ${AUTORECONF} --force --install 
$my_testdir
 if test -f "$my_testdir/configure"; then
 
   eval func_msg $SHELL "$my_testdir/configure" $my_args
--- tests/testsuite.at.old  2005-09-16 01:33:24.0 -0700
+++ tests/testsuite.at  2005-09-26 18:09:16.830697004 -0700
@@ -23,6 +23,7 @@
 : ${LIBTOOL="${abs_top_builddir}/libtool"}
 : ${ACLOCAL=aclocal}
 : ${AUTOCONF=autoconf}
+: ${AUTORECONF=autoreconf}
 export LIBTOOLIZE LIBTOOL ACLOCAL AUTOCONF
 eval `$LIBTOOL --config | grep ^EGREP=`
 eval `$LIBTOOL --config | $EGREP '^(host|host_os|build)='`
@@ -48,7 +49,7 @@
 m4_define([LT_AT_BOOTSTRAP],
 [
 test -f ./ltmain.sh || LT_AT_LIBTOOLIZE([--copy])
-test -f ./configure || _lt_pkgdatadir="$abs_top_srcdir" autoreconf --force 
--verbose --install || exit 1
+test -f ./configure || _lt_pkgdatadir="$abs_top_srcdir" ${AUTORECONF} --force 
--verbose --install || exit 1
 test -f ./configure || exit 1
 ./configure
 ])


autoreconf: Allow variable override

2005-09-26 Thread Tim Rice

CVS HEAD

Here is a patch to tests/defs.m4sh to fix the hard coded autoreconf.


-- 
Tim RiceMultitalents(707) 887-1469
[EMAIL PROTECTED]
--- ChangeLog.old   2005-09-26 15:22:52.0 -0700
+++ ChangeLog   2005-09-26 16:31:55.389977074 -0700
@@ -1,3 +1,7 @@
+2005-09-26  Tim Rice  <[EMAIL PROTECTED]>
+
+   * tests/defs.m4sh : Allow variable override.
+
 2005-09-26  Ralf Wildenhues <[EMAIL PROTECTED]>
 
* HACKING: Only update libltdl version info before release.
--- tests/defs.m4sh.old 2005-08-24 06:39:51.0 -0700
+++ tests/defs.m4sh 2005-09-26 16:27:42.929977009 -0700
@@ -31,6 +31,7 @@
 m4_include([general.m4sh])
 
 : ${AUTOCONF="autoconf"}
+: ${AUTORECONF="autoreconf"}
 : ${LIBTOOL="./libtool"}
 
 # Sed that helps us avoid accidentally triggering echo(1) options like -n.
@@ -187,7 +188,7 @@
 
 func_msg "Configuring in $my_dir"
 
-test -f "$my_testdir/configure" || autoreconf --force --install $my_testdir
+test -f "$my_testdir/configure" || ${AUTORECONF} --force --install 
$my_testdir
 if test -f "$my_testdir/configure"; then
 
   eval func_msg $SHELL "$my_testdir/configure" $my_args


Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Tim Rice
On Mon, 26 Sep 2005, Ralf Wildenhues wrote:

> Hi Tim,
> 
> * Tim Rice wrote on Mon, Sep 26, 2005 at 10:45:29PM CEST:
> > On Mon, 26 Sep 2005, Ralf Wildenhues wrote:
> > > * Tim Rice wrote on Mon, Sep 26, 2005 at 08:41:21PM CEST:
> 
> > > > All UnixWare 2.x versions (and 1.x) are sysv4.2, so the sysv4*uw2 entry
> > > > becomes redundant.
> > > 
> > > Well, I _was_ cheating a bit:
> > > http://lists.gnu.org/archive/html/bug-libtool/2005-09/msg00013.html
> > > http://lists.gnu.org/archive/html/libtool-patches/2005-09/msg00036.html
> > > (be sure to look through both threads -- I installed a bogus patch first,
> > > stumbling over this exact same issue ;-)
> > 
> > And I made the same mistake (sysv4*uw2/sysv4.2*uw2) in
> > http://lists.gnu.org/archive/html/libtool-patches/2004-10/msg00012.html
> > 
> > OK, so we don't need to worry about sysv4*uw2 as all UnixWare 2 are
> > sysv4.2
> 
> Good thing we got that sorted out.  ;-)
> 
> Could you -- in light of this -- repost your patch, so we can apply it?
> (Or test CVS HEAD first and then repost; whatever suits you best.)
> A ChangeLog entry would be nice, but I'll happily write one for you,
> too.  :)

Ok, here it is including an attempt at a ChangeLog entry.

> 
> Thank you,
> Ralf
> 
> 
> 
> 

-- 
Tim RiceMultitalents(707) 887-1469
[EMAIL PROTECTED]
--- libtool-1.5/ChangeLog.old   2005-09-25 09:00:18.0 -0700
+++ libtool-1.5/ChangeLog   2005-09-26 15:54:26.944777219 -0700
@@ -1,3 +1,12 @@
+2005-09-26  Tim Rice  <[EMAIL PROTECTED]>
+
+   * libtool.m4 (AC_DEPLIBS_CHECK_METHOD, AC_LIBTOOL_SYS_DYNAMIC_LINKER)
+   (AC_LIBTOOL_LANG_CXX_CONFIG, AC_LIBTOOL_PROG_COMPILER_PIC)
+   (AC_LIBTOOL_PROG_LD_SHLIBS):
+   * ltdl.m4 (AC_LTDL_SYS_DLOPEN_DEPLIBS):
+   Get UnixWare 7.1.[34] and OpenServer 6 fully working.
+   Improve other UnixWare versions a little.
+
 2005-09-25  Alan W. Irwin  <[EMAIL PROTECTED]>,
Ralf Wildenhues  <[EMAIL PROTECTED]>
 
--- libtool-1.5/libtool.m4.old  2005-09-22 16:59:00.0 -0700
+++ libtool-1.5/libtool.m4  2005-09-26 15:31:57.164617030 -0700
@@ -1655,7 +1655,7 @@
   need_version=yes
   ;;
 
-sysv4 | sysv4.2uw2* | sysv4.3* | sysv5*)
+sysv4 | sysv4.2uw2* | sysv4.3*)
   version_type=linux
   library_names_spec='${libname}${release}${shared_ext}$versuffix 
${libname}${release}${shared_ext}$major $libname${shared_ext}'
   soname_spec='${libname}${release}${shared_ext}$major'
@@ -1688,6 +1688,19 @@
   fi
   ;;
 
+sysv5*)
+  version_type=linux
+  need_lib_prefix=no
+  need_version=no
+  library_names_spec='${libname}${release}${shared_ext}$versuffix 
${libname}${release}${shared_ext}$major $libname${shared_ext}'
+  soname_spec='${libname}${release}${shared_ext}$major'
+  shlibpath_var=LD_LIBRARY_PATH
+  shlibpath_overrides_runpath=yes
+  hardcode_into_libs=yes
+  sys_lib_search_path_spec='/usr/ccs/lib /usr/lib'
+  sys_lib_dlsearch_path_spec="$sys_lib_search_path_spec"
+  ;;
+
 uts4*)
   version_type=linux
   library_names_spec='${libname}${release}${shared_ext}$versuffix 
${libname}${release}${shared_ext}$major $libname${shared_ext}'
@@ -2314,11 +2327,7 @@
   lt_cv_deplibs_check_method=pass_all
   ;;
 
-sysv5OpenUNIX8* | sysv5UnixWare7* | sysv5uw[[78]]*)
-  lt_cv_deplibs_check_method=pass_all
-  ;;
-
-sysv4 | sysv4.2uw2* | sysv4.3* | sysv5*)
+sysv4 | sysv4.2uw2* | sysv4.3*)
   case $host_vendor in
   motorola)
 lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit [[ML]]SB 
(shared object|dynamic lib) M[[0-9]][[0-9]]* Version [[0-9]]'
@@ -2339,10 +2348,13 @@
   siemens)
 lt_cv_deplibs_check_method=pass_all
 ;;
+  pc)
+lt_cv_deplibs_check_method=pass_all
+;;
   esac
   ;;
 
-sysv4*uw2* | unixware7*)
+unixware7* | sysv5*)
   lt_cv_deplibs_check_method=pass_all
   ;;
 esac
@@ -3559,8 +3571,29 @@
;;
 esac
 ;;
-  sysv5OpenUNIX8* | sysv5UnixWare7* | sysv5uw[[78]]* | unixware7*)
-_LT_AC_TAGVAR(archive_cmds_need_lc, $1)=no
+  sysv5OpenUNIX8* | sysv5UnixWare7.[[01]].[[01]]* | sysv5uw[[78]]* | 
unixware7*)
+case $cc_basename in
+  CC*)
+   _LT_AC_TAGVAR(no_undefined_flag, $1)='${wl}-z ${wl}text'
+   _LT_AC_TAGVAR(archive_cmds, $1)='$CC -G ${wl}-h ${wl}$soname -o $lib 
$libobjs $deplibs $compiler_flags'
+   _LT_AC_TAGVAR(archive_cmds_need_lc, $1)=no
+   runpath_var='LD_RUN_PATH'
+   _LT_AC_TAGVAR(hardcode_shlibpath_var, $1)=no
+   ;;
+esac
+;;
+  sysv5*)
+case $cc_basename in
+  CC*)
+   _LT_AC_TAGVAR(no_undefined_flag, $1)='${wl}-z ${wl}text'
+   _LT_AC_TAGVAR(archive_cmds, $1)='$CC -G ${wl}-h ${wl}$soname -o $lib 
$libobjs $deplibs $compiler_flags'
+   _LT_AC_TAGVAR(archive_cmds_need_lc, $1)=no
+   _LT_AC_TAGVAR(hardcode_libdir_flag_spec, $1)='-R$libdir'
+   _LT_AC_TAGVAR(hardcode_libdir_separator, $1)=':'
+   runpath_var='LD_RUN_PATH'
+   _LT_AC_TAGVAR(hardcode_shlibpath_var, $1)=no
+   ;;
+esac
 ;;
   tandem*)
 case $cc_basename 

Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Ralf Wildenhues
Hi Tim,

* Tim Rice wrote on Mon, Sep 26, 2005 at 10:45:29PM CEST:
> On Mon, 26 Sep 2005, Ralf Wildenhues wrote:
> > * Tim Rice wrote on Mon, Sep 26, 2005 at 08:41:21PM CEST:

> > > All UnixWare 2.x versions (and 1.x) are sysv4.2, so the sysv4*uw2 entry
> > > becomes redundant.
> > 
> > Well, I _was_ cheating a bit:
> > http://lists.gnu.org/archive/html/bug-libtool/2005-09/msg00013.html
> > http://lists.gnu.org/archive/html/libtool-patches/2005-09/msg00036.html
> > (be sure to look through both threads -- I installed a bogus patch first,
> > stumbling over this exact same issue ;-)
> 
> And I made the same mistake (sysv4*uw2/sysv4.2*uw2) in
> http://lists.gnu.org/archive/html/libtool-patches/2004-10/msg00012.html
> 
> OK, so we don't need to worry about sysv4*uw2 as all UnixWare 2 are
> sysv4.2

Good thing we got that sorted out.  ;-)

Could you -- in light of this -- repost your patch, so we can apply it?
(Or test CVS HEAD first and then repost; whatever suits you best.)
A ChangeLog entry would be nice, but I'll happily write one for you,
too.  :)

Thank you,
Ralf




Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Tim Rice
On Mon, 26 Sep 2005, Ralf Wildenhues wrote:

> Hi Tim,
> 
> * Tim Rice wrote on Mon, Sep 26, 2005 at 08:41:21PM CEST:
> > On Mon, 26 Sep 2005, Ralf Wildenhues wrote:
> > : * Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
> 
[snip]
> > : > : Content-Description: branch-1-5-uw.patch
> *snip*
> > : > : >  
> > : > : > -sysv4*uw2* | unixware7*)
> > : > : > +unixware7*)
> > : > : 
> > : > : Now, this macro doesn't have a match for sysv4*uw2* any more.  Is this
> > : > : intentional?
> > : > 
> > : > Quite intentional. Look at the case above, it already had sysv4*uw2* so
> > : > the one I removed would never have been used anyway. Adding the "pc)"
> > : > case to the $host_vendor part did what the other case was supposed to 
> > do.
> > : 
> > : Erm, it had sysv4.2uw2* but not sysv4*uw2*.  If both should be treated
> > : similarly here, then you should replace the former with the latter (in
> > : the line where sysv4 is also matched)
> > 
> > Remind me never to take a proof reading job. I guess my brain was focusing
> > in the uw2 part.
> > All UnixWare 2.x versions (and 1.x) are sysv4.2, so the sysv4*uw2 entry
> > becomes redundant.
> 
> Well, I _was_ cheating a bit:
> http://lists.gnu.org/archive/html/bug-libtool/2005-09/msg00013.html
> http://lists.gnu.org/archive/html/libtool-patches/2005-09/msg00036.html
> (be sure to look through both threads -- I installed a bogus patch first,
> stumbling over this exact same issue ;-)

And I made the same mistake (sysv4*uw2/sysv4.2*uw2) in
http://lists.gnu.org/archive/html/libtool-patches/2004-10/msg00012.html

OK, so we don't need to worry about sysv4*uw2 as all UnixWare 2 are
sysv4.2

> 
> > : > It could be cleanded up further by having "sysv5* | unixware7*)".
> > : > (UnixWare 7 is sysv5)
> > : 
> > : Hmm, then both of those should be treated similarly, I guess?
> > 
> > Yes.
> 
> OK.
> 
> Cheers,
> Ralf
> 

-- 
Tim RiceMultitalents(707) 887-1469
[EMAIL PROTECTED]






HEAD: cross-compile test new testsuite

2005-09-26 Thread Ralf Wildenhues
This gets the new test suite from several failures to no failures (but
of course a number of skips) for a gnu-linux -> mingw cross-compile.
(The old test suite also show a couple of recent regressions, sigh;
more about that in another mail.)

OK to apply to HEAD?

Cheers,
Ralf

* tests/testsuite.at (PREPARE_TESTS): Extract host_alias.
Set configure_options appropriately.
(LT_AT_CONFIGURE): New macro.
(LT_AT_BOOTSTRAP): Use it.
* tests/early-libtool.at, tests/standalone.at: Likewise.

Index: tests/testsuite.at
===
RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
retrieving revision 1.19
diff -u -r1.19 testsuite.at
--- tests/testsuite.at  16 Sep 2005 08:33:24 -  1.19
+++ tests/testsuite.at  26 Sep 2005 13:13:53 -
@@ -25,9 +25,14 @@
 : ${AUTOCONF=autoconf}
 export LIBTOOLIZE LIBTOOL ACLOCAL AUTOCONF
 eval `$LIBTOOL --config | grep ^EGREP=`
-eval `$LIBTOOL --config | $EGREP '^(host|host_os|build)='`
+eval `$LIBTOOL --config | $EGREP '^(host|host_os|host_alias|build)='`
+configure_options=
+if test -n "$host_alias"; then
+  configure_options="--host $host_alias"
+fi
 m4_divert_pop([PREPARE_TESTS])dnl
 
+
 # LT_AT_LIBTOOLIZE([ARGS])
 # 
 m4_define([LT_AT_LIBTOOLIZE],
@@ -43,6 +48,13 @@
 ])
 
 
+# LT_AT_CONFIGURE([OPTIONS])
+# --
+m4_define([LT_AT_CONFIGURE],
+[./configure $configure_options $1 || exit 1
+])
+
+
 # LT_AT_BOOTSTRAP
 # ---
 m4_define([LT_AT_BOOTSTRAP],
@@ -50,7 +63,7 @@
 test -f ./ltmain.sh || LT_AT_LIBTOOLIZE([--copy])
 test -f ./configure || _lt_pkgdatadir="$abs_top_srcdir" autoreconf --force 
--verbose --install || exit 1
 test -f ./configure || exit 1
-./configure
+LT_AT_CONFIGURE
 ])
 
 
Index: tests/early-libtool.at
===
RCS file: /cvsroot/libtool/libtool/tests/early-libtool.at,v
retrieving revision 1.4
diff -u -r1.4 early-libtool.at
--- tests/early-libtool.at  8 Sep 2005 07:17:58 -   1.4
+++ tests/early-libtool.at  26 Sep 2005 13:13:53 -
@@ -104,7 +104,7 @@
 test -f ltmain.sh  || LT_AT_LIBTOOLIZE([--copy --verbose --install])
 test -f aclocal.m4 || $ACLOCAL -I m4  || exit 1
 test -f configure  || $AUTOCONF --force   || exit 1
-test -f Makefile   || ./configure || exit 1
+test -f Makefile   || LT_AT_CONFIGURE
 ${MAKE-make}
 
 LT_AT_EXEC_CHECK([./hell], [0], [expout])
@@ -207,7 +207,7 @@
 test -f ltmain.sh  || LT_AT_LIBTOOLIZE([--copy --verbose --install])
 test -f aclocal.m4 || $ACLOCAL -I m4  || exit 1
 test -f configure  || $AUTOCONF --force   || exit 1
-test -f Makefile   || ./configure || exit 1
+test -f Makefile   || LT_AT_CONFIGURE
 ${MAKE-make}
 
 LT_AT_EXEC_CHECK([./hell], [0], [expout])
Index: tests/standalone.at
===
RCS file: /cvsroot/libtool/libtool/tests/standalone.at,v
retrieving revision 1.3
diff -u -r1.3 standalone.at
--- tests/standalone.at 26 Aug 2005 10:00:18 -  1.3
+++ tests/standalone.at 26 Sep 2005 13:13:53 -
@@ -26,7 +26,7 @@
 AT_SETUP([compiling softlinked libltdl])
 
 LT_AT_LIBTOOLIZE([--ltdl=.])
-./configure
+LT_AT_CONFIGURE
 ${MAKE-make}
 
 AT_CHECK([test -f libltdlc.la])
@@ -41,7 +41,7 @@
 AT_SETUP([compiling copied libltdl])
 
 LT_AT_LIBTOOLIZE([--copy --ltdl=.])
-./configure
+LT_AT_CONFIGURE
 ${MAKE-make}
 
 AT_CHECK([test -f libltdlc.la])
@@ -58,7 +58,7 @@
 prefix=`pwd`/_inst
 
 LT_AT_LIBTOOLIZE([--copy --ltdl=.])
-./configure --enable-ltdl-install --prefix=$prefix
+LT_AT_CONFIGURE([--enable-ltdl-install --prefix=$prefix])
 ${MAKE-make} all install
 
 AT_CHECK([test -f $prefix/lib/libltdl.la])
@@ -135,7 +135,7 @@
 all: $(TARGETS)
 
 $(LIBTOOL) libltdl/libltdlc.la:
-   cd libltdl && ./configure && $(MAKE)
+   cd libltdl && ./configure $(CONFIGURE_OPTIONS) && $(MAKE)
 
 ltdldemo$(EXEEXT): $(LIBTOOL) module.la libltdl/libltdlc.la main.lo
$(LTLINK) -o ltdldemo main.lo -dlopen module.la ./libltdl/libltdlc.la
@@ -152,7 +152,8 @@
 
 LT_AT_LIBTOOLIZE([--copy --ltdl])
 ${MAKE-make} CC="$CC" LIBTOOLFLAGS="$LIBTOOLFLAGS" CPPFLAGS="$CPPFLAGS" \
-CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS"
+CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS" \
+   CONFIGURE_OPTIONS="$configure_options"
 
 LT_AT_EXEC_CHECK([./ltdldemo], 0, [ignore])
 




Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Ralf Wildenhues
Hi Tim,

* Tim Rice wrote on Mon, Sep 26, 2005 at 08:41:21PM CEST:
> On Mon, 26 Sep 2005, Ralf Wildenhues wrote:
> : * Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:

> : > I re-ran the tests using ksh88 and all tests passed.
> : > Must be a ksh bug.
> : > Version M-11/16/88h   passes quote test
> : > Version M-12/28/93e-SCO   fails quote test
> : 
> : Please post the failing output of
> :   make check TESTS=quote.test VERBOSE=x
> : 
> : Thank you.
> 
> ---< begin "make check TESTS=quote.test VERBOSE=x" >
> [EMAIL PROTECTED] 14% gmake check TESTS=quote.test VERBOSE=x

> === Running quote.test
> == compile mode

> = trying: \\ quoting
> = failed: mkdir .libs
>  cc -c "-DVAR=\\test\\" foo.c  -KPIC -DPIC -o .libs/foo.o
>  cc -c "-DVAR=\\test\\" foo.c -o foo.o >/dev/null 2>&1
> = trying: \" quoting
> = failed: mkdir .libs
>  cc -c "-DVAR=\"test\"" foo.c  -KPIC -DPIC -o .libs/foo.o
>  cc -c "-DVAR=\"test\"" foo.c -o foo.o >/dev/null 2>&1
> = trying: \` quoting
> = failed: mkdir .libs
>  cc -c "-DVAR=\`test\`" foo.c  -KPIC -DPIC -o .libs/foo.o
>  cc -c "-DVAR=\`test\`" foo.c -o foo.o >/dev/null 2>&1
> = trying: \$ quoting
> = failed: mkdir .libs
>  cc -c "-DVAR=\$test\$" foo.c  -KPIC -DPIC -o .libs/foo.o
>  cc -c "-DVAR=\$test\$" foo.c -o foo.o >/dev/null 2>&1
*snip*
> FAIL: quote.test

OK.  This is mostly harmless, and we should eventually adjust
quote.test.  I tried to fix this in CVS HEAD with a patch on
2004-12-28 but had to throw that back out on 2005-06-05 because
that broke on other systems' shells.

Thanks for posting. 

> : *snip*
> : > : Content-Description: branch-1-5-uw.patch
*snip*
> : > : >  
> : > : > -sysv4*uw2* | unixware7*)
> : > : > +unixware7*)
> : > : 
> : > : Now, this macro doesn't have a match for sysv4*uw2* any more.  Is this
> : > : intentional?
> : > 
> : > Quite intentional. Look at the case above, it already had sysv4*uw2* so
> : > the one I removed would never have been used anyway. Adding the "pc)"
> : > case to the $host_vendor part did what the other case was supposed to do.
> : 
> : Erm, it had sysv4.2uw2* but not sysv4*uw2*.  If both should be treated
> : similarly here, then you should replace the former with the latter (in
> : the line where sysv4 is also matched)
> 
> Remind me never to take a proof reading job. I guess my brain was focusing
> in the uw2 part.
> All UnixWare 2.x versions (and 1.x) are sysv4.2, so the sysv4*uw2 entry
> becomes redundant.

Well, I _was_ cheating a bit:
http://lists.gnu.org/archive/html/bug-libtool/2005-09/msg00013.html
http://lists.gnu.org/archive/html/libtool-patches/2005-09/msg00036.html
(be sure to look through both threads -- I installed a bogus patch first,
stumbling over this exact same issue ;-)

> : > It could be cleanded up further by having "sysv5* | unixware7*)".
> : > (UnixWare 7 is sysv5)
> : 
> : Hmm, then both of those should be treated similarly, I guess?
> 
> Yes.

OK.

Cheers,
Ralf




Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Tim Rice
On Mon, 26 Sep 2005, Ralf Wildenhues wrote:

: Hi Tim,
: 
: * Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
: > On Sun, 25 Sep 2005, Ralf Wildenhues wrote:
: > : * Tim Rice wrote on Fri, Sep 23, 2005 at 10:20:29PM CEST:
[snip]
: > I re-ran the tests using ksh88 and all tests passed.
: > Must be a ksh bug.
: > Version M-11/16/88h passes quote test
: > Version M-12/28/93e-SCO fails quote test
: 
: Please post the failing output of
:   make check TESTS=quote.test VERBOSE=x
: 
: Thank you.

---< begin "make check TESTS=quote.test VERBOSE=x" >
[EMAIL PROTECTED] 14% gmake check TESTS=quote.test VERBOSE=x
Making check in .
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build'
gmake[1]: Nothing to be done for `check-am'.
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build'
Making check in libltdl
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/libltdl'
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/libltdl'
Making check in doc
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/doc'
gmake[1]: Nothing to be done for `check'.
gmake[1]: Leaving directory `/usr/local/src/gnu/libtool-1.5/build/doc'
Making check in tests
gmake[1]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/tests'
gmake  check-TESTS
gmake[2]: Entering directory `/usr/local/src/gnu/libtool-1.5/build/tests'
=== Running quote.test
== compile mode
= trying: no quoting
= passed: mkdir .libs
 cc -c -DVAR=test foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c -DVAR=test foo.c -o foo.o >/dev/null 2>&1
= trying: \\ quoting
= failed: mkdir .libs
 cc -c "-DVAR=\\test\\" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\\test\\" foo.c -o foo.o >/dev/null 2>&1
= trying: \" quoting
= failed: mkdir .libs
 cc -c "-DVAR=\"test\"" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\"test\"" foo.c -o foo.o >/dev/null 2>&1
= trying: \` quoting
= failed: mkdir .libs
 cc -c "-DVAR=\`test\`" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\`test\`" foo.c -o foo.o >/dev/null 2>&1
= trying: \$ quoting
= failed: mkdir .libs
 cc -c "-DVAR=\$test\$" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=\$test\$" foo.c -o foo.o >/dev/null 2>&1
= trying: "[" quoting
= passed: mkdir .libs
 cc -c "-DVAR=[test[" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=[test[" foo.c -o foo.o >/dev/null 2>&1
= trying: "]" quoting
= passed: mkdir .libs
 cc -c "-DVAR=]test]" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=]test]" foo.c -o foo.o >/dev/null 2>&1
= trying: "~" quoting
= passed: mkdir .libs
 cc -c "-DVAR=~test~" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=~test~" foo.c -o foo.o >/dev/null 2>&1
= trying: "#" quoting
= passed: mkdir .libs
 cc -c "-DVAR=#test#" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=#test#" foo.c -o foo.o >/dev/null 2>&1
= trying: "^" quoting
= passed: mkdir .libs
 cc -c "-DVAR=^test^" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=^test^" foo.c -o foo.o >/dev/null 2>&1
= trying: "&" quoting
= passed: mkdir .libs
 cc -c "-DVAR=&test&" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=&test&" foo.c -o foo.o >/dev/null 2>&1
= trying: "*" quoting
= passed: mkdir .libs
 cc -c "-DVAR=*test*" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=*test*" foo.c -o foo.o >/dev/null 2>&1
= trying: "(" quoting
= passed: mkdir .libs
 cc -c "-DVAR=(test(" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=(test(" foo.c -o foo.o >/dev/null 2>&1
= trying: ")" quoting
= passed: mkdir .libs
 cc -c "-DVAR=)test)" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=)test)" foo.c -o foo.o >/dev/null 2>&1
= trying: "{" quoting
= passed: mkdir .libs
 cc -c "-DVAR={test{" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR={test{" foo.c -o foo.o >/dev/null 2>&1
= trying: "}" quoting
= passed: mkdir .libs
 cc -c "-DVAR=}test}" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=}test}" foo.c -o foo.o >/dev/null 2>&1
= trying: "|" quoting
= passed: mkdir .libs
 cc -c "-DVAR=|test|" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=|test|" foo.c -o foo.o >/dev/null 2>&1
= trying: ";" quoting
= passed: mkdir .libs
 cc -c "-DVAR=;test;" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=;test;" foo.c -o foo.o >/dev/null 2>&1
= trying: "<" quoting
= passed: mkdir .libs
 cc -c "-DVAR=/dev/null 2>&1
= trying: ">" quoting
= passed: mkdir .libs
 cc -c "-DVAR=>test>" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=>test>" foo.c -o foo.o >/dev/null 2>&1
= trying: "?" quoting
= passed: mkdir .libs
 cc -c "-DVAR=?test?" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR=?test?" foo.c -o foo.o >/dev/null 2>&1
= trying: "'" quoting
= passed: mkdir .libs
 cc -c "-DVAR='test'" foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR='test'" foo.c -o foo.o >/dev/null 2>&1
= trying: " " quoting
= passed: mkdir .libs
 cc -c "-DVAR= test " foo.c  -KPIC -DPIC -o .libs/foo.o
 cc -c "-DVAR= test " foo.c -o foo.o >/dev/null 2>&1
= trying: " " quoting
= passed: mkdir .libs
 cc -c "-DVAR=  test" foo.c  -KPIC -DPIC -o

FYI: alternate names for autom4te

2005-09-26 Thread Ralf Wildenhues
Hi Tim,

* Tim Rice wrote on Sun, Sep 25, 2005 at 11:02:42PM CEST:
> 
> CVS HEAD
>
> Here is a small patch to configure.ac to allow
> AUTOM4TE=/opt/bin/autom4te259 /some/path/to/configure .
> 
> (solved my "106 of 106 tests failed" problem) ;-)

Thank you for this patch.  Applied to HEAD with the ChangeLog entry
below.

Cheers,
Ralf

2005-09-26  Tim Rice  <[EMAIL PROTECTED]>

* configure.ac : Allow variable override.

> --- configure.ac.old  2005-08-29 06:58:07.0 -0700
> +++ configure.ac  2005-09-25 13:39:25.645733007 -0700
> @@ -37,7 +37,7 @@
>  ##  ##
>  
>  AC_CONFIG_TESTDIR([tests])
> -AC_SUBST([AUTOM4TE], [autom4te])
> +AC_SUBST([AUTOM4TE], [${AUTOM4TE=autom4te}])
>  AC_SUBST([AUTOTEST], ['$(AUTOM4TE) --language=autotest'])




Re: release policy

2005-09-26 Thread Ralf Wildenhues
Oldish thread..

* Gary V. Vaughan wrote on Sun, Sep 18, 2005 at 11:30:32AM CEST:
> Ralf Wildenhues wrote:
> > * Gary V. Vaughan wrote on Sat, Sep 17, 2005 at 10:35:32PM CEST:
> >>Charles Wilson wrote:
> >>
> >>>Huh?  Right now (on cygwin) the shared library built by 1.5.x libtool is
> >>>"cygltdl-3.dll"  (e.g. current - age == 3).
> >>>
> >>>Somebody somewhere already bumped the c:r:a numbers in HEAD because
> >>>libtool-HEAD on cygwin creates cygltdl-6.dll.  So which previous
> >>>**releases** of libltdl are you trying to distinguish from, here, Ralf?
> >>
> >>My thoughts too at first, but checking 1.9f current was already 6, and
> >>this is an incompatible change with 1.9f.
> > 
> > 
> > First this, and besides I was referring to this policy in HACKING:
> > | * Double check that libltdl version number updates weren't forgotten
> > |   since last release (they should be updated in CVS along with commits
> > |   that require it so that users can work with CVS snapshots).
> > 
> > which, I believe, stems from the fact that somebody needed post-1.5
> > stuff but with 2.0 not in sight.
> 
> Hmmm... good catch, I hadn't spotted that, but...
> 
> > So while we are at it, it might be a good idea to remove the
> > parenthesized part..
> 
> Yes, I agree.  It seems wrong to churn the numbers so fast.  I don't
> think it is too much to expect people who track CVS to have to deal
> with regressions and experimental apis that later get fixed to restore
> backwards compatibility.  Can you fix that please?

Applied this patch to CVS HEAD.

Cheers,
Ralf

* HACKING: Only update libltdl version info before release.

Index: HACKING
===
RCS file: /cvsroot/libtool/libtool/HACKING,v
retrieving revision 1.20
diff -u -r1.20 HACKING
--- HACKING 17 Sep 2005 07:29:01 -  1.20
+++ HACKING 25 Sep 2005 10:22:46 -
@@ -368,9 +368,8 @@
   since last release (they should be updated in CVS along with commits that
   require it so that users can work with CVS snapshots).
 
-* Double check that libltdl version number updates weren't forgotten since last
-  release (they should be updated in CVS along with commits that require it so
-  that users can work with CVS snapshots).
+* Update the libltdl VERSION_INFO in Makefile.am for changes since the last
+  release.
 
 * Update the version number in configure.ac.
   See http://www.gnu.org/software/libtool/contribute.html for details of




Re: 279-gary-LT_CONFIG_LTDL_DIR.diff

2005-09-26 Thread Ralf Wildenhues
Hi Gary,

* Gary V. Vaughan wrote on Fri, Sep 23, 2005 at 02:26:24PM CEST:
> Here is the first part of the patch series to fix the LT_WITH_INIT
> interfaces.  Okay to commit?

No, unfortunately.  Observed bug below.

> This changeset brings some sanity to tracking the directory name for
> libltdl sources.  Old syntax still works, but the documentation now
> talks only about using the new LT_CONFIG_LTDL_DIR.  If any of the old
> macros are still given a directory argument, it is set as before, only
> now autoconf will stop with an error if there is a conflict.

Using libtoolize with this patch on a third-party package (which has a
subpackage that uses libltdl):

$ eval `cat aclocal.m4 ./foo/libltdl/configure.ac | sed "$my_sed_traces" `
++ sed 's,#.*$,,; s,^dnl .*$,,; s, dnl .*$,,;
s,^.*AC_REQUIRE(.*$,,; s,^.*m4_require(.*$,,; s,^.*m4_define(.*$,,;
s,^.*A[CU]_DEFUN(.*$,,; s,^.*m4_defun(.*$,,;
/AC_CONFIG_AUX_DIR(/ {
s,^.*AC_CONFIG_AUX_DIR([[   ]*\([^])]*\).*$,auxdir=\1,; p;
};
/AC_CONFIG_MACRO_DIR(/ {
s,^.*AC_CONFIG_MACRO_DIR([[ ]*\([^])]*\).*$,macrodir=\1,; p;
};
/LT_CONFIG_LTDL_DIR(/ {
s,^.*LT_CONFIG_LTDL_DIR([[   ]*\([^])]*\).*$,ac_ltdldir=\1,; p;
};
/A[CM]_PROG_LIBTOOL/ { s,^.*$,seen_libtool=:,; p; };
/LT_INIT/{ s,^.*$,seen_libtool=:,; p; };
/LTDL_INIT/  { s,^.*$,seen_ltdl=:,; p; };
/LT_WITH_LTDL/   { s,^.*$,seen_ltdl=:,; p; };
/AC_LIB_LTDL/{ s,^.*$,seen_ltdl=:,; p; };
/AC_WITH_LTDL/   { s,^.*$,seen_ltdl=:,; p; };
d'
++ cat aclocal.m4 ./foo/libltdl/configure.ac
+ eval seen_libtool=: seen_libtool=: seen_ltdl=: seen_ltdl=: 'ac_ltdldir=$1' 
'ac_ltdldir=$1' seen_ltdl=: 'ac_ltdldir=$1' 'ac_ltdldir=$1' ac_ltdldir=libltdl 
seen_ltdl=: seen_ltdl=: seen_ltdl=: 'ac_ltdldir=$1' 'ac_ltdldir=m4_default([$1' 
seen_ltdl=: seen_libtool=: seen_libtool=: seen_libtool=: seen_libtool=: 
seen_libtool=: seen_libtool=: seen_libtool=: seen_libtool=: seen_libtool=: 
seen_libtool=: seen_libtool=: seen_libtool=: seen_libtool=: auxdir=config 
macrodir=m4 ac_ltdldir=. seen_libtool=: seen_ltdl=:
bash: syntax error near unexpected token `('


First, the aclocal.m4 is the wrong file (should've been
foo/libltdl/aclocal.m4).  Second, it's picking up the stuff from ltdl.m4
that ended up in aclocal.m4.  I believe you can fix this by using an
internal macro _LT_CONFIG_LTDL_DIR (with LT_CONFIG_LTDL_DIR then being
only a wrapper around it) and not calling the external one from inside
ltdl.m4.

I can check more after this is fixed.

Cheers, and thanks for your work on this,
Ralf




Re: branch-1-5 UnixWare fixes

2005-09-26 Thread Ralf Wildenhues
Hi Tim,

* Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
> On Sun, 25 Sep 2005, Ralf Wildenhues wrote:
> : * Tim Rice wrote on Fri, Sep 23, 2005 at 10:20:29PM CEST:
> : > 
> : > I did some work on branch-1-5 to try and get libtool fully functional
> : > on UnixWare 7.1.4. I was mostly successful, only the quote test fails.
> : > Probably a ksh bug.
> : 
> : Which of the quote test lines fail?  Did you run the test in a new build
> : tree or did you ever re-configure (there is a bug in branch-1-5 wrt.
> 
> Always a fresh build tree.

OK.

> : setting $SHELL correctly on a config.status-induced configure rerun.  If
> : in doubt retry with a new build tree)
> 
> I re-ran the tests using ksh88 and all tests passed.
> Must be a ksh bug.
> Version M-11/16/88h   passes quote test
> Version M-12/28/93e-SCO   fails quote test

Please post the failing output of
  make check TESTS=quote.test VERBOSE=x

Thank you.

*snip*
> : Content-Description: branch-1-5-uw.patch
> [snip]
> : > @@ -2314,11 +2327,11 @@
> : >lt_cv_deplibs_check_method=pass_all
> : >;;
> : >  
> : > -sysv5OpenUNIX8* | sysv5UnixWare7* | sysv5uw[[78]]*)
> : > +sysv5*)
> : >lt_cv_deplibs_check_method=pass_all
> : >;;
> : >  
> : > -sysv4 | sysv4.2uw2* | sysv4.3* | sysv5*)
> : > +sysv4 | sysv4.2uw2* | sysv4.3*)
> : >case $host_vendor in
> : >motorola)
> : >  lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit 
> [[ML]]SB (shared object|dynamic lib) M[[0-9]][[0-9]]* Version [[0-9]]'
> : > @@ -2339,10 +2352,13 @@
> : >siemens)
> : >  lt_cv_deplibs_check_method=pass_all
> : >  ;;
> : > +  pc)
> : > +lt_cv_deplibs_check_method=pass_all
> : > +;;
> : >esac
> : >;;
> : >  
> : > -sysv4*uw2* | unixware7*)
> : > +unixware7*)
> : 
> : Now, this macro doesn't have a match for sysv4*uw2* any more.  Is this
> : intentional?
> 
> Quite intentional. Look at the case above, it already had sysv4*uw2* so
> the one I removed would never have been used anyway. Adding the "pc)"
> case to the $host_vendor part did what the other case was supposed to do.

Erm, it had sysv4.2uw2* but not sysv4*uw2*.  If both should be treated
similarly here, then you should replace the former with the latter (in
the line where sysv4 is also matched)

> It could be cleanded up further by having "sysv5* | unixware7*)".
> (UnixWare 7 is sysv5)

Hmm, then both of those should be treated similarly, I guess?

> I assume that unixware7* is in there for backward compatibility for
> some old config.guess.

I have no idea, really.

> : 
> : >lt_cv_deplibs_check_method=pass_all
> : >;;
> : >  esac
> [snip]
> : > @@ -5404,7 +5448,7 @@
> : >fi
> : >;;
> : >  
> : > -solaris* | sysv5*)
> : > +solaris*)
> : 
> : Any reason for this change?
> 
> Oops, that's one of the things I tried that didn't make any difference.
> Best to leave that in for now.

OK.

*snip large hunk*
> : 
> : You removed setting of archive_expsym_cmds here.  Was this intentional?
> : Did it not work?
> 
> Yes intentional, tests fail with it in.

OK, fine then.

Cheers, and thanks again,
Ralf