Re: distchecking without FC?
Hi Ralf, On Sat, Jun 16, 2007 at 11:13:36AM +0200, Ralf Wildenhues wrote: * Noah Misch wrote on Fri, Jun 15, 2007 at 02:42:04AM CEST: Therefore, I took a different approach: list the files to distribute directly in the top-level Makefile.am, and do not bother to configure the test directories for `make dist'. This would break down at the point when Autoconf or Automake decide to generate a different set of files (and we try to support both older and newer version). Arguably this doesn't happen too often, and Stepan has too little time to carry out his plans... True. If better, we could compromise between complexity and redundancy by generating the list of files at `bootstrap' time. If you've already tried this, please post the patch. Thanks. Otherwise I suppose we can cross the bridge when we come to it (you could put a FIXME above the list). Not yet, sorry. I can look into it. In any case, `make dist' runs an order magnitude faster. FWIW, I could care less about `dist' time. `check' and `all' are much more interesting. Certainly; this speed improvement is but a minor bonus. While examining this, I tried `make distcheck'. It failed due to a `config.log' left in tests/fcdemo when its `configure' fails. This patch incorporates a two-line fix to avoid that problem. This is fine. It seems the others like this patch, so I won't stand in the way. ;-) Thanks. Now if only I can entice someone to install it. Thanks, Noah
Re: Using getconf to set max_cmd_len
Ralf Wildenhues wrote: * Steve Ellcey wrote on Thu, May 31, 2007 at 12:58:37AM CEST: 2007-05-30 Steve Ellcey [EMAIL PROTECTED] * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): Try using getconf to set lt_cv_sys_max_cmd_len. [...] +lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2 /dev/null` The patch is all good (thanks!) except someone please put `getconf ARG_MAX' in a subshell so that if it does not exist, the shell error output is redirected as well (both branches). OK to apply (both branches)? 2007-06-17 Charles Wilson ... Ralf Wildenhues ... * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): ensure error is redirected even when getconf does not exist. -- Chuck ? .signature Index: libltdl/m4/libtool.m4 === RCS file: /sources/libtool/libtool/libltdl/m4/libtool.m4,v retrieving revision 1.105 diff -u -r1.105 libtool.m4 --- libltdl/m4/libtool.m4 4 Jun 2007 03:01:11 - 1.105 +++ libltdl/m4/libtool.m4 17 Jun 2007 18:23:24 - @@ -1437,7 +1437,7 @@ fi ;; *) -lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2 /dev/null` +lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2 /dev/null` if test -n $lt_cv_sys_max_cmd_len; then lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4` lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3` Index: libtool.m4 === RCS file: /sources/libtool/libtool/Attic/libtool.m4,v retrieving revision 1.314.2.179 diff -u -r1.314.2.179 libtool.m4 --- libtool.m4 4 Jun 2007 03:28:27 - 1.314.2.179 +++ libtool.m4 17 Jun 2007 18:25:33 - @@ -794,7 +794,7 @@ fi ;; *) -lt_cv_sys_max_cmd_len=`getconf ARG_MAX 2 /dev/null` +lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2 /dev/null` if test -n $lt_cv_sys_max_cmd_len; then lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4` lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3`
Re: [patch] win32: eliminate wrapper script in main build dir
Hi Charles, * Charles Wilson wrote on Sun, Jun 17, 2007 at 08:01:20PM CEST: Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Jun 17, 2007 at 02:43:02AM CEST: OK by me. Do you wat me to add your patch to mine and check it all in at once (e.g. keep the new-testsuite .exe fixes to destdir.at together), or will you check your changes in separately? However you like. Grepping the verbose output of the old HEAD testsuite for 'No such file or directory' shows several bits that need adjustment, too. Well, this is a bit more excusable: INSIDE libtool, we're allowed to depend on internal libtool details. Even if it isn't a really good idea, as in this case. Notwithstanding the answer to my question above concerning new-testsuite/destdir.at, I'd appreciate it if you would (at least) provide me with your cross-compile verbose log from the old testsuite, or (at best) a followup patch to fix these issues -- since I don't have a cross-compile setup, here. Attached. Unless you beat me to it, I can try to go about a patch sometime though. In any case, I'd like to postpone the cross-compile old-testsuite .exe fixes to a followup patch. Sure. Cheers, Ralf checklog-old-suite.bz2 Description: Binary data
Re: Using getconf to set max_cmd_len
On Sun, 2007-06-17 at 20:39 +0200, Ralf Wildenhues wrote: * Charles Wilson wrote on Sun, Jun 17, 2007 at 08:32:33PM CEST: OK to apply (both branches)? Of course. Thanks. And no need for my name in the ChangeLog entry. Cheers, Ralf 2007-06-17 Charles Wilson ... Ralf Wildenhues ... * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): ensure error is redirected even when getconf does not exist. I noticed that when I tried this with 'getconf' changed to some non-existing utility I got errors from expr. Turns out that we need to quote the string for test -n. Applied to HEAD and branch-1-5. Peter 2007-06-17 Peter O'Gorman [EMAIL PROTECTED] * libltdl/m4/libtool.m4 (LT_CMD_MAX_LEN): add quotes to the test -n. Index: libltdl/m4/libtool.m4 === RCS file: /sources/libtool/libtool/libltdl/m4/libtool.m4,v retrieving revision 1.106 diff -u -r1.106 libtool.m4 --- libltdl/m4/libtool.m4 17 Jun 2007 20:16:03 - 1.106 +++ libltdl/m4/libtool.m4 18 Jun 2007 00:42:17 - @@ -1438,7 +1438,7 @@ ;; *) lt_cv_sys_max_cmd_len=`(getconf ARG_MAX) 2 /dev/null` -if test -n $lt_cv_sys_max_cmd_len; then +if test -n $lt_cv_sys_max_cmd_len; then lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \/ 4` lt_cv_sys_max_cmd_len=`expr $lt_cv_sys_max_cmd_len \* 3` else
