Re: [PATCH] ltmain.in: Pass through -fdiagnostics-color, -frecord-gcc-switches

[Mike Frysinger]

On 14 Jan 2024 06:27, Sam James wrote:
> * -fdiagnostics-color: who doesn't like color? No reason to strip it. This
>   makes the link phase stick out like a sore thumb if there's warnings 
> emitted.

i have a vague recollection of libtool processing output, but i can't recall
where.  i guess if it breaks people, it's kind of their own fault, and we can
wait for reports.

> * -frecord-gcc-switches: we use it in Gentoo to check if a package respects
>   *FLAGS. Note that we do not need to include -grecord-gcc-switches explicitly
>   here as -g* is already whitelisted.

this is certainly np.

merged!
-mike


signature.asc
Description: PGP signature

[PATCH] ltmain.in: Pass through -fdiagnostics-color, -frecord-gcc-switches

[Sam James]

* -fdiagnostics-color: who doesn't like color? No reason to strip it. This
  makes the link phase stick out like a sore thumb if there's warnings emitted.

* -frecord-gcc-switches: we use it in Gentoo to check if a package respects
  *FLAGS. Note that we do not need to include -grecord-gcc-switches explicitly
  here as -g* is already whitelisted.
---
 build-aux/ltmain.in | 3 +++
 1 file changed, 3 insertions(+)

There's probably more of these that we need to do, I only onticed these two
by chance the other day.

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index fb49d6c8..d5157a8d 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5406,6 +5406,8 @@ func_mode_link ()
   # -O*, -g*, -flto*, -fwhopr*, -fuse-linker-plugin GCC link-time 
optimization
   # -specs=* GCC specs files
   # -stdlib=*select c++ std lib with clang
+  # -fdiagnostics-color* simply affects output
+  # -frecord-gcc-switches used to verify flags were respected
   # -fsanitize=* Clang/GCC memory and address sanitizer
   # -fno-sanitize*   Clang/GCC memory and address sanitizer
   # -shared-libsan   Link with shared sanitizer runtimes (Clang)
@@ -5417,6 +5419,7 @@ func_mode_link ()
   
-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
   
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
   -specs=*|-fsanitize=*|-fno-sanitize*|-shared-libsan|-static-libsan| \
+  -fdiagnostics-color*|-frecord-gcc-switches| \
   -fuse-ld=*|-Wa,*|-Werror|-Werror=*)
 func_quote_arg pretty "$arg"
arg=$func_quote_arg_result
-- 
2.43.0