Re: FYI: set macrodir correctly for installcheck [301]
Ralf Wildenhues wrote: Hi Gary, * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 09:06:40PM CET: Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 06:52:45PM CET: Had to tweak slightly to make test-5 work with installcheck. Why? That would be a bug. The whole point of tst_aclocaldir was that it does _not_ appear in libtoolize. And in fact, over here, this change: + test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir" is not needed at all. Huh? test 5 can't possibly pass for installcheck without it, because there is no setting for _lt_pkgdatadir in INSTALLCHECK_ENVIRONMENT... I'm all for a cleaner fix than my "tweak" if you have it though! :-) Did you actually see this failure? If yes, could you please post the corresponding testsuite.log failure output? I certainly *did* see that failure, and made the tst_aclocaldir fix to prevent that failure... I don't have time to dig in and understand *why* it works right now with my fix removed, but it certainly does work now. Maybe I dreamt the whole thing... For installcheck, the normal pkgdatadir setting in libtoolize should just suffice: the files will be installed there. And, in fact, both `installcheck' after `make install' as well as `distcheck' pass here without above line. ACK. Cheers, Gary. -- Gary V. Vaughan ())_. [EMAIL PROTECTED],gnu.org} Research Scientist ( '/ http://tkd.kicks-ass.net GNU Hacker / )= http://www.gnu.org/software/libtool Technical Author `(_~)_ http://sources.redhat.com/autobook signature.asc Description: OpenPGP digital signature
Re: FYI: set macrodir correctly for installcheck [301]
* Ralf Wildenhues wrote on Thu, Nov 10, 2005 at 09:40:08PM CET: > * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 09:06:40PM CET: > > > > Huh? test 5 can't possibly pass for installcheck without it, because > > there is no setting for _lt_pkgdatadir in INSTALLCHECK_ENVIRONMENT... > > Did you actually see this failure? If yes, could you please post the > corresponding testsuite.log failure output? > > For installcheck, the normal pkgdatadir setting in libtoolize should > just suffice: the files will be installed there. And, in fact, both > `installcheck' after `make install' as well as `distcheck' pass here > without above line. If I'm wrong, testing will show. I have applied the patch below to HEAD. Cheers, Ralf * libtoolize.m4sh: Revert use of `$tst_aclocaldir'. Index: libtoolize.m4sh === RCS file: /cvsroot/libtool/libtool/libtoolize.m4sh,v retrieving revision 1.44 diff -u -r1.44 libtoolize.m4sh --- libtoolize.m4sh 10 Nov 2005 17:51:36 - 1.44 +++ libtoolize.m4sh 14 Nov 2005 20:32:08 - @@ -1030,7 +1030,6 @@ pkgdatadir="$_lt_pkgdatadir/libltdl" aclocaldir="$_lt_pkgdatadir/libltdl/m4" fi - test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir" func_nonemptydir_p pkgltdldir func_nonemptydir_p pkgdatadir func_nonemptydir_p aclocaldir
Re: FYI: set macrodir correctly for installcheck [301]
Hi Gary, * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 09:06:40PM CET: > Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 06:52:45PM CET: > >> > >>Had to tweak slightly to make test-5 work with installcheck. > > > > Why? That would be a bug. The whole point of tst_aclocaldir was that > > it does _not_ appear in libtoolize. > > > > And in fact, over here, this change: > >> + test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir" > > > > is not needed at all. > > Huh? test 5 can't possibly pass for installcheck without it, because > there is no setting for _lt_pkgdatadir in INSTALLCHECK_ENVIRONMENT... > I'm all for a cleaner fix than my "tweak" if you have it though! :-) Did you actually see this failure? If yes, could you please post the corresponding testsuite.log failure output? For installcheck, the normal pkgdatadir setting in libtoolize should just suffice: the files will be installed there. And, in fact, both `installcheck' after `make install' as well as `distcheck' pass here without above line. Cheers, Ralf
Re: FYI: set macrodir correctly for installcheck [301]
Ralf Wildenhues wrote: > Hi Gary, Hallo Ralf! > * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 06:52:45PM CET: > >>Applied to HEAD. >> >>Had to tweak slightly to make test-5 work with installcheck. > > > Why? That would be a bug. The whole point of tst_aclocaldir was that > it does _not_ appear in libtoolize. > > And in fact, over here, this change: > > >> --- orig/libtoolize.m4sh >> +++ mod/libtoolize.m4sh >> @@ -1030,6 +1030,7 @@ >> pkgdatadir="$_lt_pkgdatadir/libltdl" >> aclocaldir="$_lt_pkgdatadir/libltdl/m4" >> fi >> + test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir" >> func_nonemptydir_p pkgltdldir >> func_nonemptydir_p pkgdatadir >> func_nonemptydir_p aclocaldir > > > is not needed at all. Huh? test 5 can't possibly pass for installcheck without it, because there is no setting for _lt_pkgdatadir in INSTALLCHECK_ENVIRONMENT... I'm all for a cleaner fix than my "tweak" if you have it though! :-) Cheers, Gary. -- Gary V. Vaughan ())_. [EMAIL PROTECTED],gnu.org} Research Scientist ( '/ http://tkd.kicks-ass.net GNU Hacker / )= http://www.gnu.org/software/libtool Technical Author `(_~)_ http://sources.redhat.com/autobook signature.asc Description: OpenPGP digital signature
Re: FYI: set macrodir correctly for installcheck [301]
Hi Gary, * Gary V. Vaughan wrote on Thu, Nov 10, 2005 at 06:52:45PM CET: > > Applied to HEAD. > > Had to tweak slightly to make test-5 work with installcheck. Why? That would be a bug. The whole point of tst_aclocaldir was that it does _not_ appear in libtoolize. And in fact, over here, this change: > --- orig/libtoolize.m4sh > +++ mod/libtoolize.m4sh > @@ -1030,6 +1030,7 @@ >pkgdatadir="$_lt_pkgdatadir/libltdl" >aclocaldir="$_lt_pkgdatadir/libltdl/m4" > fi > + test -n "$tst_aclocaldir" && aclocaldir="$tst_aclocaldir" > func_nonemptydir_p pkgltdldir > func_nonemptydir_p pkgdatadir > func_nonemptydir_p aclocaldir is not needed at all. Cheers, Ralf
