Re: libtool-next patch queue

[Gary V. Vaughan]

On 15 Oct 2010, at 10:58, Ralf Wildenhues wrote:
 Hi Gary,

Hallo Ralf,

 I promised I would look at your patch queue for rewriting bootstrap.

Much appreciated, thanks for making the time to do this.

While I don't have too much discretionary hacking time this month, I
will try to address any patch rewrites you need to continue the merge
in a reasonably timely fashion.

FTR, the bootstrap rewrite is directed at gnulib, although when they
have accepted it into their tree, I plan on using it for libtool too as
part of the move to using gnulib more fully - which is what libtool-next
is currently aiming towards.  My private branch (which is about 10
patches ahead of the published branch) is stuck on using git-version-gen,
since the CVS style version number is deeply entwined in the version
mismatch code in ltversion.m4 and ltmain.sh.

I'm also planning to use gnulib-tool to fetch argz from gnulib and
maybe other easy portability modules that don't take time away from
my long-term rewrite of libltdl - but I haven't yet begun to make
patches for any of that yet.

Cheers,
-- 
Gary V. Vaughan (g...@gnu.org)


PGP.sig
Description: This is a digitally signed message part

libtool-next patch queue

[Ralf Wildenhues]

Hi Gary,

I promised I would look at your patch queue for rewriting bootstrap.
You pushed it to the libtool-next branch, so let me go through the
patches in that queue in order (re-stating this so everybody is on the
same page here, some of the messages involved unfortunately went
off-list for completely unrelated reasons; apologies for that).

The patch queue goes from
   dd5b4f06557a4c5ec7b06d7814b95ecd63ab63b8^
to 0280c3687962199479258741cef4f32a2ccb8ffd

and for reference, I will just quote patches one by one here and/or
in followup mails, as appropriate.

The first three patches in the queue have previously been reviewed
already and their re-roll looks good to me.  I have merged these three
into master now:

 From dd5b4f06557a4c5ec7b06d7814b95ecd63ab63b8 Mon Sep 17 00:00:00 2001
 From: Gary V. Vaughan g...@gnu.org
 Date: Wed, 1 Sep 2010 14:41:52 +0700
 Subject: [PATCH 01/17] maint: rearrange Makefile.am in preparation for a 
 follow-up patch.
 
 * Makefile.am (Libtool scripts.): Move this section below the
 `Bootstrap.' section...
 (libtoolize.in): ...except this one which is generated at
 bootstrap time, and was added into the `Bootstrap.' section.
 (Libltdl.): Move this section below the `Libtool scripts.'
 section.

 From c9497cc81cc46ce8848452240a323266440c4cb9 Mon Sep 17 00:00:00 2001
 From: Gary V. Vaughan g...@gnu.org
 Date: Thu, 23 Sep 2010 17:00:08 +0700
 Subject: [PATCH 02/17] maint: don't leak developer GREP, SED etc into 
 distribution file.
 
 * Makefile.am: Having rearranged the file, now apply the actual
 changes to follow-up.
 (edit): Split into two parts...
 (bootstrap_edit): ...substitutions that should happen at bootstrap
 time...
 (configure_edit): ...and substitutions that should not happen until
 configure time.
 * Makefile.am (libltdl/m4/ltversion.m4, libltdl/config/ltmain.sh)
 (libtoolize.in, tests/package.m4): Use bootstrap_edit.
 (libtoolize, tests/defs): Use configure_edit.
 * HACKING (Release Procedure): Remove the note to workaround the
 bug fixed by this changeset.
 * NEWS (Bug fixes): Mention that this bug is now fixed.
 Reported by Joerg Sonnenberger.

 From a2bb0c980f2b50ab31fedd18bb4890843b3d399a Mon Sep 17 00:00:00 2001
 From: Gary V. Vaughan g...@gnu.org
 Date: Fri, 24 Sep 2010 12:51:36 +0700
 Subject: [PATCH 03/17] libtool: remove redundant unsubstituted shell var 
 defaults.
 
 * Makefile.am (libltdl/config/ltmain.sh): Boilerplate code from
 libltdl/config/general.m4 sets some default shell variables
 designed to be substituted by `$(configure_edit)'.  Actually,
 `libtool' uses the language tag values for those variables, and
 `ltmain.m4sh' is not passed through `$(configure_edit)', so they
 are just noise.  Edit them out at bootstrap time.

The next patch needs fixes.  I'll followup.

Cheers,
Ralf