Re: [Libva] [PATCH v2 intel-driver 3/8] surface: fix vaDeriveImage() for grayscale.

2014-05-14 Thread Zhao, Yakui 
On Wed, 2014-05-14 at 07:13 -0600, Gwenole Beauchesne wrote:
 Allow vaDeriveImage() to work with grayscale surfaces by only exposing
 the luma component.
 

This is not necessary as the DeriveImage already supports the Y800
fourcc.

 Signed-off-by: Gwenole Beauchesne gwenole.beauche...@intel.com
 ---
  src/i965_drv_video.c |6 ++
  1 file changed, 6 insertions(+)
 
 diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
 index 589c00c..495ad44 100755
 --- a/src/i965_drv_video.c
 +++ b/src/i965_drv_video.c
 @@ -3222,6 +3222,12 @@ VAStatus i965_DeriveImage(VADriverContextP ctx,
  image-format.bits_per_pixel = 12;
  
  switch (image-format.fourcc) {
 +case VA_FOURCC_Y800:
 +image-num_planes = 1;
 +image-pitches[0] = w_pitch; /* Y */
 +image-offsets[0] = 0;
 +break;
 +
  case VA_FOURCC_YV12:
  image-num_planes = 3;
  image-pitches[0] = w_pitch; /* Y */


___
Libva mailing list
Libva@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH v2 intel-driver 3/8] surface: fix vaDeriveImage() for grayscale.

2014-05-14 Thread Gwenole Beauchesne 
2014-05-15 2:35 GMT+02:00 Zhao, Yakui yakui.z...@intel.com:
 On Wed, 2014-05-14 at 07:13 -0600, Gwenole Beauchesne wrote:
 Allow vaDeriveImage() to work with grayscale surfaces by only exposing
 the luma component.


 This is not necessary as the DeriveImage already supports the Y800
 fourcc.

What? Where? I don't call already supports as returning an error.


 Signed-off-by: Gwenole Beauchesne gwenole.beauche...@intel.com
 ---
  src/i965_drv_video.c |6 ++
  1 file changed, 6 insertions(+)

 diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
 index 589c00c..495ad44 100755
 --- a/src/i965_drv_video.c
 +++ b/src/i965_drv_video.c
 @@ -3222,6 +3222,12 @@ VAStatus i965_DeriveImage(VADriverContextP ctx,
  image-format.bits_per_pixel = 12;

  switch (image-format.fourcc) {
 +case VA_FOURCC_Y800:
 +image-num_planes = 1;
 +image-pitches[0] = w_pitch; /* Y */
 +image-offsets[0] = 0;
 +break;
 +
  case VA_FOURCC_YV12:
  image-num_planes = 3;
  image-pitches[0] = w_pitch; /* Y */


___
Libva mailing list
Libva@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH v2 intel-driver 3/8] surface: fix vaDeriveImage() for grayscale.

2014-05-14 Thread Zhao, Yakui 
On Wed, 2014-05-14 at 22:14 -0600, Gwenole Beauchesne wrote:
 2014-05-15 2:35 GMT+02:00 Zhao, Yakui yakui.z...@intel.com:
  On Wed, 2014-05-14 at 07:13 -0600, Gwenole Beauchesne wrote:
  Allow vaDeriveImage() to work with grayscale surfaces by only exposing
  the luma component.
 
 
  This is not necessary as the DeriveImage already supports the Y800
  fourcc.
 
 What? Where? I don't call already supports as returning an error.
 

This is added in the following commit:

commit 9f9c505ed5212ae0704f71f45532b9716ac0bd51
Author: Zhong Li zhong...@intel.com
Date:   Mon Apr 14 02:17:42 2014 -0600

i965_DeriveImage() support JPEG color formats

Signed-off-by: Zhong Li zhong...@intel.com

Thanks.
Yakui

 
  Signed-off-by: Gwenole Beauchesne gwenole.beauche...@intel.com
  ---
   src/i965_drv_video.c |6 ++
   1 file changed, 6 insertions(+)
 
  diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
  index 589c00c..495ad44 100755
  --- a/src/i965_drv_video.c
  +++ b/src/i965_drv_video.c
  @@ -3222,6 +3222,12 @@ VAStatus i965_DeriveImage(VADriverContextP ctx,
   image-format.bits_per_pixel = 12;
 
   switch (image-format.fourcc) {
  +case VA_FOURCC_Y800:
  +image-num_planes = 1;
  +image-pitches[0] = w_pitch; /* Y */
  +image-offsets[0] = 0;
  +break;
  +
   case VA_FOURCC_YV12:
   image-num_planes = 3;
   image-pitches[0] = w_pitch; /* Y */
 
 


___
Libva mailing list
Libva@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libva