[Libvir] question about informations
Hi, I have a question about informations. Is this english word usual? Since this informations exists in many places. (over 100 in libvirt code) I do not want to change this to information. Thanks Atsushi SAKAI -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [Libvir] question about informations
On Fri, Mar 14, 2008 at 06:19:31PM +0900, Atsushi SAKAI wrote: I have a question about informations. Is this english word usual? Since this informations exists in many places. (over 100 in libvirt code) I do not want to change this to information. Those are all mistakes. They should be changed to information. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [PATCH] fix information*s* to information. Re: [Libvir] question about informations
On Fri, Mar 14, 2008 at 07:23:45PM +0900, Atsushi SAKAI wrote: Hi, I fix this typo. I'll have a look at this and apply it. Thanks! Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [Libvir] java-libvirt on cvs:libvirt.org
On Fri, Dec 28, 2007 at 01:55:52PM +0100, Daniel Schwager wrote: Hallo list, i took the java-libvirt port from Tóth István (Thank you - great work !!) and added - the some features from libvirt 0.4.0 - integrate of xsd XML-description / validator - added auto generation of XML-beans related to the XSD file. - project build.xml file - integration of testng - remote building of JNI library - remote testing of junit/testing tests So, I want to publish to port to a public cvs-tree. Is there a little space on the libvirt website for this port ? The question was asked beginning of January, sorry i was on vacations at the time and didn't followed up ... but we really should not drop this. Answer is clearly yes, I just want to make sure there would be some continuity in keeping the project, so Daniel (or Tóth if you have more time now), I would like to reiterate the offer, host CVS (or mercurial) for the project as well as releases. The goal would be to make sure it works properly with the Open Source Java implementations too, and make it available as widely as possible, opinions ? Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [Libvir] java-libvirt on cvs:libvirt.org
As I am still unable to make the commitment of properly maintaining the package for a reasonable period, I think Daniel would be the better choice as maintainer, if he is still willing. regards István Tóth Daniel Veillard wrote: On Fri, Dec 28, 2007 at 01:55:52PM +0100, Daniel Schwager wrote: Hallo list, i took the java-libvirt port from Tóth István (Thank you - great work !!) and added - the some features from libvirt 0.4.0 - integrate of xsd XML-description / validator - added auto generation of XML-beans related to the XSD file. - project build.xml file - integration of testng - remote building of JNI library - remote testing of junit/testing tests So, I want to publish to port to a public cvs-tree. Is there a little space on the libvirt website for this port ? The question was asked beginning of January, sorry i was on vacations at the time and didn't followed up ... but we really should not drop this. Answer is clearly yes, I just want to make sure there would be some continuity in keeping the project, so Daniel (or Tóth if you have more time now), I would like to reiterate the offer, host CVS (or mercurial) for the project as well as releases. The goal would be to make sure it works properly with the Open Source Java implementations too, and make it available as widely as possible, opinions ? Daniel -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[Libvir] PATCH: Fix dir/fs storage pool when SELinux is disabled
When SELinux is disabled fgetfilecon() may well return -1, if a file has no
extended attribute with security context data. This causes the storage pool
to skip that file. The fix is to check whether errno is ENODATA and treat
that as an expected error case ignore it.
Dan.
Index: src/storage_backend.c
===
RCS file: /data/cvs/libvirt/src/storage_backend.c,v
retrieving revision 1.8
diff -u -p -r1.8 storage_backend.c
--- src/storage_backend.c 27 Feb 2008 10:37:19 - 1.8
+++ src/storage_backend.c 14 Mar 2008 21:21:05 -
@@ -240,17 +240,22 @@ virStorageBackendUpdateVolInfoFD(virConn
#if HAVE_SELINUX
if (fgetfilecon(fd, filecon) == -1) {
-virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
- _(cannot get file context of %s: %s),
- vol-target.path, strerror(errno));
-return -1;
-}
-vol-target.perms.label = strdup(filecon);
-if (vol-target.perms.label == NULL) {
-virStorageReportError(conn, VIR_ERR_NO_MEMORY, %s, _(context));
-return -1;
+if (errno != ENODATA) {
+virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
+ _(cannot get file context of %s: %s),
+ vol-target.path, strerror(errno));
+return -1;
+} else {
+vol-target.perms.label = NULL;
+}
+} else {
+vol-target.perms.label = strdup(filecon);
+if (vol-target.perms.label == NULL) {
+virStorageReportError(conn, VIR_ERR_NO_MEMORY, %s, _(context));
+return -1;
+}
+freecon(filecon);
}
-freecon(filecon);
#else
vol-target.perms.label = NULL;
#endif
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[Libvir] PATCH: Fix virStoragePoolCreate() operation
The virStoragePoolCreate() was not checking for a potentially NULL field
against startPool() backend driver. It was also failing to run the refresh
operation after starting it. The former caused a crash, the latter caused
no volumes to show up
Dan.
Index: src/storage_driver.c
===
RCS file: /data/cvs/libvirt/src/storage_driver.c,v
retrieving revision 1.2
diff -u -p -r1.2 storage_driver.c
--- src/storage_driver.c22 Feb 2008 16:26:13 - 1.2
+++ src/storage_driver.c14 Mar 2008 21:34:04 -
@@ -416,8 +416,12 @@ storagePoolCreate(virConnectPtr conn,
return NULL;
}
-if (backend-startPool(conn, pool) 0) {
-virStoragePoolObjRemove(driver, pool);
+if (backend-startPool
+backend-startPool(conn, pool) 0)
+return NULL;
+if (backend-refreshPool(conn, pool) 0) {
+if (backend-stopPool)
+backend-stopPool(conn, pool);
return NULL;
}
pool-active = 1;
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
