Re: [libvirt] [PATCH] Fix enabling storage driver
On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote: As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this. Odd ... but yes +1. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory
On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it. Please note to whomever is maintaining libvirt in Fedora that there is a change to the specfile. Any comments on this patch? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 59 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory
On Tue, Jun 10, 2008 at 09:39:44AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it. Please note to whomever is maintaining libvirt in Fedora that there is a change to the specfile. Any comments on this patch? Looks ok to me now. Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory
On Tue, Jun 10, 2008 at 09:39:44AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it. Please note to whomever is maintaining libvirt in Fedora that there is a change to the specfile. Any comments on this patch? Looks fine to me ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Release?
I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty long list of new features: - Support for serial and parallel devices in Xend - Network interface model in QEMU network devs - SetVcpus, DomainGetMaxVcpus, VCPU pinning in QEMU - Disk buses - Support for Xenner - Deprecate conn/dom/net fields in virterror - HTML documentation completely restructured - MinGW fixes - Memory leaks plugged - Added HACKING file and lots of work on unifying syntax and methods used in the code base to a single standard - Lots of LXR changes - virDomain*Peek APIs - and of course many bug fixes So is it time for a release? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty long list of new features: [snip] So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, thanks ! Danie -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
Daniel Veillard schreef: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty long list of new features: [snip] So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, Can the pool.patch be incorporated before the next release? http://kinkrsoftware.nl/contrib/libvirt/pool.patch (Is probably the latest) This basically hangs on the creation of a 'test' for pools in general. Stefan -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
Hi, Rich Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html Other patches are minor issue, it may skip it. Thanks Atsushi SAKAI Richard W.M. Jones [EMAIL PROTECTED] wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty long list of new features: - Support for serial and parallel devices in Xend - Network interface model in QEMU network devs - SetVcpus, DomainGetMaxVcpus, VCPU pinning in QEMU - Disk buses - Support for Xenner - Deprecate conn/dom/net fields in virterror - HTML documentation completely restructured - MinGW fixes - Memory leaks plugged - Added HACKING file and lots of work on unifying syntax and methods used in the code base to a single standard - Lots of LXR changes - virDomain*Peek APIs - and of course many bug fixes So is it time for a release? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Is this so that we can specify devices in /etc/xen files like 'phy:' or 'file:' (ie. without any actual device or filename following)? Then according to http://xenbits.xensource.com/xen-unstable.hg?rev/0a8fc1a62796 XenD will give an error? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
Hi, Rich Yes. When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image path error handling from libvirt to Xend. For this purpose, libvirt just pass VM image path without check. Xend reports error with following Xen patch. Thanks Atsushi SAKAI Richard W.M. Jones [EMAIL PROTECTED] wrote: On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Is this so that we can specify devices in /etc/xen files like 'phy:' or 'file:' (ie. without any actual device or filename following)? Then according to http://xenbits.xensource.com/xen-unstable.hg?rev/0a8fc1a62796 XenD will give an error? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 09:36:50PM +0900, Atsushi SAKAI wrote: When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image path error handling from libvirt to Xend. For this purpose, libvirt just pass VM image path without check. Xend reports error with following Xen patch. Yes, I think it looks fine. Any comments Dan? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html http://xenbits.xensource.com/xen-unstable.hg?rev/0a8fc1a62796 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 02:12:29PM +0200, Stefan de Konink wrote: Daniel Veillard schreef: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: I've just had a chat with Daniel about whether it's time for a new release of libvirt. My own primary focus is getting the virDomain*Peek APIs into a released version so I can use them from Fedora. libvirt 0.4.2 was released on 8th Apr 2008. I just scanned the changelog and there's a pretty long list of new features: [snip] So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, Can the pool.patch be incorporated before the next release? No, this is not developed enough. It doesn't support QEMU, it doesn't support XM, and there's not test cases. Dan. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 01:17:48PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Yes, I'm not sure why its needed either. It is only touching the xm_internal driver, which is only active for Xen = 3.0.3. Any new changeset will not impact it, because we'll be using the builtin inactive domain management. Dan. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 02:14:34PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:36:50PM +0900, Atsushi SAKAI wrote: When the user forget to add phy or file in VM image path, The error handled on libvirt previously without error message now. This patch change the VM image path error handling from libvirt to Xend. For this purpose, libvirt just pass VM image path without check. Xend reports error with following Xen patch. Yes, I think it looks fine. Any comments Dan? If it doesn't break the XM test suite then its probably ok to commit - if someone can add an extra test case datafile for it, even better. Though I'm still not entirely clear on why its only recently needed. Dan. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Daniel P. Berrange schreef: No, this is not developed enough. It works fine with Xen, so 'not developed' might not be the right word. The only thing that you mentioned, reverse mapping the configuration, is not a trivial problem. But this doesn't justify not including something that is working. Next to this, why should the patch be floating around, instead of importing it, in a mob branch? It doesn't support QEMU, Why doesn't QEMU use the same xml parsing routines? If you want me to add the same support to qemu_conf.c you are asking me this a bit late. it doesn't support XM, What is the difference between Xen and XM? and there's not test cases. Likewise for the rest of the storage pool commands. Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEAREKAAYFAkhOimMACgkQYH1+F2Rqwn3j4wCgi4NwAd+QnUNMyue65+EOOhDZ yPAAnisPr27LABsSEPJ7DfstzCSQtHuG =/QRT -END PGP SIGNATURE- -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 02:56:56PM +0100, Daniel P. Berrange wrote: On Tue, Jun 10, 2008 at 01:17:48PM +0100, Richard W.M. Jones wrote: On Tue, Jun 10, 2008 at 09:13:06PM +0900, Atsushi SAKAI wrote: Would you commit this patch? https://www.redhat.com/archives/libvir-list/2008-June/msg00031.html I'm not sure that I understand the use of this patch. Yes, I'm not sure why its needed either. It is only touching the xm_internal driver, which is only active for Xen = 3.0.3. Any new changeset will not impact it, because we'll be using the builtin inactive domain management. With a minor modification to remove a gcc warning, it passes all tests so I've committed it now. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, If the last two patches I posted could be pushed, I'd appreciate it. They are needed for the storage driver (Rich already ACK'd them). https://www.redhat.com/archives/libvir-list/2008-June/msg00042.html https://www.redhat.com/archives/libvir-list/2008-June/msg00082.html Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix UUIDString for python bindings
On Thu, Jun 05, 2008 at 02:08:41PM -0400, Cole Robinson wrote: The attached patch fixes a few issues in the python bindings. First, UUIDString has, to my understanding, never worked. It expected to be passed a buffer to fill with the uuid, which through my tests isn't realistically doable from python. I added custom bindings to fix this, and it now works as expected, taking no arguments and returning a string. UUID for a storage pool wasn't being generated with its custom function, so it too was broken. This is also fixed. I also removed some stale entries for virStorageVol UUID functions from generator.py which were probably just carried along from an old version of the storage api patches (storage volumes don't use UUID). Looks fine to me, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Fix enabling storage driver
On Tue, Jun 10, 2008 at 09:38:59AM +0100, Richard W.M. Jones wrote: On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote: As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this. Odd ... but yes +1. Yup, but in any case it doesn't seems it can do any harm, fine by me, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
On Tue, Jun 10, 2008 at 10:45:56AM -0400, Cole Robinson wrote: Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, If the last two patches I posted could be pushed, I'd appreciate it. They are needed for the storage driver (Rich already ACK'd them). haha, I knew I had missed some ! https://www.redhat.com/archives/libvir-list/2008-June/msg00042.html https://www.redhat.com/archives/libvir-list/2008-June/msg00082.html Thanks, Thanks, i had reviewed the UUID string one, but hadn't commited then i needed a reminder :-) Both commited now, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Release?
Daniel Veillard wrote: On Tue, Jun 10, 2008 at 10:45:56AM -0400, Cole Robinson wrote: Daniel Veillard wrote: On Tue, Jun 10, 2008 at 12:40:50PM +0100, Richard W.M. Jones wrote: So is it time for a release? Yes, I guess it makes sense :-) I will try to push a new release before the end of the week. Do we have patches pending which should be incorporated before ? I yes please (re)push them, If the last two patches I posted could be pushed, I'd appreciate it. They are needed for the storage driver (Rich already ACK'd them). haha, I knew I had missed some ! https://www.redhat.com/archives/libvir-list/2008-June/msg00042.html https://www.redhat.com/archives/libvir-list/2008-June/msg00082.html Thanks, Thanks, i had reviewed the UUID string one, but hadn't commited then i needed a reminder :-) Both commited now, Daniel I actually just hit another python bindings bug with the storage driver. I'll be sending the patch shortly. I'd like for that one to be pulled too since we will need it for future virt-manager work. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] Fix storage pool autostart python binding
The attached patch fixes a few issues with the storage api python bindings. The pool GetAutostart is now generated as intended. Also the libvirtError class now accepts the pool or vol object passed to it when a command fails. Thanks, Cole diff --git a/python/libvir.py b/python/libvir.py index 3a38898..784152a 100644 --- a/python/libvir.py +++ b/python/libvir.py @@ -15,13 +15,17 @@ import types # The root of all libvirt errors. class libvirtError(Exception): -def __init__(self, msg, conn=None, dom=None, net=None): +def __init__(self, msg, conn=None, dom=None, net=None, pool=None, vol=None): Exception.__init__(self, msg) if dom is not None: conn = dom._conn elif net is not None: conn = net._conn +elif pool is not None: +conn = pool._conn +elif vol is not None: +conn = vol._conn if conn is None: self.err = virGetLastError() diff --git a/python/libvirt-python-api.xml b/python/libvirt-python-api.xml index da643d7..f3b82fc 100644 --- a/python/libvirt-python-api.xml +++ b/python/libvirt-python-api.xml @@ -83,6 +83,11 @@ return type='int' info='the autostart flag, or None in case of error'/ arg name='domain' type='virDomainPtr' info='a network object'/ /function +function name='virStoragePoolGetAutostart' file='python' + infoExtract the autostart flag for a storage pool/info + return type='int' info='the autostart flag, or None in case of error'/ + arg name='pool' type='virStoragePoolPtr' info='a storage pool object'/ +/function function name='virDomainBlockStats' file='python' infoExtracts block device statistics for a domain/info return type='virDomainBlockStats' info='a tuple of statistics'/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
