Re: [libvirt] patch for virsh list
On Fri, May 15, 2009 at 09:48:14PM +0200, Gerrit Slomma wrote: > Hello > > I thought it would be cool if virsh list behaves a bit more like > virt-manager or xm list because as a system-administrator i want to know > with one look what VMs are active, how much memory they commit and what > their runtime is. > I implemented this with the following patch which give such an sample > output. > What is your opinion and/or have i missed something? If you want a virt-manager like display of VMs, 'virt-top' is the tool to use http://et.redhat.com/~rjones/virt-top/ Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] patch for virsh list
Daniel P. Berrange schrieb: If you want a virt-manager like display of VMs, 'virt-top' is the tool to use http://et.redhat.com/~rjones/virt-top/ Regards, Daniel Okay that gives the "xm top" but needs another tool to be installed. Since it comes from epel one could install it though. I gather extended info in virsh list is not wanted upstream then? I would find it handy when being in virsh to issue a "list" and find the commited memory, cpus of running VMs before firing up an additional VM. This is a little help to prevent overcommiting on a host and no-one could say he wasn't warned. Gerrit -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem
Quoting Ryota Ozaki (ozaki.ry...@gmail.com): > I've updated the patch. The change includes support for multiple mount > points of cgroups that I didn't cope with in the previous patch. > > Through the work, I found a bit messy problem. Current lxc controller writes > pid in a 'tasks' file multiple times if one mount point has multiple > subsystems. > It is bad because the first write changes the cgroups path of a controller, > and > then the second write points a missing file like > $CGROUPS_MOUNTPOINT///tasks where > the correct file is $CGROUPS_MOUNTPOINT//tasks. > I did workaround this problem with a tricky way by truncating the > duplicated path. > We probably need a more feasible solution. Seems like the loop in virCgroupAddTask() should just keep track of which hierarchies it has already written to. Just a small temporary hash table or for that matter a small array that you walk linearly... -serge -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list