Re: [libvirt] vshRunConsole:77 : unable to open tty

[Ruben Kerkhof]

On Jan 29, 2010, at 9:09 PM, Matthias Bolte wrote:


2010/1/29 Ruben Kerkhof :

Hi all,

I'm unable to open a serial console to a kvm virtual machine with  
virsh

console:

[r...@phy003 ~]# virsh console f12
Connected to domain f12
Escape character is ^]
20:43:48.282: error : vshRunConsole:77 : unable to open tty /dev/ 
pts/1 : No

such file or directory

If you look carefully to the message above, there's a space after / 
dev/pts/1


I can also see this in the xml:

[r...@phy003 ~]# virsh dumpxml f12 > f12.xml


   
 
 
   
   
 
 
   

I've run gdb over virsh, and this is what virDomainGetXMLDesc  
returns:



I'm not sure if this has already been fixed, this is
libvirt-0.7.5-3.fc12.x86_64 from the rawhide preview repo on F12,  
with

qemu-kvm-0.12.2-4.fc12.x86_64

Any help would be appreciated.

Ruben Kerkhof



I think this was fixed after the 0.7.5 release by this commit

http://libvirt.org/git/?p=libvirt.git;a=commit;h=c0a9b6a5338e54b64a4a28415ffbdb6bcc2b38c5

Matthias


Thanks, that did the trick!

Ruben



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: fix spelling error in hacking

[Matthias Bolte]

2010/1/27 Eric Blake :
> * HACKING: STRCASEEQ is case insensitive.
> * docs/hacking.html.in: Likewise.
> ---

ACK. I pushed it, thanks.

Matthias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util.c (virGetUserEnt): don't use a negative value as allocation size

[Jim Meyering]

Matthias Bolte wrote:
>> Subject: [PATCH] util.c (virGetUserEnt): don't use a negative value as 
>> allocation size
>>
>> * src/util/util.c (virGetUserEnt): In the unlikely event that
>> sysconf(_SC_GETPW_R_SIZE_MAX) fails, don't use -1 as the size in
>> the subsequent allocation.
...
> ACK.

Thanks.  Pushed.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Log flags in virConnectCompareCPU

[Matthias Bolte]

2010/1/27 Jiri Denemark :
> Signed-off-by: Jiri Denemark 
> ---
>  src/libvirt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 32f9fc4..8a9ee20 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -10951,7 +10951,7 @@ virConnectCompareCPU(virConnectPtr conn,
>                      const char *xmlDesc,
>                      unsigned int flags)
>  {
> -    VIR_DEBUG("conn=%p, xmlDesc=%s", conn, xmlDesc);
> +    VIR_DEBUG("conn=%p, xmlDesc=%s, flags=%u", conn, xmlDesc, flags);
>
>     virResetLastError();
>
> --
> 1.6.6.1
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util.c (virGetUserEnt): don't use a negative value as allocation size

[Matthias Bolte]

2010/1/28 Jim Meyering :
> Not a big deal, but reporting a failed sysconf call will make
> this far easier to diagnose than reporting an unwarranted OOM.
>
> >From 2bf48c9414cac791f03228ff15590414ec617f22 Mon Sep 17 00:00:00 2001
> From: Jim Meyering 
> Date: Thu, 28 Jan 2010 13:37:05 +0100
> Subject: [PATCH] util.c (virGetUserEnt): don't use a negative value as 
> allocation size
>
> * src/util/util.c (virGetUserEnt): In the unlikely event that
> sysconf(_SC_GETPW_R_SIZE_MAX) fails, don't use -1 as the size in
> the subsequent allocation.
> ---
>  src/util/util.c |    8 +++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/src/util/util.c b/src/util/util.c
> index 0ce5026..701581d 100644
> --- a/src/util/util.c
> +++ b/src/util/util.c
> @@ -2317,7 +2317,13 @@ static char *virGetUserEnt(virConnectPtr conn,
>     char *ret;
>     struct passwd pwbuf;
>     struct passwd *pw = NULL;
> -    size_t strbuflen = sysconf(_SC_GETPW_R_SIZE_MAX);
> +    long val = sysconf(_SC_GETPW_R_SIZE_MAX);
> +    size_t strbuflen = val;
> +
> +    if (val < 0) {
> +        virReportSystemError(conn, errno, "%s", _("sysconf failed"));
> +        return NULL;
> +    }
>
>     if (VIR_ALLOC_N(strbuf, strbuflen) < 0) {
>         virReportOOMError(conn);
> --
> 1.7.0.rc0.170.g7207c
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] vshRunConsole:77 : unable to open tty

[Matthias Bolte]

2010/1/29 Ruben Kerkhof :
> Hi all,
>
> I'm unable to open a serial console to a kvm virtual machine with virsh
> console:
>
> [r...@phy003 ~]# virsh console f12
> Connected to domain f12
> Escape character is ^]
> 20:43:48.282: error : vshRunConsole:77 : unable to open tty /dev/pts/1 : No
> such file or directory
>
> If you look carefully to the message above, there's a space after /dev/pts/1
>
> I can also see this in the xml:
>
> [r...@phy003 ~]# virsh dumpxml f12 > f12.xml
>
>
>    
>      
>      
>    
>    
>      
>      
>    
>
> I've run gdb over virsh, and this is what virDomainGetXMLDesc returns:
> 
>
> I'm not sure if this has already been fixed, this is
> libvirt-0.7.5-3.fc12.x86_64 from the rawhide preview repo on F12, with
> qemu-kvm-0.12.2-4.fc12.x86_64
>
> Any help would be appreciated.
>
> Ruben Kerkhof
>

I think this was fixed after the 0.7.5 release by this commit

http://libvirt.org/git/?p=libvirt.git;a=commit;h=c0a9b6a5338e54b64a4a28415ffbdb6bcc2b38c5

Matthias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libvirt: build error

[Matthias Bolte]

2010/1/28 Sharadha Prabhakar (3P) :
> Hi,
>
> I’m getting the following error when I make libvirt version 0.7.4
>
>
>
> Make all-recursive
>
> make[1]: Entering directory `/home/sharadhap/libvirt-0.7.4'
>
> Making all in gnulib/lib
>
> make[2]: Entering directory `/home/sharadhap/libvirt-0.7.4/gnulib/lib'
>
> make  all-recursive
>
> make[3]: Entering directory `/home/sharadhap/libvirt-0.7.4/gnulib/lib'
>
> make[4]: Entering directory `/home/sharadhap/libvirt-0.7.4/gnulib/lib'
>
> /bin/sh ../../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -I../..  -I../../intl   -g -O2 -MT printf-parse.lo -MD -MP -MF
> .deps/printf-parse.Tpo -c -o printf-parse.lo printf-parse.c
>
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../intl -g -O2 -MT
> printf-parse.lo -MD -MP -MF .deps/printf-parse.Tpo -c printf-parse.c  -fPIC
> -DPIC -o .libs/printf-parse.o
>
> In file included from printf-parse.c:70:
>
> xsize.h: In function 'xsum':
>
> xsize.h:59: error: expected expression before ')' token
>

I can reproduce this error, iff I enforce SIZE_MAX to be empty, e.g. by putting

#undef SIZE_MAX
#define SIZE_MAX

in front of the xsum function in xsize.h. Unchanged libvirt 0.7.4
tarball release compiles fine, as expected.

SIZE_MAX is defined in /usr/include/stdint.h on my Ubuntu 9.10 box
here. Maybe your /usr/include/stdint.h is broken, or gnulib decides to
use its own stdint.h. Does gnulib/lib/stdint.h exist after you run
make? If it does, how is SIZE_MAX defined in it?

Matthias

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] vshRunConsole:77 : unable to open tty

[Ruben Kerkhof]

Hi all,

I'm unable to open a serial console to a kvm virtual machine with  
virsh console:


[r...@phy003 ~]# virsh console f12
Connected to domain f12
Escape character is ^]
20:43:48.282: error : vshRunConsole:77 : unable to open tty /dev/pts/ 
1 : No such file or directory


If you look carefully to the message above, there's a space after /dev/ 
pts/1


I can also see this in the xml:

[r...@phy003 ~]# virsh dumpxml f12 > f12.xml



  
  


  
  


I've run gdb over virsh, and this is what virDomainGetXMLDesc returns:


I'm not sure if this has already been fixed, this is  
libvirt-0.7.5-3.fc12.x86_64 from the rawhide preview repo on F12, with  
qemu-kvm-0.12.2-4.fc12.x86_64


Any help would be appreciated.

Ruben Kerkhof

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Release 0.4.2 of libvirt-java

[Bryan Kearney]

I have just released 0.4.2 of libvirt java. This release fixes the NPE 
in xen Scheduled Parameters which was reported by Frederic Dangtran.


You can access the latest version via the following means:

Source Code: http://www.libvirt.org/git/?p=libvirt-java.git;a=summary
Bundled Source (tarball and SRPM): http://libvirt.org/sources/java/
Maven: http://libvirt.org/maven2/. They should hit the central repo in a 
day or two.

RPMS are making their way through the F12 and Rawhide build systems

Thank you!

-- bk

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release 0.4.1 of libvirt-java

[Bryan Kearney]

Great. I will work on a 0.4.2 release today and send it out.

-- bk

On 01/29/2010 10:37 AM, frederic.dangt...@orange-ftgroup.com wrote:

Yes it works. No longer any NPE when I invoke getSchedulerParameters()
on a Xen domain: I can retrieve both the scheduling cap and weight.
I guess the problem pops up only when there are more than 1 sched
parameter to return with the unmarshalling of the second one going wrong.

Frederic

On Jan 29, 2010, at 2:56 PM, Bryan Kearney wrote:


I posted a patched jar file at:

http://bkearney.fedorapeople.org/libvirt-0.4.1-PATCH.jar

The only change was making the struct into a union per your comments.
Can you let me now if this solves you NPE? It passes my tests.

-- bk

On 01/27/2010 08:40 PM, Bryan Kearney wrote:

Alright.. let me give it a try. I was not seeing the NPE in the tests I
ran.

-- bk

On 01/25/2010 01:15 PM, frederic.dangt...@orange-ftgroup.com wrote:


On Jan 18, 2010, at 3:44 PM, Bryan Kearney wrote:


I have just released 0.4.1 of libvirt java. There are 2 main items in
this release:

- Better null checking in for Scheduled Parameters which should fix
the issues reported on the list.
- Error Callbacks to provide better handling of errors encountered by
libvirt (virConnSetErrorFunc and virSetErrorFunc).

You can access the latest version via the following means:

Source Code: http://www.libvirt.org/git/?p=libvirt-java.git;a=summary
Bundled Source (tarball and SRPM): http://libvirt.org/sources/java/
Maven: http://libvirt.org/maven2/
RPMS are making their way through F-11 and F12 build systems

Thank you!

-- bk

--
libvir-list mailing list
libvir-list@redhat.com 
https://www.redhat.com/mailman/listinfo/libvir-list


Thanks for the update, Bryan, but the problem still persists. In my
setup (Xen hosts): Domain.getSchedulerParameters() still raises a NPE.

In libvirt.h, _virSchedParameter is defined as follows using a union for
the value:

struct _virSchedParameter {
char field[VIR_DOMAIN_SCHED_FIELD_LENGTH]; /* parameter name */
int type; /* parameter type */
union {
int i; /* data for integer case */
unsigned int ui; /* data for unsigned integer case */
long long int l; /* data for long long integer case */
unsigned long long int ul; /* data for unsigned long long integer
case */
double d; /* data for double case */
char b; /* data for char case */
} value; /* parameter value */
};

I believe the Java mapping of virSchedParameterValue should be a Union
instead of a Structure:
public class virSchedParameterValue extends Union {...}

Regards,
Frederic

--
Orange Labs
38-40 rue du General Leclerc
92794 Issy Moulineaux Cedex 9
FRANCE





*
This message and any attachments (the "message") are confidential and
intended solely for the addressees.
Any unauthorised use or dissemination is prohibited.
Messages are susceptible to alteration.
France Telecom Group shall not be liable for the message if altered,
changed or falsified.
If you are not the intended addressee of this message, please cancel
it immediately and inform the sender.



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list





***
Frederic Dang Tran

France Telecom R&D MAPS/MEP
38-40 rue du General Leclerc
92794 Issy Moulineaux Cedex 9
FRANCE

Tel: (+33) 1 45 29 60 88
Fax: (+33) 1 45 29 69 13
***




*
This message and any attachments (the "message") are confidential and intended 
solely for the addressees.
Any unauthorised use or dissemination is prohibited.
Messages are susceptible to alteration.
France Telecom Group shall not be liable for the message if altered, changed or 
falsified.
If you are not the intended addressee of this message, please cancel it 
immediately and inform the sender.



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release 0.4.1 of libvirt-java

[frederic.dangtran]

Yes it works. No longer any NPE when I invoke getSchedulerParameters() on a Xen 
domain: I can retrieve both  the scheduling cap and weight.
I guess the problem pops up only when there are more than 1 sched parameter to 
return  with the unmarshalling of the second one going wrong.

Frederic

On Jan 29, 2010, at 2:56 PM, Bryan Kearney wrote:

> I posted a patched jar file at:
> 
> http://bkearney.fedorapeople.org/libvirt-0.4.1-PATCH.jar
> 
> The only change was making the struct into a union per your comments. Can you 
> let me now if this solves you NPE? It passes my tests.
> 
> -- bk
> 
> On 01/27/2010 08:40 PM, Bryan Kearney wrote:
>> Alright.. let me give it a try. I was not seeing the NPE in the tests I
>> ran.
>> 
>> -- bk
>> 
>> On 01/25/2010 01:15 PM, frederic.dangt...@orange-ftgroup.com wrote:
>>> 
>>> On Jan 18, 2010, at 3:44 PM, Bryan Kearney wrote:
>>> 
 I have just released 0.4.1 of libvirt java. There are 2 main items in
 this release:
 
 - Better null checking in for Scheduled Parameters which should fix
 the issues reported on the list.
 - Error Callbacks to provide better handling of errors encountered by
 libvirt (virConnSetErrorFunc and virSetErrorFunc).
 
 You can access the latest version via the following means:
 
 Source Code: http://www.libvirt.org/git/?p=libvirt-java.git;a=summary
 Bundled Source (tarball and SRPM): http://libvirt.org/sources/java/
 Maven: http://libvirt.org/maven2/
 RPMS are making their way through F-11 and F12 build systems
 
 Thank you!
 
 -- bk
 
 --
 libvir-list mailing list
 libvir-list@redhat.com 
 https://www.redhat.com/mailman/listinfo/libvir-list
>>> 
>>> Thanks for the update, Bryan, but the problem still persists. In my
>>> setup (Xen hosts): Domain.getSchedulerParameters() still raises a NPE.
>>> 
>>> In libvirt.h, _virSchedParameter is defined as follows using a union for
>>> the value:
>>> 
>>> struct _virSchedParameter {
>>> char field[VIR_DOMAIN_SCHED_FIELD_LENGTH]; /* parameter name */
>>> int type; /* parameter type */
>>> union {
>>> int i; /* data for integer case */
>>> unsigned int ui; /* data for unsigned integer case */
>>> long long int l; /* data for long long integer case */
>>> unsigned long long int ul; /* data for unsigned long long integer case */
>>> double d; /* data for double case */
>>> char b; /* data for char case */
>>> } value; /* parameter value */
>>> };
>>> 
>>> I believe the Java mapping of virSchedParameterValue should be a Union
>>> instead of a Structure:
>>> public class virSchedParameterValue extends Union {...}
>>> 
>>> Regards,
>>> Frederic
>>> 
>>> --
>>> Orange Labs
>>> 38-40 rue du General Leclerc
>>> 92794 Issy Moulineaux Cedex 9
>>> FRANCE
>>> 
>>> 
>>> 
>>> 
>>> 
>>> *
>>> This message and any attachments (the "message") are confidential and
>>> intended solely for the addressees.
>>> Any unauthorised use or dissemination is prohibited.
>>> Messages are susceptible to alteration.
>>> France Telecom Group shall not be liable for the message if altered,
>>> changed or falsified.
>>> If you are not the intended addressee of this message, please cancel
>>> it immediately and inform the sender.
>>> 
>> 
>> --
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list
> 


***
Frederic Dang Tran

France Telecom R&D MAPS/MEP
38-40 rue du General Leclerc
92794 Issy Moulineaux Cedex 9
FRANCE

Tel: (+33) 1 45 29 60 88
Fax: (+33) 1 45 29 69 13
***





*
This message and any attachments (the "message") are confidential and intended 
solely for the addressees. 
Any unauthorised use or dissemination is prohibited.
Messages are susceptible to alteration. 
France Telecom Group shall not be liable for the message if altered, changed or 
falsified.
If you are not the intended addressee of this message, please cancel it 
immediately and inform the sender.


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Release 0.4.1 of libvirt-java

[Bryan Kearney]

I posted a patched jar file at:

http://bkearney.fedorapeople.org/libvirt-0.4.1-PATCH.jar

The only change was making the struct into a union per your comments. 
Can you let me now if this solves you NPE? It passes my tests.


-- bk

On 01/27/2010 08:40 PM, Bryan Kearney wrote:

Alright.. let me give it a try. I was not seeing the NPE in the tests I
ran.

-- bk

On 01/25/2010 01:15 PM, frederic.dangt...@orange-ftgroup.com wrote:


On Jan 18, 2010, at 3:44 PM, Bryan Kearney wrote:


I have just released 0.4.1 of libvirt java. There are 2 main items in
this release:

- Better null checking in for Scheduled Parameters which should fix
the issues reported on the list.
- Error Callbacks to provide better handling of errors encountered by
libvirt (virConnSetErrorFunc and virSetErrorFunc).

You can access the latest version via the following means:

Source Code: http://www.libvirt.org/git/?p=libvirt-java.git;a=summary
Bundled Source (tarball and SRPM): http://libvirt.org/sources/java/
Maven: http://libvirt.org/maven2/
RPMS are making their way through F-11 and F12 build systems

Thank you!

-- bk

--
libvir-list mailing list
libvir-list@redhat.com 
https://www.redhat.com/mailman/listinfo/libvir-list


Thanks for the update, Bryan, but the problem still persists. In my
setup (Xen hosts): Domain.getSchedulerParameters() still raises a NPE.

In libvirt.h, _virSchedParameter is defined as follows using a union for
the value:

struct _virSchedParameter {
char field[VIR_DOMAIN_SCHED_FIELD_LENGTH]; /* parameter name */
int type; /* parameter type */
union {
int i; /* data for integer case */
unsigned int ui; /* data for unsigned integer case */
long long int l; /* data for long long integer case */
unsigned long long int ul; /* data for unsigned long long integer case */
double d; /* data for double case */
char b; /* data for char case */
} value; /* parameter value */
};

I believe the Java mapping of virSchedParameterValue should be a Union
instead of a Structure:
public class virSchedParameterValue extends Union {...}

Regards,
Frederic

--
Orange Labs
38-40 rue du General Leclerc
92794 Issy Moulineaux Cedex 9
FRANCE





*
This message and any attachments (the "message") are confidential and
intended solely for the addressees.
Any unauthorised use or dissemination is prohibited.
Messages are susceptible to alteration.
France Telecom Group shall not be liable for the message if altered,
changed or falsified.
If you are not the intended addressee of this message, please cancel
it immediately and inform the sender.



--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Schedule for libvirt-0.7.6

[Daniel P. Berrange]

On Fri, Jan 15, 2010 at 09:35:53PM +0100, Daniel Veillard wrote:
>   So the plan is still to start the feature freeze end of next friday
> the 22 Jan and try to push 0.7.6 on the 29th.

Due to unforseen problems with QEMU + network device hotplug we need to
delay this release by a few days. I'm suggesting Wednesday 3rd as the
new date.

Specifically, we switched over to use -netdev for networking devices at
startup, but it turns out there is no way to use this facility from the
QEMU monitor, which breaks hotplug & unplug. So I need to back-out / disable
the code which enables use of '-netdev' again until QEMU fixes hotplug. 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libvirt: python bindings

[Pierre Riteau]

On 28 janv. 2010, at 19:11, Daniel P. Berrange wrote:

> On Thu, Jan 28, 2010 at 05:52:45PM +, Sharadha Prabhakar (3P) wrote:
>> Hi,
>> I'm writing XenServer APIs for libvirt and trying to test it on virt-Manager.
>> I need to build the libvirt python bindings for that.
>> I tried this for libvirt.
>> ./configure -with-xenapi -with-python
> 
> You need to use  --  not just -  with arguments, eg --with-python
> 
>> make
>> make install
>> 
>> I suppose this is supposed to build a .libs directory with libvirtmod.so in 
>> the ~/libvirt/python/
>> But I don't seem to have this at all after build. It was a clean build with 
>> no errors.
>> I need libvirtmod.so to link with virt-manager. I'm using libvirt version 
>> 0.7.4
>> Can anyone help me with this. Am I missing something here
> 
> Also make sure you have python-devel RPM installed (or equivalent) and
> have not disabled shared libraries when running configure.


When python-dev is not installed, configure currently (in version 0.7.5) 
disables the bindings:
  configure: Could not find python2.5/Python.h, disabling bindings
  and final output says Python: no

When --with-python is provided, shouldn't we error out instead of disabling 
bindings more or less silently?

-- 
Pierre Riteau -- PhD student, Myriads team, IRISA, Rennes, France
http://perso.univ-rennes1.fr/pierre.riteau/


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list