[libvirt] [PATCH] Fix build on Mingw32 wrt export of virNetServerGetDBusConn

2011-11-21 Thread Daniel P. Berrange 
From: "Daniel P. Berrange" 

Mingw32 complains if you request export of a symbol which does
not in fact exist.

* src/libvirt_bridge.syms, src/libvirt_macvtap.syms: Delete
  obsolete files
* src/libvirt_private.syms: Remove virNetServerGetDBusConn
* src/libvirt_dbus.syms: Add virNetServerGetDBusConn
---
 src/Makefile.am  |8 ++--
 src/libvirt_bridge.syms  |   23 ---
 src/libvirt_dbus.syms|2 ++
 src/libvirt_macvtap.syms |   10 --
 src/libvirt_private.syms |1 -
 5 files changed, 4 insertions(+), 40 deletions(-)
 delete mode 100644 src/libvirt_bridge.syms
 create mode 100644 src/libvirt_dbus.syms
 delete mode 100644 src/libvirt_macvtap.syms

diff --git a/src/Makefile.am b/src/Makefile.am
index f82be78..2ee42a1 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1175,16 +1175,12 @@ if WITH_DRIVER_MODULES
 USED_SYM_FILES += libvirt_driver_modules.syms
 endif
 
-if WITH_BRIDGE
-USED_SYM_FILES += libvirt_bridge.syms
-endif
-
 if WITH_LINUX
 USED_SYM_FILES += libvirt_linux.syms
 endif
 
-if WITH_MACVTAP
-USED_SYM_FILES += libvirt_macvtap.syms
+if HAVE_DBUS
+USED_SYM_FILES += libvirt_dbus.syms
 endif
 
 if WITH_LIBVIRTD
diff --git a/src/libvirt_bridge.syms b/src/libvirt_bridge.syms
deleted file mode 100644
index 626f6ee..000
--- a/src/libvirt_bridge.syms
+++ /dev/null
@@ -1,23 +0,0 @@
-#
-# These symbols are dependent upon --with-qemu or --with-lxc via
-# WITH_BRIDGE.
-#
-
-
-# bridge.h
-brAddBridge;
-brAddInetAddress;
-brAddInterface;
-brAddTap;
-brCreateTap;
-brDelInetAddress;
-brDeleteBridge;
-brDeleteTap;
-brHasBridge;
-brInit;
-brSetEnableSTP;
-brSetForwardDelay;
-brSetInetNetmask;
-brSetInterfaceMac;
-brSetInterfaceUp;
-brShutdown;
diff --git a/src/libvirt_dbus.syms b/src/libvirt_dbus.syms
new file mode 100644
index 000..a460ec5
--- /dev/null
+++ b/src/libvirt_dbus.syms
@@ -0,0 +1,2 @@
+# virnetserver.h
+virNetServerGetDBusConn;
diff --git a/src/libvirt_macvtap.syms b/src/libvirt_macvtap.syms
deleted file mode 100644
index b48565b..000
--- a/src/libvirt_macvtap.syms
+++ /dev/null
@@ -1,10 +0,0 @@
-#
-# These symbols are dependent on WITH_MACVTAP.
-#
-
-
-# macvtap.h
-delMacvtap;
-openMacvtapTap;
-vpAssociatePortProfileId;
-vpDisassociatePortProfileId;
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 7906f5d..f4e25c1 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1252,7 +1252,6 @@ virNetServerAddSignalHandler;
 virNetServerAutoShutdown;
 virNetServerClose;
 virNetServerFree;
-virNetServerGetDBusConn;
 virNetServerIsPrivileged;
 virNetServerNew;
 virNetServerQuit;
-- 
1.7.6.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [virt-tools-list] [osinfo PATCH 1/8] Add #include for strcmp

2011-11-21 Thread Daniel P. Berrange 
On Fri, Nov 18, 2011 at 11:26:21AM -0700, Eric Blake wrote:
> [adding virt-tools-list]
> 
> On 11/18/2011 11:04 AM, Christophe Fergeau wrote:
> > ---
> >  tools/osinfo-detect.c |1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c
> > index 6afa30a..be36afb 100644
> > --- a/tools/osinfo-detect.c
> > +++ b/tools/osinfo-detect.c
> > @@ -23,6 +23,7 @@
> >   */
> >  
> >  #include 
> > +#include 
> 
> I've typically seen libosinfo patches sent to
> virt-tools-l...@redhat.com.  However, I just glanced through README in
> libosinfo.git and didn't see any mention of the preferred address for
> patch submission, nor mention of a project web page.  Those would be
> some useful patches, to help steer further patches to the best list.

I'll change the README for that.

> As to patch 1/8, it's trivial enough that I can ACK, even if I haven't
> done anything else with libosinfo myself (I'll leave others to review
> the rest of the series).

ACK to all the other patches too

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] virt-viewer, requirement question

2011-11-21 Thread Daniel P. Berrange 
On Fri, Nov 18, 2011 at 03:38:07PM -0800, Jason Helfman wrote:
> >I see that this was moved to vncconnection.h, however I don't see this patch
> >in there. Is this patch still relevant to the code?
> >
> >http://osdir.com/ml/gtk-vnc-list/2009-11/msg00029.html
> >
> >Thanks,
> >Jason
> >
> 
> This has already been fixed by FreeBSD Gnome team, and will be updated when
> 9 comes out.

Do you have a pointer to the patch they applied to gtk-vnc ?  I would
like to apply it to the upstream GTK-VNC sources, so you don't need to
carry it separately in the future.


Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

<    1   2